From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration on feature/tree-sitter Date: Sat, 18 Jun 2022 22:57:47 +0200 Message-ID: <8e319163-d515-dfce-a928-3ecdf0cba117@secure.kjonigsen.net> References: <2c2746e5f2558a87e8eab6f0914264a020173a9d.camel@pm.me> <27630AA3-8026-4E24-8852-ACCD9325B99D@gmail.com> <0E9E702B-B07C-4794-8498-29B9320E14CC@gmail.com> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------QDzHm0Apyqm0pHVAS0Mbw4Jf" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3535"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Cc: Emacs Devel , Yoav Marco To: Yuan Fu , jostein@kjonigsen.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 18 22:59:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2fXN-0000j6-GY for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jun 2022 22:59:23 +0200 Original-Received: from localhost ([::1]:35522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2fXM-0000Uj-BP for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jun 2022 16:59:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2fW1-0007wC-Q4 for emacs-devel@gnu.org; Sat, 18 Jun 2022 16:57:57 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:35409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2fVz-0005vC-I1 for emacs-devel@gnu.org; Sat, 18 Jun 2022 16:57:57 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DE30C32006F2; Sat, 18 Jun 2022 16:57:50 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 18 Jun 2022 16:57:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm1; t= 1655585870; x=1655672270; bh=VQyb+glV/8nhUELmvG6X1uL4R1Ha4EybcYx Cz1ylNIg=; b=KhD/fXhCtWPUp1qG7yfmHYXo19KxbWRO244gyy9w/pcVw04I2fw DUOI1Rq5ynNTgUetmsW0+MYRuZLKlgkPyM1ULnvTP9DMUCYYDhpzgQUGYpDL9ufH 6AtqVcyJwxsYODw123jDK3AY4+Mm71AIZ16nDUTXiTOSGRCMkTzyOLNs6YpVmqwE LJhFbOLCLYXpxF33Ki+Q066dDGshsrNVCAAtloPd5hDwkx7w+kzFxpTwDU2PWwiH EKnbP+Hp7oAkxpX/hrkkeaIiR9nDHuI7GuPz8s44/kclYdm6p5j2+4HIu60orgl8 mGnoirz0Tu4puMukyMYToGV7Xm+5FcW+2uA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1655585870; x=1655672270; bh=VQyb+glV/8nhU ELmvG6X1uL4R1Ha4EybcYxCz1ylNIg=; b=RhqPZGDqkUhhIheL4vY8tK2X+kB4p fiF+uBImq/a7o9RGcEr9QRB5uLWLp/bx6gIcA8p3SgktO6T/vJQxTtSglPd+Cx0j 0iPQE/ZU5zBw2JyK2nnGKGfZDaSp35xJvHhIQ8ItC7YIT3ExF/i+Mi6GzAtnHmGU 0eGMa2C3K0zHFTtbaIOqBX49/Kclildla9iuj2mP3DjjhLV/0XCUfvXwlsK/pwrW GwG5QNRfE+X7tYmMvXzK1lBjwLA4RD2TruaH7jM7r8HBC0q0sGOHGZV1r8V9WGgr kItmwBHMqkEB7PJsRy46V4t17TCxAJWLyjzpJw4TESHoE3SZGuhbgt7YQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvjedgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfrhfuvfevfhfhjgesrgdtreertdefjeenucfhrhhomheplfho shhtvghinhgpmfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepheffteffjefgtefglefhgedt jeehieekjeffjefgheejheeffefgvdevteetveehnecuffhomhgrihhnpehkjhhnihhgsh gvnhdrnhhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Jun 2022 16:57:49 -0400 (EDT) Content-Language: nb-NO In-Reply-To: Received-SPF: pass client-ip=64.147.123.21; envelope-from=jostein@secure.kjonigsen.net; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291386 Archived-At: This is a multi-part message in MIME format. --------------QDzHm0Apyqm0pHVAS0Mbw4Jf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18.06.2022 02:28, Yuan Fu wrote: > > I’ve figure out the problem. It is due to my misunderstanding of how gc works. I’ve pushed a fix. > > On a separate note, I also pushed the change that makes treesit-parser-list a function (rather than a variable). > > Yuan Just FYI: Getting latest sources and compiling from scratch, I get the following build warning: In treesit-traverse-forward: treesit.el:291:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting) Besides that, I've tested your changes and they definitely fix the segfault. Great stuff! -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------QDzHm0Apyqm0pHVAS0Mbw4Jf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 18.06.2022 02:28, Yuan Fu wrote:

I’ve figure out the problem. It is due to my misunderstanding of how gc works. I’ve pushed a fix.

On a separate note, I also pushed the change that makes treesit-parser-list a function (rather than a variable).

Yuan

Just FYI: Getting latest sources and compiling from scratch, I get the following build warning:
In treesit-traverse-forward:
treesit.el:291:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
Besides that, I've tested your changes and they definitely fix the segfault. Great stuff!

--
Vennlig hilsen
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------QDzHm0Apyqm0pHVAS0Mbw4Jf--