From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Fu Yuan Newsgroups: gmane.emacs.bugs Subject: bug#31324: 26.0.91; Wrong AXSubrole of childframe on macOS Date: Sun, 20 May 2018 14:33:28 +0800 Message-ID: <8dd902e9-e94b-469e-8c8e-2f498b47387a@Spark> References: <58a8e0b4-311c-4aa4-a5f1-f968ca93b6d3@Spark> <20180501203758.GA74662@breton.holly.idiocy.org> <034b13c0-b1c0-4340-bfd5-3de34f60322f@Spark> <20180513101402.GB15823@breton.holly.idiocy.org> <4f6f4596-948e-471c-bb2b-aa8c8abead99@Spark> <20180513103341.GE15823@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="5b0149fc_6b8b4567_17b17" X-Trace: blaine.gmane.org 1526811010 6780 195.159.176.226 (20 May 2018 10:10:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 May 2018 10:10:10 +0000 (UTC) Cc: 31324@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 20 12:10:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKLHx-0001eU-RN for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 May 2018 12:10:06 +0200 Original-Received: from localhost ([::1]:45933 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKLK4-00021J-TC for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 May 2018 06:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKLJv-00021C-3R for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 06:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKLJq-00078q-4s for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 06:12:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33740) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKLJq-00078g-0V for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 06:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKLJp-0004iJ-QS for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 06:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Fu Yuan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 May 2018 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31324-submit@debbugs.gnu.org id=B31324.152681112018112 (code B ref 31324); Sun, 20 May 2018 10:12:01 +0000 Original-Received: (at 31324) by debbugs.gnu.org; 20 May 2018 10:12:00 +0000 Original-Received: from localhost ([127.0.0.1]:41637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKLJo-0004i3-E9 for submit@debbugs.gnu.org; Sun, 20 May 2018 06:12:00 -0400 Original-Received: from mail-qk0-f169.google.com ([209.85.220.169]:42889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKLJm-0004hp-Se for 31324@debbugs.gnu.org; Sun, 20 May 2018 06:11:59 -0400 Original-Received: by mail-qk0-f169.google.com with SMTP id b22-v6so9761827qkj.9 for <31324@debbugs.gnu.org>; Sun, 20 May 2018 03:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version; bh=VZsHxyoNRbxLjP4SzJ/VW6cLdLSZ4O/dEas2ceQ+jvE=; b=RSMYfKfsc2M+iZM0W06wFOaJ1n5qd7Tr1WHc99tmWzeLhErH6dYpag2KFNpox39dgD K1+4hX5EZCKq7Plxdq3+mEIv4sTLoSWmWrUeOmNJCoQ0TSKX32fbNQ2oD0SGRFAZ78fS 4KnTuV1Vtj9zYg9X0Zzkuiy+H/ofHDPedJeyd2ZCS9FM9j3cKyzcWE9NlYmNZdATgwVu cSWRKb2JSwOyRGJEWtYYKsUJy1Obr+p1QDNxVOyAjgBOS/fsXuGge5jrPgdWcEoggunS cjE/V6/n96UQZOiWB/86sFp9B0DQ9pI0sqJsbrgIj6C6lvinXO65i25UXO93+t3o2qPi ATaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version; bh=VZsHxyoNRbxLjP4SzJ/VW6cLdLSZ4O/dEas2ceQ+jvE=; b=Z6y349/dJRQ/tb9YQ/7jSASzSzH/KdE8KQsPIJeae0+9U9AkDIxBQZJymHP+Zvf9v4 5/Sj6P1Rbtg923tf32xRitdCha8REgguv8Xn2BzIRiLfRUo6GPeRGIRbeEaobqY19Ro8 yxHgs9N8MqhtfqRcULBkdOtni6vYWxW/HUTxkbJ9ybN7tp1qD439gJdZWGLhbpuNgV3n /PIWmM5yTk5j5wu5aNCEAEV8naAfZjYx1bSinArsDjCgHTOke7zHvnqds9oSf8bVHHHK RSNH6WzA+q0D8ZbgaiRWg4XhtL52kYNtP2rVWL8tgYi3pKsdHv8GO8mnlZ/PbBtPL0em AIAw== X-Gm-Message-State: ALKqPweI+FeqZ1cLy+XDYDWutTcTVjWXqSi05P0YldxaXeFOsPUQOh+a ABpRq5yshOzqVF2r+wGbIkQhNFwd X-Google-Smtp-Source: AB8JxZomIL3uwTtpvrSlZFTT28sH/XbBt/YdQj+8DXkrn5ofcYPQAEtlM1ov/NyQ8I4MWrw062ISQw== X-Received: by 2002:a37:3612:: with SMTP id d18-v6mr14682229qka.86.1526811113296; Sun, 20 May 2018 03:11:53 -0700 (PDT) Original-Received: from [127.0.0.1] (164.ip-144-217-84.net. [144.217.84.164]) by smtp.gmail.com with ESMTPSA id u192-v6sm8201228qka.55.2018.05.20.03.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 May 2018 03:11:52 -0700 (PDT) In-Reply-To: <20180513103341.GE15823@breton.holly.idiocy.org> X-Readdle-Message-ID: 8dd902e9-e94b-469e-8c8e-2f498b47387a@Spark X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146316 Archived-At: --5b0149fc_6b8b4567_17b17 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Alan, I applied the patch and rebuilt Emacs, then ran =C2=A0 =C2=A0=C2=A0(let ((frame (selected-frame))) =C2=A0 =C2=A0 =C2=A0 (make-frame-command) =C2=A0 =C2=A0 =C2=A0 (set-frame-parameter nil 'parent-frame frame)) And the subrole of the new frame is now =E2=80=9CAX=46loatingWindow=E2=80= =9D. I think that will do it. It there anything else that I can do=3F Sincerely, Yuan. On May 13, 2018, 6:33 PM +0800, Alan Third , wrote: > On Sun, May 13, 2018 at 06:17:10PM +0800, =46u Yuan wrote: > > Hi Alan, > > > > Where should I get the Emacs source files=3F > > I was getting those from emacs mirror on GitHub master branch. > > Last time I manually edited your fix and noticed that line numbers do= esn=E2=80=99t match. > > So I guess you are not using HEAD version to create those patches. > > > > What version or commit or branch should I use=3F > > The easiest way is to use git to get the emacs-26 branch, either from > savannah or emacs mirror. Then apply the patches using: > > git am > This applies the patch as a commit in git. > -- > Alan Third --5b0149fc_6b8b4567_17b17 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Hi Alan,

I applied the patch and rebuilt Emacs, then ran

&=23160;= &=23160;&=23160;(let ((frame (selected-frame)))

&=23160;= &=23160; &=23160; (make-frame-command)

&=23160;= &=23160; &=23160; (set-frame-parameter nil 'parent-frame frame))


And the = subrole of the new frame is now =E2=80=9CAX=46loatingWindow=E2=80=9D.

=


I think = that will do it. It there anything else that I can do=3F


Sincerely, Yuan.

On May 13, 2018, 6:33 PM +0800, Alan Third <alan=40idiocy.org>, wro= te:
On Sun, May 13, 2018 at 06:17:= 10PM +0800, =46u Yuan wrote:
Hi Alan,

Where should I get the Emacs source files=3F
I was getting those from emacs mirror on GitHub master branch.
Last time I manually edited your fix and noticed that line numbers doesn=E2= =80=99t match.
So I guess you are not using HEAD version to create those patches.

What version or commit or branch should I use=3F

The easiest way is to use git to get the emacs-26 branch, either from
savannah or emacs mirror. Then apply the patches using:

git am <patch=E2=80=90file=E2=80=90name

This applies the patch as a commit in git.
--
Alan Third
--5b0149fc_6b8b4567_17b17--