From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Date: Fri, 30 Aug 2024 16:01:00 -0400 Message-ID: <8d5956f2-545d-470d-8f61-59670570b868@app.fastmail.com> References: <86jzgg5pgv.fsf@gnu.org> <86frqunwgu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34450"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Jim Porter" , "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 30 22:01:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sk7oS-0008oj-D5 for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Aug 2024 22:01:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sk7oC-0003Ba-QF; Fri, 30 Aug 2024 16:01:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sk7oB-0003BB-Kn for emacs-devel@gnu.org; Fri, 30 Aug 2024 16:01:23 -0400 Original-Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sk7o9-00061c-Rr; Fri, 30 Aug 2024 16:01:23 -0400 Original-Received: from phl-compute-01.internal (phl-compute-01.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id CF9DA11400B5; Fri, 30 Aug 2024 16:01:20 -0400 (EDT) Original-Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-01.internal (MEProxy); Fri, 30 Aug 2024 16:01:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1725048080; x=1725134480; bh=b6rQxp6shwPq88uB6K+HVC3YczOt9Gwz /n9tc4hH0Ec=; b=W2QogDFqoSMfpU2TpiIN0uHGm4WA4czGOSz1qwcPjzOqAiYn wC1+C5+3vE13vuL0GvLuchlam/LwsJKbFvwC2QZQLpSToVC3UJFv6+q9E7s5zoQw zDvZPId1pwb1exRrcnEHpjzaZo/d7wo32Auh4i5SVhxVcMtMZIWE4QdXyZ520hVs kfImLqBREyqW9YOA9J6OXLhDmdqVoyWNqjgjGn8lYI82BcDy5gJG/ADNiOHZGZvl CSFufL6hCgyMcDmAeSA30ux5gqJY7UkeBHdShRS94XJlS48173vCez0pk95mdcMM bCr+j9i3XC9AUBa+YoyEbHQz7rJXupxPNP170g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725048080; x= 1725134480; bh=b6rQxp6shwPq88uB6K+HVC3YczOt9Gwz/n9tc4hH0Ec=; b=a kWnNZ4WCVGouolKME0KP43OEH8e/fmAHHOVcqsjgdCTswwqg0poF1ZEH+ZSDotBI QFj2DJ/2i/mWa8jSgJabuYl8QHnY9b6X2RHwkxcwzAseInDRbsUB65Q8e2TFY1gA il6DODptR533Hrl/e4fky4PX0arj/TadmCpoz0bdIwIGnnubMY3gTQ8oXRTGCAY2 NWy0NZUIVYMmW9h4xRN3BUpEfqD+hIbSWRPt+p5At++82B940kLTquTN8c0qiCeB aqN+QapBa4Tusa8XfoCCavCMpFIWPO4yQXDqCizioJtes4nF2+lZgaFJPckukWW5 i5s7yxvB+YnS4lU10H3FA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefiedgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt jeenucfhrhhomhepufgvsggrshhtihojnhcuofhonhovrgcuoehsvggsrghsthhirghnse hsvggsrghsmhhonhhirgdrtghomheqnecuggftrfgrthhtvghrnhepheeggedvfeejfeej hffhffeltdejtedvffevieffteeifeejffegffevleevtdelnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshgvsggrshhtihgrnhesshgvsggr shhmohhnihgrrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopehjphhorhhtvghrsghughhssehgmhgrihhlrdgtohhmpdhrtghpthht ohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesgh hnuhdrohhrgh X-ME-Proxy: Feedback-ID: iab2c46da:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id A6C191C20065; Fri, 30 Aug 2024 16:01:20 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: Received-SPF: pass client-ip=103.168.172.153; envelope-from=sebastian@sebasmonia.com; helo=fhigh2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323217 Archived-At: Hi Jim, Thanks for your review. On Sat, Aug 24, 2024, at 1:27 PM, Jim Porter wrote: > So I think we'd want some new function like 'eww--do-list-buffers' that > takes the code from 'eww-list-buffers' that actually writes out the text > (i.e. the 'let' form starting with '(inhibit-read-only t)'). Then have > 'eww-list-buffers' call that, and set 'revert-buffer-function' to > 'eww--do-list-buffers'. Or something like that anyway... You are entirely correct, will provide an updated patch whenever I get a chance. Thank you, Seb