From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Fri, 18 Dec 2020 17:29:48 +0200 Message-ID: <8d49fda7-289f-46c9-d8d9-35e73bdf2912@yandex.ru> References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Glenn Morris , 29193@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 18 16:38:56 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqHqJ-0000Xm-Mq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 16:38:55 +0100 Original-Received: from localhost ([::1]:54768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqHqI-0007Tp-Ng for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 10:38:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqHhi-0006d8-L4 for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:30:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56346) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqHhi-0002kO-B9 for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqHhi-0004dP-5J for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Dec 2020 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29193 X-GNU-PR-Package: emacs Original-Received: via spool by 29193-submit@debbugs.gnu.org id=B29193.160830539917783 (code B ref 29193); Fri, 18 Dec 2020 15:30:02 +0000 Original-Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 15:29:59 +0000 Original-Received: from localhost ([127.0.0.1]:39659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHhe-0004ck-Sv for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:29:59 -0500 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:38842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHhc-0004cV-QC for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 10:29:57 -0500 Original-Received: by mail-wm1-f44.google.com with SMTP id g185so2959414wmf.3 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 07:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=x+yJjtSJXgNw14HDUncaQINV8Op6FHtLQCRmw2y1zGw=; b=F3wzTzkLyt3MmgGX6dDfMMyBxKNb302XE+x6OLjoDGfw7LLfLISuezNkvvW1rSRfqV +fFcM2/OfEFgflc7JSp5bvrLegE6na+C1A6kqCwkUxN4rQEPskp7Wfwib39lxmTB9sMq CbCyw3Mj3XsCo1t6MVWjePfIcLY3Nn+I99AA87GFvX1aIpJCH9XtEhSwmWGHZPhQ9Bkw Wz/NVZdUBJKR34JXklf6mJzH4xi/P4Y9ohRfs6mDPDgd+M/DKeiDoshkCbkJxWvIK8R0 S9WEsshT/ILqz9c0p2qb9lj+wp7k6WdltfMoa+Qwwom8a+EX+8Eo/rnoE45uAzeeq88n PgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x+yJjtSJXgNw14HDUncaQINV8Op6FHtLQCRmw2y1zGw=; b=XlQ0XtKpu3ja4vs32hdgGE6aNR2P0NHzl+wRTf9Tc737R5dN1EOkamLMj7WcZD4s1X wFdmP9TMiA4Qhb1A/CIa8FzI292kfe5U4BRNG4RiTldE9i/hbR8ARpCsuRJ0Wf5RJH66 WCf6LVBTet4xsfe+FsFDoMwX3H4sJ8FGEbAcwTT3zZ7bT3Sb/mDuMkcFq1lDzaa4oWpF B7cWYVJBxWqvfk0FK7TnXatsIn/01/QtkuiA+W4hrTOxc0vxnxwTeRMCk4vfbZzEGFLv FohodbIREzvCkgLAqfiml7OhCLYteCR3r3fxdlVQC0wa4mPxJKe49HyGlm0t9K1xXRvi jgaA== X-Gm-Message-State: AOAM530/3nYyZNOfes91KwEbN+G3dvVBFa2J4QQcnxYynScdnr/G1MVe t4hSyqy9EgGJWVULSjXqzRByNbopgVbNcA== X-Google-Smtp-Source: ABdhPJyjaA94Yv1PNWTWc2ppacgiFqfNt/BhZgmhG1kDBqdmYdK7gA6dkGuXJLyZvBipIno8ox6S6A== X-Received: by 2002:a1c:dd07:: with SMTP id u7mr4796307wmg.51.1608305390796; Fri, 18 Dec 2020 07:29:50 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l1sm14560449wrq.64.2020.12.18.07.29.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Dec 2020 07:29:50 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196327 Archived-At: On 18.12.2020 17:26, João Távora wrote: > On Fri, Dec 18, 2020 at 3:22 PM Dmitry Gutov wrote: >> >> On 18.12.2020 13:42, João Távora wrote: >> >>> I think this is rather a thingatpt.el issue, which makes no mention of >>> match-data destruction. Regardless, it's decent enough to do that in >>> flymake-diag-region so I pushed save-match-data a bit higher. >> >> By default we assume that any function can destroy match-data (and only >> a certain set doesn't). > > By that reasoning the problem should be solved in whoever called > flymake-diag-region and wrongly assumed it would keep match data. Yes. > Doesn't a seem very friendly API tho (and no idea who it was, anyway). Also true. So we can document that flymake-diag-region does indeed preserve match data.