From: Dmitry Gutov <dgutov@yandex.ru>
To: "João Távora" <joaotavora@gmail.com>
Cc: Glenn Morris <rgm@gnu.org>, 29193@debbugs.gnu.org
Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal
Date: Fri, 18 Dec 2020 17:29:48 +0200 [thread overview]
Message-ID: <8d49fda7-289f-46c9-d8d9-35e73bdf2912@yandex.ru> (raw)
In-Reply-To: <CALDnm50t9gCwPhWw_cfkM6XHrVwOOM8fMxEayk00WFuuBuQAVw@mail.gmail.com>
On 18.12.2020 17:26, João Távora wrote:
> On Fri, Dec 18, 2020 at 3:22 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
>>
>> On 18.12.2020 13:42, João Távora wrote:
>>
>>> I think this is rather a thingatpt.el issue, which makes no mention of
>>> match-data destruction. Regardless, it's decent enough to do that in
>>> flymake-diag-region so I pushed save-match-data a bit higher.
>>
>> By default we assume that any function can destroy match-data (and only
>> a certain set doesn't).
>
> By that reasoning the problem should be solved in whoever called
> flymake-diag-region and wrongly assumed it would keep match data.
Yes.
> Doesn't a seem very friendly API tho (and no idea who it was, anyway).
Also true. So we can document that flymake-diag-region does indeed
preserve match data.
next prev parent reply other threads:[~2020-12-18 15:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 15:28 bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Dmitry Gutov
2020-12-12 11:39 ` Lars Ingebrigtsen
2020-12-12 23:56 ` Dmitry Gutov
2020-12-13 12:51 ` Lars Ingebrigtsen
2020-12-13 13:19 ` João Távora
2020-12-13 20:55 ` Dmitry Gutov
2020-12-14 11:03 ` João Távora
2020-12-16 0:55 ` Dmitry Gutov
[not found] ` <handler.29193.D29193.160808016725606.notifdone@debbugs.gnu.org>
2020-12-17 23:25 ` Glenn Morris
2020-12-18 2:06 ` Dmitry Gutov
2020-12-18 11:42 ` João Távora
2020-12-18 15:22 ` Dmitry Gutov
2020-12-18 15:26 ` João Távora
2020-12-18 15:29 ` Dmitry Gutov [this message]
2020-12-18 15:39 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d49fda7-289f-46c9-d8d9-35e73bdf2912@yandex.ru \
--to=dgutov@yandex.ru \
--cc=29193@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.