From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64069: 30.0.50; Mistyped shy group regexps Date: Thu, 15 Jun 2023 04:45:45 +0300 Message-ID: <8d2a4d47-10d7-d16e-85d2-8009781a0dbc@gutov.dev> References: <87v8fq570k.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19648"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Alan Mackenzie , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Paul Eggert To: Basil Contovounesios , 64069@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 03:46:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9c4R-0004tK-U5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 03:46:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9c48-00013o-FX; Wed, 14 Jun 2023 21:46:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9c45-00013T-C6 for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 21:46:21 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9c3n-0004lw-0S for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 21:46:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9c3m-00005L-FN for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 21:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2023 01:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64069 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64069-submit@debbugs.gnu.org id=B64069.1686793559312 (code B ref 64069); Thu, 15 Jun 2023 01:46:02 +0000 Original-Received: (at 64069) by debbugs.gnu.org; 15 Jun 2023 01:45:59 +0000 Original-Received: from localhost ([127.0.0.1]:45821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9c3i-00004x-Nu for submit@debbugs.gnu.org; Wed, 14 Jun 2023 21:45:59 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9c3g-0008WN-I2 for 64069@debbugs.gnu.org; Wed, 14 Jun 2023 21:45:57 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE03B5C01D6; Wed, 14 Jun 2023 21:45:49 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 14 Jun 2023 21:45:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1686793549; x=1686879949; bh=l9muLaUUklTtTbZnk8Kl9ZL9dp+SNacFPAX lQ/og9Yw=; b=MWZ+Q601QmZDo7YeA4JgboPuF037Sp4Sgeedw1rnHc9VbWJ8Ulq I5feUzLFmxEhCOlVrgnjH3SKtTvIKdDONY4lMt3dZsh5AWtw4loOpNd0FsvVajxg lHOi4qjzAO8O/e702XQC0q2MNpN6uzmOnZC9SGT16oCtmMcGNX7t3G9uNHC4bBba jFekmOztgImOTU7OyjoOhm2mZceDQ3d59/QfvIhIj5Tp8iwRFD1taKc+pnrA7WIa QeRWeagu2i0wUzIx99jRPE+Sg47WlEq0Iz2q3SqtYtu52JPES2hJ2ePelo/IusIJ gDEyyvWbKEQXBtjsHHQ29hOhj6blQGYUc6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686793549; x=1686879949; bh=l9muLaUUklTtTbZnk8Kl9ZL9dp+SNacFPAX lQ/og9Yw=; b=k06Jl35+tnYysBy/B/sLmatedwaLVTrmKWgZnh8S92Thz3DRGfp cu5268XGLxLDIs7c7p7F7jSZHfIsBboAHDcYe2L6fdfD4A5Uz7vY/tLgSGNEjlsn ud2bnaYSeoST4rStZ6QD68ERV4vAQu+WyXqF/HbD2TcK3iilKBJxGca8Xn0j2dAL jQn3QJ1mM/NW5Gw/BUd632h6H0tOuGIAZZoyc27KyjMxU7X7DQQ6tKnMmV/36kVW tU5jIJ1Y+SXGXeY086jY8Fz+7cKXBUIueqElqtCjhrHfH+HS+0+e9c1yYYKVlnN9 PrOsqoXZX4VCILUM2CiH1ZAfoLZhMaUic2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvuddgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfeutdekveeggeetteekfeejffegudduudfhueevleeftdffffeggeeivddv jeelnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 21:45:47 -0400 (EDT) Content-Language: en-US In-Reply-To: <87v8fq570k.fsf@epfl.ch> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263388 Archived-At: Hi Basil, On 14/06/2023 19:43, Basil Contovounesios wrote: > - Dmitry to review the change in vc-git > - Paul for any comments on the time handling in vc-git-annotate-time > > In vc-git-annotate-time, the mistyped group added in [1] throws off the > match string indices that are later passed to encode-time: by my reading > the hour argument by chance continues to be specified correctly, but the > minutes argument receives the number of hours, the seconds argument the > number of minutes, and the timezone argument the number of seconds. > > [1]: Display shorter dates in Git annotate output > 576fba5f58d 2015-05-17 02:47:17 +0300 > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=576fba5f58d > > Even after correcting the shy group, the timezone parsing doesn't seem > right to me: encode-time expects a UTC offset in seconds, but is passed > e.g. (string-to-number "+0100")=100s instead of the expected 1hr=3600s. Thank you for the effort, but I think most of this nuance could be simplified away. When you say "encode-time ... is passed ... +0100", what is your testing scenario? IIUC, the change in commit 576fba5f58d removed the complex dates from the output (which we parse), replacing them with the simple yyyy-mm-dd format (that's what --date=short does). Seems like I tried (8 years ago) to retain the compatibility with the previous output in case we'll make the format configurable someday, but that still hasn't happened. So we could do away with the 'if' condition and simplify the regexp accordingly.