From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Sat, 8 Oct 2022 17:02:38 +0300 Message-ID: <8d0c3d16-221b-4f3e-2816-d40e10477d35@yandex.ru> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <8fa87ad2-6d5c-2f9d-ed37-0b956fbadd2c@yandex.ru> <87sfk0jc0x.fsf@posteo.net> <8735byh5wg.fsf@posteo.net> <87k05afn3j.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14528"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: Robert Pluim , 57400@debbugs.gnu.org, Antoine Kalmbach To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 08 16:07:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohATr-0003cm-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 16:07:07 +0200 Original-Received: from localhost ([::1]:38534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohATq-0006W0-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 10:07:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohAPv-00050v-H9 for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 10:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohAPu-0007VT-7v for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 10:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohAPt-0008Lv-T9 for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 10:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Oct 2022 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166523776832087 (code B ref 57400); Sat, 08 Oct 2022 14:03:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 8 Oct 2022 14:02:48 +0000 Original-Received: from localhost ([127.0.0.1]:41101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohAPg-0008LT-FU for submit@debbugs.gnu.org; Sat, 08 Oct 2022 10:02:48 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:36387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohAPe-0008LG-AJ for 57400@debbugs.gnu.org; Sat, 08 Oct 2022 10:02:46 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id j7so10981950wrr.3 for <57400@debbugs.gnu.org>; Sat, 08 Oct 2022 07:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=N8E15DdYd9BjZ4MbJKFMC3RzQqVtPMFpqb+TJT3qd2A=; b=oi3kc+ZjXwVVm+BAejscK+ju28zXF2cQI5VUV4HtZBMOSelGZl39y0GPg5iLTZQl5l soV+2vS7njbFS49oVZy9iOTi7v1mTsojsHaSSS90SVWwPAojntE4qSDHkQz5NlxQ/ns7 9HkkpiHUm3TzNpQAZdh/wdPj1LNrrT+8dZuebcfVD3HafjeJ9aVFYfUHX1zxmIZFJ3LC GEhiKYUvh0ULg7D8JQylyuEjTp3wQ/ttPy0BhFypFx1y7ZvmAy2EEvlh8wE9HR/wvlYr QLij5rFDMJIX1bAFA+ZK9eo9RG/lksPdOiQbZJ5b11fVhqrI0+5qq/glqD0JSQBo5Ki/ T6sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N8E15DdYd9BjZ4MbJKFMC3RzQqVtPMFpqb+TJT3qd2A=; b=ndEqFWSYM95nTzqrxRzRPA6MPWjfwGpja75SweHDyRDyD7G5xBwj5EQrnncMccS6C+ bf12HW1NWjHI1HxU3ms0PE/yuy/GB24VnNpkOXetZV6eTjDa0uyka+5YmnuK5QBDWJsN uzudLLYcVEXJv/jCkGz3g35KFYKxppTnPj5kYVuanjM6Zqw9snTvQKcKvYqEf4qzOiL/ Imoehm5GMffOd6Xeqca9fo7YYZQ4BGMVcGlqIS/o37pcZ50rLzi/HYnao/Cx384OI6Vs HI12LF2oMKOUGcRiaritCahLqmkao5k8cwE106SZQXrqARDlhpDEKizEDpDeZnp1WoSm u4QA== X-Gm-Message-State: ACrzQf1HVxNDbGrcoeWw6b0JJHlhqmIijF+JJd+qCDKp7zTvWMfwV1ha wQdisKu6DB92S636Dlxnt3A= X-Google-Smtp-Source: AMsMyM6oJnnCHlnZK3Bvadsxs6DfTzUI6RtEPwgR/fXVLx+IaKeUy94M8hIPjuOUxluMStViMyAudA== X-Received: by 2002:adf:edd1:0:b0:22e:5257:a19e with SMTP id v17-20020adfedd1000000b0022e5257a19emr6035634wro.180.1665237760218; Sat, 08 Oct 2022 07:02:40 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id iv19-20020a05600c549300b003b47b913901sm27673640wmb.1.2022.10.08.07.02.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Oct 2022 07:02:39 -0700 (PDT) Content-Language: en-US In-Reply-To: <87k05afn3j.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244914 Archived-At: On 08.10.2022 16:42, Philip Kaludercic wrote: >> Perhaps it will >> be a good idea to define the 'root' action there (which will >> recursively check the parent directory and see whether it still >> contains the "CVS" dir). As long as CVS knows how to recursively diff >> the directory tree, I suppose. And show history for it whole. > I checked out the Emacs www repository and tried it out. This was the > error I got: > > Debugger entered--Lisp error: (vc-not-supported root CVS) > signal(vc-not-supported (root CVS)) > vc-call-backend(CVS root "~/Source/emacs-www/") > vc-print-root-log(2000) > funcall-interactively(vc-print-root-log 2000) > call-interactively(vc-print-root-log nil nil) > command-execute(vc-print-root-log) Right, I did too. So I described above how 'vc-cvs-root' could be implemented. Aside from minor concerns about performance with Tramp, my question is whether vc-root-diff and/or vc-print-root-log will be able to work without individual files specified (when FILES is (list root)). vc-cvs-diff starts with looking for individual file backups, but maybe the "slow" fallback path will handle the directory just fine.