From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Sat, 15 Jul 2023 10:20:17 -0300 Message-ID: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> References: <87v8frihny.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16798"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: 64046@debbugs.gnu.org, Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 15:21:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKfDE-00049p-VC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 15:21:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKfCq-0005Vq-RC; Sat, 15 Jul 2023 09:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKfCo-0005Tp-Sh for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 09:21:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKfCo-0004LT-KJ for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKfCo-0005Ke-3f for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 09:21:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v8frihny.fsf@gmx.net> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168942723320452 (code B ref 64046); Sat, 15 Jul 2023 13:21:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 15 Jul 2023 13:20:33 +0000 Original-Received: from localhost ([127.0.0.1]:44363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKfCK-0005Jo-PC for submit@debbugs.gnu.org; Sat, 15 Jul 2023 09:20:33 -0400 Original-Received: from mail-oo1-xc29.google.com ([2607:f8b0:4864:20::c29]:56422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKfCF-0005JU-LI for 64046@debbugs.gnu.org; Sat, 15 Jul 2023 09:20:31 -0400 Original-Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-563439ea4a2so1960192eaf.0 for <64046@debbugs.gnu.org>; Sat, 15 Jul 2023 06:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689427221; x=1692019221; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=JuqBNbrts/SH3bcXdOdqf9IAodWhfGqFkU7T5PhQQuA=; b=HuSk7jZS6oOk8NEGwY6JWZIIlrpKF8K0xtu/24h2E6W6iM79mSU//SoNG2TQmBGBMa aUUZQEG46WMkF75hBypGj4ATr9uRN3Zgj5gqfuATfOd2UyZYkNd7aBOulkHkkjWS7rOf 5yRIkKsNFWl0ilLod5nw6PPypZ9roNFucmYvIWxiBsn0s7sJT3shgL4O9uUxFs6UrVf3 /BCazKlPvPmYMc0dB+4oFOMmd28YnNPXehSm6bo5As21PUmjTfjKaOqnrLLMySfGVXtO hRcH5z/Q9HoO2Ofma047WIBzo8XixppFU97DxilXHMOiZ/TXWGGd9CDfdrPjY73uUhYj OiCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689427221; x=1692019221; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JuqBNbrts/SH3bcXdOdqf9IAodWhfGqFkU7T5PhQQuA=; b=S+yVLUIc6EEzzpyrepFp1Z0v/8xrGcNTH4ebnzDz1izRYe94Kv0TcJ/U7B6CPUaQeF 66Y6CrHrLCWCy5hfVCKCABxjBgbSe5ijd/UBw2NsHadT9vEZnJYzoYj87M46I204RdT7 NkNRLbJ+rl+IUohob4Qwkm/4vVVkgZ0BRhzo5YybfpcGF4AnFlnrh6ZC4J9BlhCmaXDo i8qq44ATfhaIvpHFWr6cNqUgmDlT71dO6boh4UB8rkt5R1cxLtFOic7R/q+gjEJlx71I ewvzuFNzON/bKGHKgWYX7zvjzEBJsvbI8305cu2t28FjIMPcdggHAPrT9rN1bSnrOWj1 elbw== X-Gm-Message-State: ABy/qLaFuDCGI0P4XeGbywhYi7avoCD8nwvrvp/f4y23gMKKy6tc1m4w aq/nMJIuKDpqeMav6mNV7zLkRpFhsXCD9g== X-Google-Smtp-Source: APBJJlExlKromFyddLyIwuYWU4tEW7ijf6YftaXMKNGnuQjFVVwxsPrwVHvo+ffyPtIWmGMYb6ROQg== X-Received: by 2002:a05:6808:2027:b0:398:9ee4:1dac with SMTP id q39-20020a056808202700b003989ee41dacmr9873915oiw.32.1689427221133; Sat, 15 Jul 2023 06:20:21 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id dz25-20020a056808439900b003a3600182f8sm4903047oib.57.2023.07.15.06.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jul 2023 06:20:20 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265201 Archived-At: Stephen Berman writes: > On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda wrote: > >> Stephen Berman writes: >> >>>> Thanks for the feedback.  You're right, that patch is too superficial; >>>> it also fails to do substitution in popup extended menus like the one >>>> produced by clicking the "State" button, with the result that in the >>>> item "Revert This Session's Customization" the apostrophe is not >>>> displayed in the "curve" style.  So I revised the patch, attached below, >>>> to iterate over the elements of each item in ITEMS, and it now appears >>>> to handle substitution with the "State" button display correctly, both >>>> as popup menu and as text menu buffer.  The latter is the result of >>>> applying widget--simplify-menu, if I debugged correctly, so I think this >>>> answers your concerns (though the text menu buffer already shows the >>>> substitution independently of my patch, due to commit bd3b426ebb).  Or >>>> have I misunderstood your concerns about widget--simplify-menu?  If so, >>>> can you give an example where the new patch fails? >>> >>> Just pinging in case this fell under the radar.  If there's no response, >>> what's the next step forward? >>> >>> Steve Berman >> >> It did, thanks for the ping. >> >> Since there's no problem with widget--simplify-menu, the patch looks >> good to me. > > Thanks.  So Eli, should this go into master, since it's not a > regression, or is it ok to install this to the release branch?  It does > seem pretty safe, since it's only applying substitute-command-keys in a > few more places in widget-choose. > > Steve Berman Turns out this code introduces regressions when customizing faces. With emacs -Q: M-x customize-face RET default Action the State button and choose: "For All Kinds of Displays" Action the Display menu and select "specific display" Wrong type argument: number-or-marker-p, "        " The substitute-command-keys operation is too destructive, and messes with things it shouldn't be modifying, like the :offset property of widgets in this case.