all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, Andrea Corallo <akrl@sdf.org>
Cc: 58956@debbugs.gnu.org, vincent@vinc17.net,
	1017711@bugs.debian.org, spwhitton@spwhitton.name
Subject: bug#58956: mark_object, mark_objects(?) crash
Date: Sat, 5 Nov 2022 13:54:54 -0700	[thread overview]
Message-ID: <8ca1be93-e47a-49d0-e49a-4ad201f0f644@cs.ucla.edu> (raw)
In-Reply-To: <83zgd75hll.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On 2022-11-04 00:00, Eli Zaretskii wrote:
> We need to establish what is the
> source of SIGHUP in these cases.  "These cases" mean, AFAIU, the
> situations where Emacs launched an async subprocess to do native
> compilation (which is another Emacs process in a --batch session), and
> the parent Emacs session is terminated by the user before the async
> compilation runs to completion.  Would the child Emacs process get
> SIGHUP in this scenario?

Hard for me to say. It's a messy area, with kernels (and Emacs itself) 
sending SIGHUP on various whims.

Does the attached patch fix things? It builds on your commit 
190a6853708ab22072437f6ebd93beb3ec1a9ce6 dated 2020-12-04; I don't know 
why that earlier patch was installed, but it would seem to apply to 
SIGHUP and SIGTERM as well as it applies to SIGINT.

[-- Attachment #2: sighup.diff --]
[-- Type: text/x-patch, Size: 629 bytes --]

diff --git a/src/emacs.c b/src/emacs.c
index 1b2aa9442b..92e2299a04 100644
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -432,9 +432,9 @@ terminate_due_to_signal (int sig, int backtrace_limit)
           if (sig == SIGTERM || sig == SIGHUP || sig == SIGINT)
 	    {
 	      /* Avoid abort in shut_down_emacs if we were interrupted
-		 by SIGINT in noninteractive usage, as in that case we
+		 in noninteractive usage, as in that case we
 		 don't care about the message stack.  */
-	      if (sig == SIGINT && noninteractive)
+	      if (noninteractive)
 		clear_message_stack ();
 	      Fkill_emacs (make_fixnum (sig), Qnil);
 	    }

  parent reply	other threads:[~2022-11-05 20:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  1:33 bug#58956: mark_object, mark_objects(?) crash Sean Whitton
2022-11-02 12:24 ` Eli Zaretskii
2022-11-03  3:00   ` Vincent Lefevre
2022-11-03  6:47     ` Eli Zaretskii
2022-11-03 10:13       ` Vincent Lefevre
2022-11-03 10:27         ` Eli Zaretskii
2022-11-03 21:25           ` Andrea Corallo
2022-11-04  7:00             ` Eli Zaretskii
     [not found]             ` <83zgd75hll.fsf@gnu.org>
2022-11-04 21:03               ` Andrea Corallo
2022-11-05 20:54               ` Paul Eggert [this message]
2022-11-06  5:51                 ` Eli Zaretskii
2022-11-06 19:18                   ` Paul Eggert
2022-11-06 19:32                     ` Eli Zaretskii
2022-11-06 19:44                       ` Paul Eggert
2022-11-06 19:58                         ` Eli Zaretskii
2022-11-08 19:44                 ` Sean Whitton
2022-11-10 10:14                 ` Eli Zaretskii
     [not found]                 ` <87cz9x1bav.fsf@melete.silentflame.com>
2022-11-10 10:23                   ` Vincent Lefevre
2022-11-11 18:32                     ` Sean Whitton
     [not found]                     ` <87cz9twddq.fsf@melete.silentflame.com>
2022-11-12  1:55                       ` Vincent Lefevre
2022-11-13 20:51                         ` Sean Whitton
     [not found] <20220819101031.GA1491685@zira.vinc17.org>
     [not found] ` <20220822005548.GA282574@zira.vinc17.org>
     [not found]   ` <87sfjr2cuf.fsf@melete.silentflame.com>
     [not found]     ` <20221014105322.GE12227@zira.vinc17.org>
     [not found]       ` <87ilk18mkw.fsf@melete.silentflame.com>
     [not found]         ` <20221031145917.GD8422@zira.vinc17.org>
     [not found]           ` <20221101221733.GB9018@zira.vinc17.org>
2022-11-02 21:43             ` bug#58956: Bug#1017711: emacs-gtk: terminated with signal SIGABRT, 137 MB coredump Sean Whitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ca1be93-e47a-49d0-e49a-4ad201f0f644@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=1017711@bugs.debian.org \
    --cc=58956@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    --cc=spwhitton@spwhitton.name \
    --cc=vincent@vinc17.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.