From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Thu, 16 May 2019 01:05:11 +0300 Message-ID: <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="242032"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35624@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 00:14:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hR29v-0010pc-LW for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 00:13:59 +0200 Original-Received: from localhost ([127.0.0.1]:43400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hR29u-0007lt-IG for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 18:13:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hR29h-0007j7-9d for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:13:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hR22E-00008L-JO for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hR22E-00007Y-Fi for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hR22E-0003HX-69 for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2019 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.155795793212571 (code B ref 35624); Wed, 15 May 2019 22:06:02 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 15 May 2019 22:05:32 +0000 Original-Received: from localhost ([127.0.0.1]:53552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR21k-0003Gh-09 for submit@debbugs.gnu.org; Wed, 15 May 2019 18:05:32 -0400 Original-Received: from mail-lf1-f52.google.com ([209.85.167.52]:37426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR21h-0003GR-Ts for 35624@debbugs.gnu.org; Wed, 15 May 2019 18:05:30 -0400 Original-Received: by mail-lf1-f52.google.com with SMTP id q17so1011891lfo.4 for <35624@debbugs.gnu.org>; Wed, 15 May 2019 15:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nAb3isyxO1zmZKaSl5Y2SXlwHzKVyr5zsuRKLgFCyfw=; b=D6U904TJp0d5dLNnmnEb+TvJviGN+1A8l+CWKmr7QjaeBzdf1NquVaJtGGUiRLr+Kf BreUP+qNvuKFCo20mZV2hR0Uimd8jSmHnO7InHq5oPojS7ODM8vDVifgIcEBAkHp241m aEws1LyNE6uGUwUjUrUsEMae136lcZ15+LAK1EzcGBO7sIFEARXMtuBVQ74DTe2xluSG jWd2XEuLOrvX+PrfY2C6fSHO74zhCVplR41UNA2A91JUX48HyfVYHMvVmGYDDNkz7aFM ZyQ9PwD7/W/ykBmkTEY+irGu2Y16eRz5cqqS/QvYn5oiLE6yjUaF1O29DXWEZ+L6N1Bu t7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nAb3isyxO1zmZKaSl5Y2SXlwHzKVyr5zsuRKLgFCyfw=; b=eMJA50akKKMjp2abWEjcQmtEidf8620BJDPPx1woWt4Iq0vFHRauj8Ob8H5q3zK2AL PDQ6nf8cmkS9UuXVpAwlQl5DrpeBIt6DKTq1MmcwHtemtPq7vTPu8sRKxEyBj6y7+9Ju PLc4bcZnnC+FNlvQQgcAhhh/TQXutwDfROjq2c3ach8gEZNwat+bkmKhWM/a4dx5WWob dvNuF333Tqars88+gLqXi0kYKGny7TxCF6E/UZheUDFFzsBBR1a4rF5wE2NofdH5UJnL KllUL6UyULxXycJgip7vQi6AVLcvHavNvx6EWjIGJiAZEsTCgTESdogmQ+8U9XU6DDJ5 C0pQ== X-Gm-Message-State: APjAAAVJWOF+K7+p9gA6bVnG3zjfV2Fc1aaAWohFaTKmQLCBR3zEUzQr vSuc2LuSVGq8Ys85ukcvwZNbnq6K X-Google-Smtp-Source: APXvYqx5HwKruu+zoRwCw3htrNpjksC15SJQshSDpTLsx4ZXTdjupnPnepjwVA0ZJa0b8eje57FG/Q== X-Received: by 2002:ac2:510b:: with SMTP id q11mr19891555lfb.11.1557957919384; Wed, 15 May 2019 15:05:19 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id w20sm556056ljd.39.2019.05.15.15.05.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 15:05:13 -0700 (PDT) In-Reply-To: <87lfz7o05l.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159363 Archived-At: On 16.05.2019 0:12, Juri Linkov wrote: >> You can also type 'C-u C-x v =', then '1.4', RET and C-j to omit the end >> version. That would also show the diff against the workfile. > > 10 keys more to type. You would normally paste the revision. And 'C-x v =' is already in my muscle memory. > When this feature was enabled, I used it every day. Was it back in the days of CVS? > Currently I'm forced > to type 10 more keys every time. I agree the log not to look weirder, > so better to not display Working. Could you explain what are you using it for? I understand a diff between revisions, and I understand a diff of the working tree against the index, but this kind of a diff seems pretty unusual. > Or course, you didn't think about it, because you didn't know it exists. > I didn't know too until discovered it accidentally. After that it hard > to lose this ability. The problem is that this useful feature is > undocumented. Here is the patch that documents it: I have tried to imagine using it, but it's still hard. Maybe doing it once a few days to compare the current progress against the master branch. Though C-u C-x v d master RET C-j might be faster that looking for the revision that corresponds to the master branch in the log. > +To compare two arbitrary revisions, activate the region: set the > +beginning of the region to the line with the first revision and the > +end of the region to the line with the second revision to compare, > +then type @kbd{d} or @kbd{=}. When the beginning of the region is on > +the top line that has no revision, it uses the current work file as > +the first revision to compare. When the end of the region is on the > +bottom non-revision line after the last revision line, then it uses > +the next earlier revision after the last displayed revision as the > +second revision to compare. The description is okay, but feature-wise, I'm not convinced. Would somebody else like to express an opinion here? > @vindex vc-log-show-limit > Because fetching many log entries can be slow, the > @file{*vc-change-log*} buffer displays no more than 2000 revisions by > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index 61c13026cc..b6feb3b8d1 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1017,8 +1017,8 @@ vc-git-print-log > ;; If the buffer exists from a previous invocation it might be > ;; read-only. > (let ((inhibit-read-only t)) > - (with-current-buffer > - buffer > + (with-current-buffer buffer > + (insert "\n") Any other ideas how to reach the same functionality without making the log buffer weirder? Maybe add a prefix argument handling to log-view-diff?