From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 35624@debbugs.gnu.org
Subject: bug#35624: log-view-diff regression
Date: Thu, 16 May 2019 01:05:11 +0300 [thread overview]
Message-ID: <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> (raw)
In-Reply-To: <87lfz7o05l.fsf@mail.linkov.net>
On 16.05.2019 0:12, Juri Linkov wrote:
>> You can also type 'C-u C-x v =', then '1.4', RET and C-j to omit the end
>> version. That would also show the diff against the workfile.
>
> 10 keys more to type.
You would normally paste the revision. And 'C-x v =' is already in my
muscle memory.
> When this feature was enabled, I used it every day.
Was it back in the days of CVS?
> Currently I'm forced
> to type 10 more keys every time. I agree the log not to look weirder,
> so better to not display Working.
Could you explain what are you using it for? I understand a diff between
revisions, and I understand a diff of the working tree against the
index, but this kind of a diff seems pretty unusual.
> Or course, you didn't think about it, because you didn't know it exists.
> I didn't know too until discovered it accidentally. After that it hard
> to lose this ability. The problem is that this useful feature is
> undocumented. Here is the patch that documents it:
I have tried to imagine using it, but it's still hard. Maybe doing it
once a few days to compare the current progress against the master
branch. Though C-u C-x v d master RET C-j might be faster that looking
for the revision that corresponds to the master branch in the log.
> +To compare two arbitrary revisions, activate the region: set the
> +beginning of the region to the line with the first revision and the
> +end of the region to the line with the second revision to compare,
> +then type @kbd{d} or @kbd{=}. When the beginning of the region is on
> +the top line that has no revision, it uses the current work file as
> +the first revision to compare. When the end of the region is on the
> +bottom non-revision line after the last revision line, then it uses
> +the next earlier revision after the last displayed revision as the
> +second revision to compare.
The description is okay, but feature-wise, I'm not convinced.
Would somebody else like to express an opinion here?
> @vindex vc-log-show-limit
> Because fetching many log entries can be slow, the
> @file{*vc-change-log*} buffer displays no more than 2000 revisions by
> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
> index 61c13026cc..b6feb3b8d1 100644
> --- a/lisp/vc/vc-git.el
> +++ b/lisp/vc/vc-git.el
> @@ -1017,8 +1017,8 @@ vc-git-print-log
> ;; If the buffer exists from a previous invocation it might be
> ;; read-only.
> (let ((inhibit-read-only t))
> - (with-current-buffer
> - buffer
> + (with-current-buffer buffer
> + (insert "\n")
Any other ideas how to reach the same functionality without making the
log buffer weirder?
Maybe add a prefix argument handling to log-view-diff?
next prev parent reply other threads:[~2019-05-15 22:05 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 21:56 bug#35624: log-view-diff regression Juri Linkov
2019-05-07 22:54 ` Dmitry Gutov
2019-05-08 19:52 ` Juri Linkov
2019-05-09 13:26 ` Dmitry Gutov
2019-05-09 19:41 ` Juri Linkov
2019-05-10 0:14 ` Dmitry Gutov
2019-05-10 7:56 ` Eli Zaretskii
2019-05-11 20:58 ` Juri Linkov
2019-05-13 0:32 ` Dmitry Gutov
2019-05-13 20:40 ` Juri Linkov
2019-05-13 21:21 ` Dmitry Gutov
2019-05-14 20:29 ` Juri Linkov
2019-05-15 0:34 ` Dmitry Gutov
2019-05-15 21:12 ` Juri Linkov
2019-05-15 22:05 ` Dmitry Gutov [this message]
2019-05-16 20:04 ` Juri Linkov
2019-05-19 20:11 ` Juri Linkov
2019-05-20 23:29 ` Dmitry Gutov
2019-05-21 20:12 ` Juri Linkov
2019-05-21 20:39 ` Dmitry Gutov
2019-05-21 21:32 ` Juri Linkov
2019-05-21 21:52 ` Dmitry Gutov
2019-05-22 21:52 ` Dmitry Gutov
2019-05-23 21:07 ` Juri Linkov
2019-05-24 1:29 ` Dmitry Gutov
2019-05-24 18:41 ` Juri Linkov
2019-05-27 15:26 ` Dmitry Gutov
2019-05-27 19:47 ` Juri Linkov
2019-06-10 0:57 ` Dmitry Gutov
2019-06-10 20:50 ` Juri Linkov
2019-06-10 22:19 ` Dmitry Gutov
2019-06-16 0:55 ` Dmitry Gutov
2019-06-16 20:13 ` Juri Linkov
2019-06-17 13:48 ` Dmitry Gutov
2019-06-17 20:42 ` Juri Linkov
2019-06-17 22:23 ` Dmitry Gutov
2019-05-20 23:39 ` Dmitry Gutov
2019-05-10 7:54 ` Eli Zaretskii
2019-05-08 6:01 ` Eli Zaretskii
2019-05-08 19:52 ` Juri Linkov
2019-05-10 7:51 ` Eli Zaretskii
2019-05-11 20:53 ` Juri Linkov
2019-05-12 2:36 ` Eli Zaretskii
2019-05-12 19:15 ` Juri Linkov
2019-05-13 14:24 ` Eli Zaretskii
2019-05-13 14:44 ` Dmitry Gutov
2019-05-13 15:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c724814-923f-351a-686c-9f9c11468187@yandex.ru \
--to=dgutov@yandex.ru \
--cc=35624@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.