From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Bozhidar Batsov" Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/cider cf3c76a3c2: Eldev: enable slightly longer docstring first sentences Date: Thu, 21 Sep 2023 17:00:32 +0300 Message-ID: <8c429363-068c-4e49-8924-fa36ef56b174@app.fastmail.com> References: <169528315105.17748.13129277492018184806@vcs2.savannah.gnu.org> <20230921075911.57056C05819@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=ff92f127a97f48c18de6c7acdbca41ff Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9854"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.9.0-alpha0-761-gece9e40c48-fm-20230913.001-gece9e40c Cc: "Emacs Devel" To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 21 16:01:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjKF6-0002LQ-3q for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Sep 2023 16:01:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjKEo-0000uf-Va; Thu, 21 Sep 2023 10:01:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjKEl-0000tj-Ma for emacs-devel@gnu.org; Thu, 21 Sep 2023 10:01:01 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjKEj-0007LX-FZ for emacs-devel@gnu.org; Thu, 21 Sep 2023 10:00:59 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A40295C007B; Thu, 21 Sep 2023 10:00:53 -0400 (EDT) Original-Received: from imap43 ([10.202.2.93]) by compute1.internal (MEProxy); Thu, 21 Sep 2023 10:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=batsov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1695304853; x=1695391253; bh=rD wYby6BWB7aZKYikCEpkB6FTrtM1NKg+P5nGzNgvEY=; b=GcQDlYsgp1PPpd1vQi 3eXrR7QpMhDiYU8W/oOh9j/vwTrOGJv3c9JN7yRURrcPV221iBAT6X6HT/ggaMAL pyXEIfeizenwYCpgjtZGH3LqsM+qnS4r0mUMmycc5JmU8r7NwIM7OZ0hC7KVajO+ ZWX1XowHdiUvNYfFgH0giEXmopJt4AxXiY1JNQ/XNArR62b02V/KQralGGLFPcKB ifCRV4qqci7rT41jK8/5/aujCyKm7R4eX2L2x0HCCbHGaQGvCcSxwaSVPTSRdZDs Gh4gvRWU3PUbTX5x+A60dpUX+v8xvJcLwSTWwv1xE32E1RYM/m9qcL1TTU1e62Ch NUQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695304853; x=1695391253; bh=rDwYby6BWB7aZ KYikCEpkB6FTrtM1NKg+P5nGzNgvEY=; b=jX9QMZ4jNcDTtZ2nX3gf6Q6dRLoCI kKucKS3+93jBILxGp7siQOKv4SE3EhErUt6SoxQTPEO1BTwhNbc0y5G3go7r7Nv2 98wlCW0Y58X7PKFhtpczC41FxxdlNtx8yNWgY0NmQDVWbGlqNTjBhUinCi+CNmYp R26brP2K2+po+SZgM/CRNSG7cIrZQIIXgmBgV0C0AzxBgVAdikLV4EswMwp9dxcB Tz192iNcy9CLGA8rU0mmSu6uLHdeA+kGR6Lv/ApPjCRw+1ZdvDSZnaWGy7iWcLnx jRusn2tL+1wZoXdeHRPNAkSUBMxdDtUBgUX99N7hdnoRjYCa5gwLK17RQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekiedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsegrtderreerredtnecuhfhrohhmpedfueho iihhihgurghruceurghtshhovhdfuceosghoiihhihgurghrsegsrghtshhovhdruggvvh eqnecuggftrfgrthhtvghrnhepfedtkefgvdfgheeuffehjeduheekgfffffehkedttedv jefgleehieeihfffffegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepsghoiihhihgurghrsegsrghtshhovhdruggvvh X-ME-Proxy: Feedback-ID: i025946a9:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 550A02D4008F; Thu, 21 Sep 2023 10:00:53 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: Received-SPF: pass client-ip=66.111.4.25; envelope-from=bozhidar@batsov.dev; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310916 Archived-At: --ff92f127a97f48c18de6c7acdbca41ff Content-Type: text/plain Yeah, totally. I'm guessing he didn't notice the project already had one. And I didn't pay enough attention to the diff. :D On Thu, Sep 21, 2023, at 4:15 PM, Stefan Monnier wrote: > [ Sorry, "vemv" is not in the Cc because it used a bogus email > address. ] > > > --- a/Eldev > > +++ b/Eldev > > @@ -33,6 +33,9 @@ > > (signal 'eldev-wrong-option-usage `("unknown test type `%s'" ,type))) > > (setf cider-test-type (intern type))) > > > > +(setq byte-compile-docstring-max-column 100) ;; slightly increase the maximum (applies to checkdoc and the byte compiler alike) > > +(setq checkdoc-permit-comma-termination-flag t) ;; allow commas to indicate that the first sentence continues, which enables longer first sentences > > + > > (add-hook 'eldev-test-hook > > (lambda () > > (eldev-verbose "Using cider tests of type `%s'" cider-test-type))) > > Wouldn't it make more sense to set those via `.dir-locals.el`? > > > Stefan > > --ff92f127a97f48c18de6c7acdbca41ff Content-Type: text/html Content-Transfer-Encoding: quoted-printable
Yeah, totally. = I'm guessing he didn't notice the project already had one. And I didn't = pay enough attention to the diff. :D 

On Thu, Sep 21, 2023, at 4:15 PM, Stefan Monnier wrote:
[ Sorry, "vemv" is not in = the Cc because it used a bogus email
  address. = ]

> --- a/Eldev
> +++ = b/Eldev
> @@ -33,6 +33,9 @@
> &nb= sp;    (signal 'eldev-wrong-option-usage `("unknown test = type `%s'" ,type)))
>    (setf cider-tes= t-type (intern type)))
>  
>= +(setq byte-compile-docstring-max-column 100) ;; slightly increase the = maximum (applies to checkdoc and the byte compiler alike)
= > +(setq checkdoc-permit-comma-termination-flag t) ;; allow commas to= indicate that the first sentence continues, which enables longer first = sentences
> +
>  (add-hook 'eldev= -test-hook
>       &= nbsp;    (lambda ()
>   &= nbsp;          (eldev-verbo= se "Using cider tests of type `%s'" cider-test-type)))
Wouldn't it make more sense to set those via `.dir-locals.el= `?


    &= nbsp;   Stefan



--ff92f127a97f48c18de6c7acdbca41ff--