Re: [nongnu] elpa/cider cf3c76a3c2: Eldev: enable slightly longer docstring first sentences

Re: [nongnu] elpa/cider cf3c76a3c2: Eldev: enable slightly longer docstring first sentences

[Stefan Monnier]

[ Sorry, "vemv" is not in the Cc because it used a bogus email
  address.  ]

> --- a/Eldev
> +++ b/Eldev
> @@ -33,6 +33,9 @@
>      (signal 'eldev-wrong-option-usage `("unknown test type `%s'" ,type)))
>    (setf cider-test-type (intern type)))
>  
> +(setq byte-compile-docstring-max-column 100) ;; slightly increase the maximum (applies to checkdoc and the byte compiler alike)
> +(setq checkdoc-permit-comma-termination-flag t) ;; allow commas to indicate that the first sentence continues, which enables longer first sentences
> +
>  (add-hook 'eldev-test-hook
>            (lambda ()
>              (eldev-verbose "Using cider tests of type `%s'" cider-test-type)))

Wouldn't it make more sense to set those via `.dir-locals.el`?


        Stefan

Re: [nongnu] elpa/cider cf3c76a3c2: Eldev: enable slightly longer docstring first sentences

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Yeah, totally. I'm guessing he didn't notice the project already had one. And I didn't pay enough attention to the diff. :D  

On Thu, Sep 21, 2023, at 4:15 PM, Stefan Monnier wrote:
> [ Sorry, "vemv" is not in the Cc because it used a bogus email
>   address.  ]
> 
> > --- a/Eldev
> > +++ b/Eldev
> > @@ -33,6 +33,9 @@
> >      (signal 'eldev-wrong-option-usage `("unknown test type `%s'" ,type)))
> >    (setf cider-test-type (intern type)))
> >  
> > +(setq byte-compile-docstring-max-column 100) ;; slightly increase the maximum (applies to checkdoc and the byte compiler alike)
> > +(setq checkdoc-permit-comma-termination-flag t) ;; allow commas to indicate that the first sentence continues, which enables longer first sentences
> > +
> >  (add-hook 'eldev-test-hook
> >            (lambda ()
> >              (eldev-verbose "Using cider tests of type `%s'" cider-test-type)))
> 
> Wouldn't it make more sense to set those via `.dir-locals.el`?
> 
> 
>         Stefan
> 
> 

[-- Attachment #2: Type: text/html, Size: 1754 bytes --]