Re: [elpa] master 9a3a508: Package transcribe added

Re: [elpa] master 9a3a508: Package transcribe added

[Stefan Monnier]

Thanks

> +;;;transcribe.el --- package for audio transcriptions
     ^^
The convention for ";;;" is to have a space between ";;;" and the rest.
If the package is only meant to be supported for Emacs>=24, I recommend
you add "-*- lexical-binding:t -*-".

> +;;Copyright 2014 David González Gándara

Oh and for ";;" as well.

> +(require 'emms-setup)

So your package only works with emms, in which case the pseudo-headers
should include

   ;; Package-Requires: ((emms "<version>")) 

or something like that.

> +;(require 'emms-player-mpd)
> +;(setq emms-player-mpd-server-name "localhost")
> +;(setq emms-player-mpd-server-port "6600")
> +
> +(emms-standard)
> +(emms-default-players)
> +(require 'emms-player-mpg321-remote)
> +(push 'emms-player-mpg321-remote emms-player-list)
> +
> +(require 'emms-mode-line)
> +(emms-mode-line 1)
> +(require 'emms-playing-time)
> +(emms-playing-time 1)
> +
> +(global-set-key (kbd "C-x C-p") 'emms-play-file)
> +
> +(global-set-key (kbd "<f5>") 'emms-pause)
> +
> +(global-set-key (kbd "C-x <down>") 'emms-stop)
> +
> +(global-set-key (kbd "C-x <right>") 'emms-seek-forward)
> +
> +(global-set-key (kbd "C-x <left>") 'emms-seek-backward)
> +
> +(global-set-key (kbd "<f8>") 'emms-seek)

I think those settings should be moved to a function: loading
transcribe.el should not make such global changes.  Instead they should
be made via a function.  Activating a mode/feature should never be made
with "require" or "load" but by calling a function (or setting a custom
var) which internally will load the file, if needed.

> +(defun analyze-episode (episode person)
> +  (interactive "sepisode: \nsperson:")

All definitions should use a package prefix, e.g. "transcribe-", so as
to avoid conflicts with other packages.

> +  (shell-command (concat (expand-file-name  "analyze_episodes2.py") " -e " episode " -p " person " -i " buffer-file-name )))

If your file is called "hello; rm -rf ~/." the above command will not do
what you wanted.  You can fix that by quoting the various parts with
shell-quote-argument, but I recommend you just use `call-process'
instead of `shell-command', since you don't make use of any
functionality of the shell, so the use of shell here only introduces
overheads and bugs.


        Stefan

Re: [elpa] master 9a3a508: Package transcribe added

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

> > +
> > +(global-set-key (kbd "C-x C-p") 'emms-play-file)
> > +
> > +(global-set-key (kbd "<f5>") 'emms-pause)
> > +
> > +(global-set-key (kbd "C-x <down>") 'emms-stop)
> > +
> > +(global-set-key (kbd "C-x <right>") 'emms-seek-forward)
> > +
> > +(global-set-key (kbd "C-x <left>") 'emms-seek-backward)
> > +
> > +(global-set-key (kbd "<f8>") 'emms-seek)
>
> I think those settings should be moved to a function:

Ideally to a minor-mode.

[-- Attachment #2: Type: text/html, Size: 712 bytes --]

Re: [elpa] master 9a3a508: Package transcribe added

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On 29 Nov 2015 12:38 pm, "David Gonzalez Gandara" <dggandara-IGUgQLVVQiRCV4ILt04nZQ@public.gmane.org>
wrote:
>     Package transcribe added

Thanks for the package, David.

Besides the comments already made by Stefan, I just wanted to point out
that we now announce on emacs-devel before adding new packages to Elpa.
There's more information on the readme.
It's just a way of keeping everybody informed about new additions.

[-- Attachment #2: Type: text/html, Size: 588 bytes --]

announcing GNU ELPA updates [was: [elpa] master 9a3a508: Package transcribe added]

[Drew Adams]

> we now announce on emacs-devel before adding new packages to Elpa.
> There's more information on the readme. 
> It's just a way of keeping everybody informed about new additions.

1. Why do we do this?  It already gets "announced" on gnu-emacs-sources@gnu.org.

Also, I guess that the many messages I get on that list, and
which are so succinct, are automated (?).  For example:

 Version 20151123 of GNU ELPA package org has just been released.
 You can now find it in M-x package-list RET.

 More at http://elpa.gnu.org/packages/org.html

It would be more helpful if a one-line description of what
the package is/does were included.  And that would probably
also suffice as the initial "announcement" of a package, no?


2. A year ago, such automated announcements were being sent
to info-gnu-emacs@gnu.org.  Why the change?  Now they drown
out the source-code announcement messages submitted manually
by actual users.  IOW, gnu-emacs-sources@gnu.org has more or
less been hijacked.

I agree that GNU ELPA should announce its updates, but
somewhere else might be better, no?  What was wrong with
info-gnu-emacs@gnu.org?  I suppose that it was thought that
the ELPA update msgs were drowning out other, more important
messages about GNU Emacs.  That's understandable.

Maybe GNU ELPA updates need their own list, so they don't
drown out anything?

Re: announcing GNU ELPA updates [was: [elpa] master 9a3a508: Package transcribe added]

[Rolf Ade]

> [About gnu-emacs-sources@gnu.org]
>
> Also, I guess that the many messages I get on that list, and
> which are so succinct, are automated (?).  For example:
>
>  Version 20151123 of GNU ELPA package org has just been released.
>  You can now find it in M-x package-list RET.
>
>  More at http://elpa.gnu.org/packages/org.html
>
> It would be more helpful if a one-line description of what
> the package is/does were included. [...]

As a reader of that list I'd second the plea for including a description
of what the package does. It doesn't have to be the full README (or
similar) - although that would be fine with me - but something, that
allows the reader to decide, if it's worth to him to look further at
other places (or to just install it, to play with it).

Re: [elpa] master 9a3a508: Package transcribe added

[Artur Malabarba]

Artur Malabarba <bruce.connor.am-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> On 29 Nov 2015 12:38 pm, "David Gonzalez Gandara" <
> dggandara-IGUgQLVVQiRCV4ILt04nZQ@public.gmane.org> wrote:
>>     Package transcribe added
>
> I just wanted to point
> out that we now announce on emacs-devel before adding new packages to
> Elpa.

Oh wait. I see you did announce it. I kinda missed it because you wrote
Packed instead of Package. :-)

Re: [elpa] master 9a3a508: Package transcribe added

[David González Gándara]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

Thanks for your patience and your suggestions with newbies. I tried to
apply all your advice. I am still fighting with git, I hope I don't break
anything.

On 30 November 2015 at 11:19, Artur Malabarba <bruce.connor.am@gmail.com>
wrote:

> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
> > On 29 Nov 2015 12:38 pm, "David Gonzalez Gandara" <
> > dggandara@member.fsf.org> wrote:
> >>     Package transcribe added
> >
> > I just wanted to point
> > out that we now announce on emacs-devel before adding new packages to
> > Elpa.
>
> Oh wait. I see you did announce it. I kinda missed it because you wrote
> Packed instead of Package. :-)
>

[-- Attachment #2: Type: text/html, Size: 1176 bytes --]