bug#56095: Patch

bug#56095: Patch

[Gerd Möllmann]

[-- Attachment #1.1: Type: text/plain, Size: 185 bytes --]

I'm now using the patch attached.

Why the window pointer  is needed in EmacsScroller at all escapes me, ATM. Someone who knows nsterm.c should probably check if it is needed.



[-- Attachment #1.2: Type: text/html, Size: 404 bytes --]

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 861 bytes --]

diff --git a/src/nsterm.m b/src/nsterm.m
index 891d52ea3f..514b790b15 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -9869,14 +9869,6 @@ - (void)setFrame: (NSRect)newRect
 - (void)dealloc
 {
   NSTRACE ("[EmacsScroller dealloc]");
-  if (window)
-    {
-      if (horizontal)
-        wset_horizontal_scroll_bar (window, Qnil);
-      else
-        wset_vertical_scroll_bar (window, Qnil);
-    }
-  window = 0;
   [super dealloc];
 }
 
@@ -9909,13 +9901,6 @@ -(bool)judge
       view = (EmacsView *)FRAME_NS_VIEW (frame);
       if (view != nil)
         view->scrollbarsNeedingUpdate++;
-      if (window)
-        {
-          if (horizontal)
-            wset_horizontal_scroll_bar (window, Qnil);
-          else
-            wset_vertical_scroll_bar (window, Qnil);
-        }
       window = 0;
       [self removeFromSuperview];
       [self release];

bug#56095: Patch

[Eli Zaretskii]

> Date: Sun, 19 Jun 2022 19:32:01 +0200
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> 
> Why the window pointer  is needed in EmacsScroller at all escapes me, ATM. Someone who knows
> nsterm.c should probably check if it is needed.

You mean, nsterm.m, right?

Someone who knows their way around macOS will probably look into this
soon.

Thanks.

bug#56095: Patch

[Gerd Möllmann]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Yes, nsterm.m of course.  Sorry

On Sun, 19 Jun 2022, 19:42 Eli Zaretskii, <eliz@gnu.org> wrote:

> > Date: Sun, 19 Jun 2022 19:32:01 +0200
> > From: Gerd Möllmann <gerd.moellmann@gmail.com>
> >
> > Why the window pointer  is needed in EmacsScroller at all escapes me,
> ATM. Someone who knows
> > nsterm.c should probably check if it is needed.
>
> You mean, nsterm.m, right?
>
> Someone who knows their way around macOS will probably look into this
> soon.
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 866 bytes --]

bug#56095: 29.0.50; nsterm.m, use after free

[Lars Ingebrigtsen]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> I'm now using the patch attached.
>
> Why the window pointer  is needed in EmacsScroller at all escapes me, ATM.
> Someone who knows nsterm.c should probably check if it is needed.

I've added Alan to the CCs; perhaps he knows.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#56095: Patch

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> Why the window pointer is needed in EmacsScroller at all escapes me,
> ATM. Someone who knows nsterm.c should probably check if it is needed.

It's the scroll bar class, and naturally needs a reference to the window
it scrolls.  Otherwise, how will it set ie.frame_or_window in
sendScrollEventAtLoc?

bug#56095: Patch

[Gerd Möllmann]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On 20. Jun 2022, 03:02 +0200, Po Lu <luangruo@yahoo.com>, wrote:
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
> > Why the window pointer is needed in EmacsScroller at all escapes me,
> > ATM. Someone who knows nsterm.c should probably check if it is needed.
>
> It's the scroll bar class, and naturally needs a reference to the window
> it scrolls. Otherwise, how will it set ie.frame_or_window in
> sendScrollEventAtLoc?

Ah, I see.  Thanks.

[-- Attachment #2: Type: text/html, Size: 1010 bytes --]