all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacsuser@freemail.hu, 36780@debbugs.gnu.org
Subject: bug#36780: 26.1; request:  savehist should also save log-edit-comment-ring by default
Date: Fri, 23 Aug 2019 11:04:01 -0700 (PDT)	[thread overview]
Message-ID: <8b952d4c-6a04-404e-83c3-a5d2362f08c9@default> (raw)
In-Reply-To: <<83blwgb6ni.fsf@gnu.org>>

> > `savehist-additional-variables' is explicitly reserved for users to
> > add stuff to, so I don't think it'd be appropriate for log-edit.el
> > to add anything to it.

+1

> I don't see why the solution of customizing
> savehist-additional-variables by the user is not the right one.
> After all, we are not talking about minibuffer history here.

+1

> The savehist package defines itself as being for "saving the
> minibuffer history".  What you suggest makes it a much more general
> facility, and we then would need to review many other variables and
> decide whether they are candidates for saving (some of them are
> already saved by separate features).  Maybe we should do that, but
> that's a much broader issue than this particular bug report.

YAGNI.  Emacs doesn't need to pre-populate a list
of variables to save.  `savehist-additional-variables'
is the right way (for users) to save variables, IMO.





       reply	other threads:[~2019-08-23 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<Axt4dg.WUI45G8D7I2l.s1vDqjehdBkdaPEsarTp@freemail.hu>
     [not found] ` <<87blwgforq.fsf@gnus.org>
     [not found]   ` <<83blwgb6ni.fsf@gnu.org>
2019-08-23 18:04     ` Drew Adams [this message]
2019-07-24  8:59 bug#36780: 26.1; request: savehist should also save log-edit-comment-ring by default ndame
2019-08-23  5:12 ` Lars Ingebrigtsen
2019-08-23  8:57   ` Eli Zaretskii
2019-08-23 18:36     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b952d4c-6a04-404e-83c3-a5d2362f08c9@default \
    --to=drew.adams@oracle.com \
    --cc=36780@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacsuser@freemail.hu \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.