Re: emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142)

Re: emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142)

[Dmitry Gutov]

Hi Theodor,

On 06/02/2023 08:45, Theodor Thornhill via Mailing list for Emacs 
changes wrote:
> +           (equal (treesit-node-type node) c-ts-common-if-statement-regexp)
> +           (equal (treesit-node-type (treesit-node-parent node))
> +                  c-ts-common-if-statement-regexp)

If the variable is called -regexp, I suppose these should use 
string-match-p.

Re: emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142)

[Yuan Fu]

> On Feb 6, 2023, at 2:15 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
> 
> Hi Theodor,
> 
> On 06/02/2023 08:45, Theodor Thornhill via Mailing list for Emacs changes wrote:
>> +           (equal (treesit-node-type node) c-ts-common-if-statement-regexp)
>> +           (equal (treesit-node-type (treesit-node-parent node))
>> +                  c-ts-common-if-statement-regexp)
> 
> If the variable is called -regexp, I suppose these should use string-match-p.
> 

I partly am to blame. I made some changes to c-ts-common but didn’t push it, so Theo had to patch on my convoluted code. I’ve pushed my changes and updated java-ts-mode to use the new interface. This new interface is hopefully easier to use and understand.

Yuan