From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Carsten Dominik Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [Orgmode] patch to outline.el concerning isearch Date: Thu, 14 Dec 2006 18:54:45 +0100 Message-ID: <8b0f2e638ee24e1c20681a0b7b293574@science.uva.nl> References: <87bqm7yvyw.fsf@earthlink.net> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 (Apple Message framework v624) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1166184608 7378 80.91.229.10 (15 Dec 2006 12:10:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2006 12:10:08 +0000 (UTC) Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 15 13:10:05 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GvBt6-0007rW-Jx for ged-emacs-devel@m.gmane.org; Fri, 15 Dec 2006 13:10:04 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GvBt5-0002bb-W9 for ged-emacs-devel@m.gmane.org; Fri, 15 Dec 2006 07:10:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GvBst-0002Yx-EN for emacs-devel@gnu.org; Fri, 15 Dec 2006 07:09:51 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GvBss-0002Xi-PJ for emacs-devel@gnu.org; Fri, 15 Dec 2006 07:09:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GvBss-0002XW-CV for emacs-devel@gnu.org; Fri, 15 Dec 2006 07:09:50 -0500 Original-Received: from [64.233.182.191] (helo=nf-out-0910.google.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GvBsr-000476-Hs for emacs-devel@gnu.org; Fri, 15 Dec 2006 07:09:49 -0500 Original-Received: by nf-out-0910.google.com with SMTP id d4so1153984nfe for ; Fri, 15 Dec 2006 04:09:48 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:content-transfer-encoding:cc:subject:date:to:x-mailer:from; b=ZwJZ0T++uFPHdWugVVEpIP7POo7zxmTDIECpEg+KVD3ABirFP6FGSOriOtZjt+skhWu6rIeSD8QBOyZsh/mNL92EJiI88+K020faecwxedXWma/zrK8TSpBFVteJKRt7yolMiktQZuiqZmeUYKwWTcbqRfpDiP4+R46kU5UEUJg= Original-Received: by 10.49.8.10 with SMTP id l10mr2409161nfi.1166184588384; Fri, 15 Dec 2006 04:09:48 -0800 (PST) Original-Received: from ?192.168.1.177? ( [134.169.92.188]) by mx.google.com with ESMTP id g1sm11394444nfe.2006.12.15.04.09.47; Fri, 15 Dec 2006 04:09:48 -0800 (PST) In-Reply-To: <87bqm7yvyw.fsf@earthlink.net> Original-To: John J Foerch X-Mailer: Apple Mail (2.624) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63765 gmane.emacs.orgmode:963 Archived-At: I strongly support this proposal, this is a feature that would be very valuable. - Carsten On Dec 14, 2006, at 4:53, John J Foerch wrote: > Hello, > > I want to implement a particular feature in org-mode that depends upon > some > functionality being added to outline-mode. (org-mode is derived from > outline-mode.) The feature concerns display of ancestor and sibling > headings > when an isearch has come to successful completion in a hidden part of > the > file. The function whose job it is to decide what to display when an > isearch > has completed is called `outline-isearch-open-invisible'. Currently, > it > simply calls `(show-entry)'. The following patch changes that > function, and > adds a new variable, to allow derived modes or motivated users to > implement > alternate behavior. The default behavior remains the same, but can > more > easily be reprogrammed by a derived mode. > > Please comment, criticize, or enlighten. Thank you, > > John Foerch > > Index: lisp/outline.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/outline.el,v > retrieving revision 1.24 > diff -r1.24 outline.el > 745a746,757 >> (defvar outline-isearch-open-invisible-fun >> 'outline-isearch-open-invisible-show-entry >> "Function that will be called when a successful isearch >> finishes in an invisible overylay. The overlay will be passed >> to the function as its sole argument.") >> >> ;; Default function for outline-isearch-open-invisible-fun. Makes >> only the >> ;; single entry containing point visible. >> (defun outline-isearch-open-invisible-show-entry (overlay) >> ;; We rely on the fact that isearch places point on the matched >> text. >> (show-entry)) >> > 751c763,764 > < (show-entry)) > --- >> (if outline-isearch-open-invisible-fun >> (funcall outline-isearch-open-invisible-fun overlay))) > _______________________________________________ > Emacs-orgmode mailing list > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > -- Carsten Dominik Sterrenkundig Instituut "Anton Pannekoek" Universiteit van Amsterdam Kruislaan 403 NL-1098SJ Amsterdam phone: +31 20 525 7477 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [Orgmode] patch to outline.el concerning isearch Date: Thu, 14 Dec 2006 18:54:45 +0100 Message-ID: <8b0f2e638ee24e1c20681a0b7b293574@science.uva.nl> References: <87bqm7yvyw.fsf@earthlink.net> Mime-Version: 1.0 (Apple Message framework v624) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87bqm7yvyw.fsf@earthlink.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org To: John J Foerch Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org List-Id: emacs-orgmode.gnu.org I strongly support this proposal, this is a feature that would be very valuable. - Carsten On Dec 14, 2006, at 4:53, John J Foerch wrote: > Hello, > > I want to implement a particular feature in org-mode that depends upon > some > functionality being added to outline-mode. (org-mode is derived from > outline-mode.) The feature concerns display of ancestor and sibling > headings > when an isearch has come to successful completion in a hidden part of > the > file. The function whose job it is to decide what to display when an > isearch > has completed is called `outline-isearch-open-invisible'. Currently, > it > simply calls `(show-entry)'. The following patch changes that > function, and > adds a new variable, to allow derived modes or motivated users to > implement > alternate behavior. The default behavior remains the same, but can > more > easily be reprogrammed by a derived mode. > > Please comment, criticize, or enlighten. Thank you, > > John Foerch > > Index: lisp/outline.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/outline.el,v > retrieving revision 1.24 > diff -r1.24 outline.el > 745a746,757 >> (defvar outline-isearch-open-invisible-fun >> 'outline-isearch-open-invisible-show-entry >> "Function that will be called when a successful isearch >> finishes in an invisible overylay. The overlay will be passed >> to the function as its sole argument.") >> >> ;; Default function for outline-isearch-open-invisible-fun. Makes >> only the >> ;; single entry containing point visible. >> (defun outline-isearch-open-invisible-show-entry (overlay) >> ;; We rely on the fact that isearch places point on the matched >> text. >> (show-entry)) >> > 751c763,764 > < (show-entry)) > --- >> (if outline-isearch-open-invisible-fun >> (funcall outline-isearch-open-invisible-fun overlay))) > _______________________________________________ > Emacs-orgmode mailing list > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > -- Carsten Dominik Sterrenkundig Instituut "Anton Pannekoek" Universiteit van Amsterdam Kruislaan 403 NL-1098SJ Amsterdam phone: +31 20 525 7477