From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18203: 24.4.50; `ffap-url-p' should NOT be a defsubst Date: Fri, 25 Dec 2015 14:44:16 -0800 (PST) Message-ID: <8a81156c-8e23-4a2b-993f-d7b6f8f52a52@default> References: <241951d6-b2b3-42ef-a78a-47dacb7367a1@default> <87io3muxdc.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1451083527 25906 80.91.229.3 (25 Dec 2015 22:45:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Dec 2015 22:45:27 +0000 (UTC) Cc: 18203@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 25 23:45:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aCb6m-0002Ge-C3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 23:45:12 +0100 Original-Received: from localhost ([::1]:36690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCb6l-0003Q4-FV for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 17:45:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCb6i-0003Pz-1C for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 17:45:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aCb6c-0002N2-Vu for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 17:45:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCb6c-0002Mm-Rk for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 17:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aCb6c-0002VK-Mb for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 17:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2015 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18203 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 18203-submit@debbugs.gnu.org id=B18203.14510834649539 (code B ref 18203); Fri, 25 Dec 2015 22:45:02 +0000 Original-Received: (at 18203) by debbugs.gnu.org; 25 Dec 2015 22:44:24 +0000 Original-Received: from localhost ([127.0.0.1]:35790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCb5z-0002Tn-NU for submit@debbugs.gnu.org; Fri, 25 Dec 2015 17:44:23 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:43618) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCb5y-0002Ta-7r for 18203@debbugs.gnu.org; Fri, 25 Dec 2015 17:44:22 -0500 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tBPMiF69006327 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 25 Dec 2015 22:44:16 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tBPMiFuX009710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 25 Dec 2015 22:44:15 GMT Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id tBPMiF43005810; Fri, 25 Dec 2015 22:44:15 GMT In-Reply-To: <87io3muxdc.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110484 Archived-At: > > There is NO reason for this to be a defsubst. There is no reason for > > users not to take advantage of this function generally. >=20 > I changed it to a defun, Thank you. > but I don't know what you mean by "There is no > reason for users not to take advantage of this function generally.". > You can use a defsubst just as you would a defun. No, you cannot. If existing code invokes a defsubst and you have only the compiled version of that code, then you have no access to the function defined by that defsubst. The function _does not exist_ at runtime. You cannot advise it or debug it, and redefining it has no effect. Taking advantage of the function _"generally"_ includes having it available at runtime - it requires its existence _as a function_. `defsubst's are almost a misfeature nowadays. In any case, they be used should rarely, and only with good justification.