From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#32405: [PATCH] Turn misc objects into pseudovectors Date: Thu, 9 Aug 2018 00:44:03 -0700 Organization: UCLA Computer Science Department Message-ID: <8a7b2eba-578c-ad62-6b8a-262397d06902@cs.ucla.edu> References: <20180809025852.28874-1-eggert@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------DC92EF2FB0EB35C35AD27348" X-Trace: blaine.gmane.org 1533800594 29048 195.159.176.226 (9 Aug 2018 07:43:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 07:43:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: 32405@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 09 09:43:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnfbA-0007LV-Ey for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Aug 2018 09:43:08 +0200 Original-Received: from localhost ([::1]:48497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnfdF-0006RC-D6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Aug 2018 03:45:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnfd6-0006Pz-2q for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 03:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnfd1-0003KG-6J for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 03:45:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40489) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnfd0-0003Jy-Un for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 03:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fnfd0-0001JL-LC for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 03:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Aug 2018 07:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32405-submit@debbugs.gnu.org id=B32405.15338006544963 (code B ref 32405); Thu, 09 Aug 2018 07:45:02 +0000 Original-Received: (at 32405) by debbugs.gnu.org; 9 Aug 2018 07:44:14 +0000 Original-Received: from localhost ([127.0.0.1]:45507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnfcC-0001Hx-Iw for submit@debbugs.gnu.org; Thu, 09 Aug 2018 03:44:14 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnfcA-0001Hk-T1 for 32405@debbugs.gnu.org; Thu, 09 Aug 2018 03:44:11 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 45FC21600CC; Thu, 9 Aug 2018 00:44:05 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id TtE5iYgJw0K1; Thu, 9 Aug 2018 00:44:04 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5FD3F160516; Thu, 9 Aug 2018 00:44:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EAKCi1NFHwkc; Thu, 9 Aug 2018 00:44:04 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1CA731600CC; Thu, 9 Aug 2018 00:44:04 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149374 Archived-At: This is a multi-part message in MIME format. --------------DC92EF2FB0EB35C35AD27348 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Pip Cet wrote: > + case PVEC_FINALIZER: > + VECTOR_MARK (ptr); > + mark_object (XFINALIZER (obj)->function); > + break; > + >=20 > Isn't that precisely what the default code does? >=20 > Similarly for bool vectors, misc ptrs, and user ptrs. Thanks for mentioning that opportunity for further simplification. Follow= up=20 patch attached. > I'm curious what ideas you have for the newly freed Lisp_Type tag. I had been thinking of using it for immediate floats, if we want to insis= t on=20 full IEEE double semantics for Emacs Lisp. But if there's something more=20 important, we can use it for that instead. --------------DC92EF2FB0EB35C35AD27348 Content-Type: text/x-patch; name="0001-Simplify-mark_object-for-pseudovectors.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Simplify-mark_object-for-pseudovectors.patch" =46rom d7370693eb76477be79888f759d28a1affbd7e81 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 9 Aug 2018 00:35:47 -0700 Subject: [PATCH] Simplify mark_object for pseudovectors Suggested by Pip Cet (Bug#32405#14). * src/alloc.c (mark_object): Remove unnecessary special cases for PVEC_MARKER, PVEC_BOOL_VECTOR, PVEC_MISC_PTR, PVEC_USER_PTR, and PVEC_FINALIZER. change is to free up an enum Lisp_Type tag value, a scarce --- src/alloc.c | 20 ++------------------ src/lisp.h | 4 +++- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/src/alloc.c b/src/alloc.c index dcf11825bc..be00c30521 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -6375,28 +6375,10 @@ mark_object (Lisp_Object arg) mark_char_table (ptr, (enum pvec_type) pvectype); break; =20 - case PVEC_MARKER: - /* DO NOT mark thru the marker's chain. - The buffer's markers chain does not preserve markers from gc; - instead, markers are removed from the chain when freed by gc. *= / - case PVEC_BOOL_VECTOR: - case PVEC_MISC_PTR: -#ifdef HAVE_MODULES - case PVEC_USER_PTR: -#endif - /* No Lisp_Objects to mark in these. */ - VECTOR_MARK (ptr); - break; - case PVEC_OVERLAY: mark_overlay (XOVERLAY (obj)); break; =20 - case PVEC_FINALIZER: - VECTOR_MARK (ptr); - mark_object (XFINALIZER (obj)->function); - break; - case PVEC_SUBR: break; =20 @@ -6404,6 +6386,8 @@ mark_object (Lisp_Object arg) emacs_abort (); =20 default: + /* A regular vector, or a pseudovector needing no special + treatment. */ mark_vectorlike (ptr); } } diff --git a/src/lisp.h b/src/lisp.h index c559377288..cfed2cf2d6 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -2256,7 +2256,9 @@ struct Lisp_Marker does not point anywhere. */ =20 /* For markers that point somewhere, - this is used to chain of all the markers in a given buffer. */ + this is used to chain of all the markers in a given buffer. + The chain does not preserve markers from garbage collection; + instead, markers are removed from the chain when freed by GC. */ /* We could remove it and use an array in buffer_text instead. That would also allow us to preserve it ordered. */ struct Lisp_Marker *next; --=20 2.17.1 --------------DC92EF2FB0EB35C35AD27348--