From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2 Date: Fri, 20 Jul 2018 10:27:06 -0400 Message-ID: <8a6d43f0-02b2-87a4-4a2a-1abb76cbd577@cornell.edu> References: <031d18cf-e661-6dea-8882-38d75924d0d4@cornell.edu> <83601c4m37.fsf@gnu.org> <83in5b2w1q.fsf@gnu.org> <83d0vj2tu2.fsf@gnu.org> <6642c8ac-55ff-ca2b-0141-a26b69d082ad@cs.ucla.edu> <83y3e61jl2.fsf@gnu.org> <83601a0z66.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6F8663D192465652A8D418DD" X-Trace: blaine.gmane.org 1532096773 19399 195.159.176.226 (20 Jul 2018 14:26:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2018 14:26:13 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: p.stephani2@gmail.com, eggert@cs.ucla.edu, 32189@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 20 16:26:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgWMC-0004sE-IZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jul 2018 16:26:08 +0200 Original-Received: from localhost ([::1]:48407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgWOF-0001tB-K6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jul 2018 10:28:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgWO8-0001t5-DE for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:28:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgWO2-0001bS-Ad for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:28:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44819) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fgWO2-0001aL-5c for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fgWO1-0003eF-Sp for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jul 2018 14:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32189-submit@debbugs.gnu.org id=B32189.153209684313967 (code B ref 32189); Fri, 20 Jul 2018 14:28:01 +0000 Original-Received: (at 32189) by debbugs.gnu.org; 20 Jul 2018 14:27:23 +0000 Original-Received: from localhost ([127.0.0.1]:49837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgWNO-0003dC-Gk for submit@debbugs.gnu.org; Fri, 20 Jul 2018 10:27:22 -0400 Original-Received: from limerock02.mail.cornell.edu ([128.84.13.242]:54075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgWNM-0003ct-BM for 32189@debbugs.gnu.org; Fri, 20 Jul 2018 10:27:20 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6KER6mS001627; Fri, 20 Jul 2018 10:27:06 -0400 Original-Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6KER4gG010491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 20 Jul 2018 10:27:05 -0400 In-Reply-To: <83601a0z66.fsf@gnu.org> Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148731 Archived-At: This is a multi-part message in MIME format. --------------6F8663D192465652A8D418DD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 7/20/2018 10:17 AM, Eli Zaretskii wrote: >> Cc: p.stephani2@gmail.com, 32189@debbugs.gnu.org >> From: Ken Brown >> Date: Fri, 20 Jul 2018 09:49:39 -0400 >> >> ../../master/src/w32cygwinx.c: In function ‘format_string’: >> ../../master/src/w32cygwinx.c:32:3: warning: function ‘format_string’ >> might be a candidate for ‘gnu_printf’ format attribute >> [-Wsuggest-attribute=format] >> Lisp_Object str = vformat_string (format, args); >> ^~~~~~~~~~~ > > We do this with vformat_string: > > extern Lisp_Object vformat_string (const char *, va_list) > ATTRIBUTE_FORMAT_PRINTF (1, 0); > > So I guess this new function needs a similar treatment. Amended patch attached. Ken --------------6F8663D192465652A8D418DD Content-Type: text/plain; charset=UTF-8; name="0001-Simplify-w32cygwinx.c-and-pacify-GCC-Bug-32189.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Simplify-w32cygwinx.c-and-pacify-GCC-Bug-32189.patch" RnJvbSA0N2JjNzZiNzM0NTZjNmI5YWQwMmJiMDIxMjNmMmIxMjg1NDM0MTkyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDE5IEp1bCAyMDE4IDE2OjEyOjE3IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gU2ltcGxpZnkgdzMyY3lnd2lueC5jIGFuZCBwYWNpZnkgR0NDIChCdWcjMzIxODkpCgoq IHNyYy93MzJjeWd3aW54LmMgKGZvcm1hdF9zdHJpbmcpOiBOZXcgZnVuY3Rpb24uCihGdzMy X2JhdHRlcnlfc3RhdHVzKTogVXNlIGl0LgotLS0KIHNyYy93MzJjeWd3aW54LmMgfCAzNyAr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg MTYgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3cz MmN5Z3dpbnguYyBiL3NyYy93MzJjeWd3aW54LmMKaW5kZXggOGQzYWUxNjRjZi4uNWQ0OGMz YTllMSAxMDA2NDQKLS0tIGEvc3JjL3czMmN5Z3dpbnguYworKysgYi9zcmMvdzMyY3lnd2lu eC5jCkBAIC0yNCw2ICsyNCwxNiBAQCBhbG9uZyB3aXRoIEdOVSBFbWFjcy4gIElmIG5vdCwg c2VlIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwogI2luY2x1ZGUgImxp c3AuaCIKICNpbmNsdWRlICJ3MzJjb21tb24uaCIKIAorc3RhdGljIExpc3BfT2JqZWN0IEFU VFJJQlVURV9GT1JNQVRfUFJJTlRGICgxLCAyKQorZm9ybWF0X3N0cmluZyAoY2hhciBjb25z dCAqZm9ybWF0LCAuLi4pCit7CisgIHZhX2xpc3QgYXJnczsKKyAgdmFfc3RhcnQgKGFyZ3Ms IGZvcm1hdCk7CisgIExpc3BfT2JqZWN0IHN0ciA9IHZmb3JtYXRfc3RyaW5nIChmb3JtYXQs IGFyZ3MpOworICB2YV9lbmQgKGFyZ3MpOworICByZXR1cm4gc3RyOworfQorCiBERUZVTiAo InczMi1iYXR0ZXJ5LXN0YXR1cyIsIEZ3MzJfYmF0dGVyeV9zdGF0dXMsIFN3MzJfYmF0dGVy eV9zdGF0dXMsIDAsIDAsIDAsCiAgICAgICAgZG9jOiAvKiBHZXQgcG93ZXIgc3RhdHVzIGlu Zm9ybWF0aW9uIGZyb20gV2luZG93cyBzeXN0ZW0uCiAKQEAgLTkyLDMyICsxMDIsMTcgQEAg VGhlIGZvbGxvd2luZyAlLXNlcXVlbmNlcyBhcmUgcHJvdmlkZWQ6CiAgICAgICBpZiAoc3lz dGVtX3N0YXR1cy5CYXR0ZXJ5TGlmZVBlcmNlbnQgPiAxMDApCiAJbG9hZF9wZXJjZW50YWdl ID0gYnVpbGRfc3RyaW5nICgiTi9BIik7CiAgICAgICBlbHNlCi0JewotCSAgY2hhciBidWZm ZXJbMTZdOwotCSAgc25wcmludGYgKGJ1ZmZlciwgMTYsICIlZCIsIHN5c3RlbV9zdGF0dXMu QmF0dGVyeUxpZmVQZXJjZW50KTsKLQkgIGxvYWRfcGVyY2VudGFnZSA9IGJ1aWxkX3N0cmlu ZyAoYnVmZmVyKTsKLQl9CisJbG9hZF9wZXJjZW50YWdlID0gZm9ybWF0X3N0cmluZyAoIiVk Iiwgc3lzdGVtX3N0YXR1cy5CYXR0ZXJ5TGlmZVBlcmNlbnQpOwogCiAgICAgICBpZiAoc2Vj b25kc19sZWZ0IDwgMCkKIAlzZWNvbmRzID0gbWludXRlcyA9IGhvdXJzID0gcmVtYWluID0g YnVpbGRfc3RyaW5nICgiTi9BIik7CiAgICAgICBlbHNlCiAJewotCSAgbG9uZyBtOwotCSAg ZG91YmxlIGg7Ci0JICBjaGFyIGJ1ZmZlclsxNl07Ci0JICBzbnByaW50ZiAoYnVmZmVyLCAx NiwgIiVsZCIsIHNlY29uZHNfbGVmdCk7Ci0JICBzZWNvbmRzID0gYnVpbGRfc3RyaW5nIChi dWZmZXIpOwotCi0JICBtID0gc2Vjb25kc19sZWZ0IC8gNjA7Ci0JICBzbnByaW50ZiAoYnVm ZmVyLCAxNiwgIiVsZCIsIG0pOwotCSAgbWludXRlcyA9IGJ1aWxkX3N0cmluZyAoYnVmZmVy KTsKLQotCSAgaCA9IHNlY29uZHNfbGVmdCAvIDM2MDAuMDsKLQkgIHNucHJpbnRmIChidWZm ZXIsIDE2LCAiJTMuMWYiLCBoKTsKLQkgIGhvdXJzID0gYnVpbGRfc3RyaW5nIChidWZmZXIp OwotCi0JICBzbnByaW50ZiAoYnVmZmVyLCAxNiwgIiVsZDolMDJsZCIsIG0gLyA2MCwgbSAl IDYwKTsKLQkgIHJlbWFpbiA9IGJ1aWxkX3N0cmluZyAoYnVmZmVyKTsKKwkgIGxvbmcgbSA9 IHNlY29uZHNfbGVmdCAvIDYwOworCSAgc2Vjb25kcyA9IGZvcm1hdF9zdHJpbmcgKCIlbGQi LCBzZWNvbmRzX2xlZnQpOworCSAgbWludXRlcyA9IGZvcm1hdF9zdHJpbmcgKCIlbGQiLCBt KTsKKwkgIGhvdXJzID0gZm9ybWF0X3N0cmluZyAoIiUzLjFmIiwgc2Vjb25kc19sZWZ0IC8g MzYwMC4wKTsKKwkgIHJlbWFpbiA9IGZvcm1hdF9zdHJpbmcgKCIlbGQ6JTAybGQiLCBtIC8g NjAsIG0gJSA2MCk7CiAJfQogCiAgICAgICBzdGF0dXMgPSBsaXN0biAoQ09OU1RZUEVfSEVB UCwgOCwKLS0gCjIuMTcuMAoK --------------6F8663D192465652A8D418DD--