From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41572: 28.0.50; [PATCH] Support plain project marked with file .emacs-project Date: Sat, 26 Nov 2022 14:29:56 +0200 Message-ID: <8a588083-3a00-a9e9-2d80-6885b64efbab@yandex.ru> References: <5f584d83-ef45-9912-bfbc-d2f00b24b9fd@yandex.ru> <87pnahjgdr.fsf@linkov.net> <87ftb92u8q.fsf@thornhill.no> <0ab90cf2-eab2-6fea-6698-4164d7753cd7@yandex.ru> <87d06ck2b0.fsf@thornhill.no> <2fbe5d5d-03a1-212b-9dd7-4723e168ad06@yandex.ru> <5EpzudgjedeKADsX4_Tq-2WtNm3XKXmZjnEI7Y1lmw-Pcn_KrzKPD1o31Ele0JOIrZ1ITDdeQrOsJTHfGVPJlzyLhmqjxP3rmVVzou8KEBo=@thornhill.no> <2a70c748-e250-2f96-5d74-712b6d71e8be@yandex.ru> <871riitzch.fsf@gnus.org> <9781acc2-e4c0-b53c-6422-ef2e0a96f400@yandex.ru> <877czirqj6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: "Philip K." , Rudi Schlatte , Augusto Stoffel , Zhu Zihao , Theodor Thornhill , Daniel =?UTF-8?Q?Mart=C3=ADn?= , Eric Abrahamsen , Manuel Uberti , Juri Linkov , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , 41572@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 13:31:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyuLF-0000jh-93 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 13:31:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyuKl-0007QC-Sv; Sat, 26 Nov 2022 07:31:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyuKk-0007PN-El for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 07:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyuKk-000146-5n for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 07:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyuKk-0003rL-2O for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 07:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41572 X-GNU-PR-Package: emacs Original-Received: via spool by 41572-submit@debbugs.gnu.org id=B41572.16694658087057 (code B ref 41572); Sat, 26 Nov 2022 12:31:02 +0000 Original-Received: (at 41572) by debbugs.gnu.org; 26 Nov 2022 12:30:08 +0000 Original-Received: from localhost ([127.0.0.1]:38092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyuJr-0001oi-JJ for submit@debbugs.gnu.org; Sat, 26 Nov 2022 07:30:08 -0500 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:36685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyuJp-0001Xn-V3 for 41572@debbugs.gnu.org; Sat, 26 Nov 2022 07:30:07 -0500 Original-Received: by mail-wr1-f44.google.com with SMTP id z4so10255522wrr.3 for <41572@debbugs.gnu.org>; Sat, 26 Nov 2022 04:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=pFNtEWiLS46fbmVvRLYzI45SA6X5AEoVQw/ThYlm0kw=; b=OPXVSOACpBS+zyzjcv7icR/9dYmfMQKjOmisC2HwKp3NgeBKKDnwKdYuOnGRUspdYj Jxa184rWv3/dIxqkzs4VMZJ1YN8XBQlJh4uF+WGGXzTGTmFlJpTC+3F7l0tnUQsI8qt9 lERXgBI/0TUD3xH+6kQ1cnat4NoN6OpnQIqHXmLyLaBF346lpugFmjJWGPdUkcUfjkUZ 6Sw3PpVPYx0ebt8BAxHlr8QxBpwFf8ikPtGa1/kfzKC11C2Ewrav6ZWnJrHbLFmP46iY 0x53Twt4TmXMYH8x5EZ2TW1m+LSShJafRKA101yPfeLGOjUudY2rN+lINzTEBP5FTBj3 xkcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pFNtEWiLS46fbmVvRLYzI45SA6X5AEoVQw/ThYlm0kw=; b=IjAl46rMR7vOTp4Wl/ceObeQ2sU5ZYCvdB4q963B3v0BWn3aFqQkJQZ7+h/RyFqp2+ BUQvTdf22uJQsdf7uxSsG/EWWp5pDBxOahaWRfL3Jyz3NZJf2YjiaMuAE7ffaKcue95p EcYPrzrE6Ofh+n39XhQWAIdIR/ujrJZJXmdh7DOAshMNWWOe2g1vWftnzqp6FlWQLpkT iC5Vf/GcRdVoCh2Fps7xpoLaHmFfajXK4bMDk10YGmy9ncpgqVyARMeqDoRTatV8TDH5 DeE1PY5CCkjcPwczICmkUROH2Rtf8DTutO89veO1wAX7AtEJ7PEXu3Qggp1Lpnn5zM+w Gd3A== X-Gm-Message-State: ANoB5pkAbWbjpa9jLbcZpFgDgEAK8M4SsSUBsAVs8oFtcSAaYqibwHWL H5oB5Y/56H2JAdxTvSLqRCM= X-Google-Smtp-Source: AA0mqf7zATYrmQJchVLOdCtzcj8H++e6TONtnMXcTI9+VuvDKuFUO9lFh0PinfeKcST2Rn/zwbQzew== X-Received: by 2002:adf:ec84:0:b0:241:c36f:c3b1 with SMTP id z4-20020adfec84000000b00241c36fc3b1mr23404080wrn.310.1669465800121; Sat, 26 Nov 2022 04:30:00 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h16-20020a05600c315000b003cfb7c02542sm9152774wmo.11.2022.11.26.04.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 04:29:59 -0800 (PST) Content-Language: en-US In-Reply-To: <877czirqj6.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249077 Archived-At: On 26/11/22 11:52, João Távora wrote: > Dmitry Gutov writes: > >> Does this work for everybody? > > I was pointed to this thread and asked to comment on this patch. > > My use case is the following: I'm interested in being able to designate > projects (through various means, not only marker files) that may only > exist inside other projects. You previously described your super-project and how you handled it using project-find-functions hook with a new element that looked for file markers. Does this patch make that easier to do? Without writing custom functions? > I then want the C-x p family of commands > to allow a choice of inner project or any of the associated > super-projects. Please avoid mixing feature requests. I already said that "choice of inner or outer" is out of scope for this, but it's easily implemented on top. > I can't understand from the patch alone if it solves this case, but it > seems that it doesn't come near. If not for any other reason, I can't > always use marker files. Did you prefer the other patch in this report? Or do you perhaps see an easy way to augment this patch to cover the remaining cases? Perhaps of project-vc-extra-root-markers also accepted absolute directory names, or if an additional variable did that. > I do see that in your patch more and more things appeari under the > existing VC type, which I think is growing too much. The comment itself > admits that "VC" becomes "VC and etc." -- this is not a good sign. > > The patch seems to be trying very hard not to create a new project type. That's called "tradeoffs". Previous patches, if you saw them, made different tradeoffs with different downsides. > But if a new subproject type was created with a link to a previously > found super-project. One could easily e.g. reuse the super-project's > ignore rules etc in the sub-project. For us to be able to discuss the alternatives, you'd have to read the previous comments on this report. Or I guess you can post a reasonably complete and functional alternative patch and we'd discuss the tradeoffs there.