From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Thu, 5 Jan 2023 22:27:28 +0100 Message-ID: <8a49efd8-178d-076c-f28f-e3d913040e26@secure.kjonigsen.net> References: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> <92941757-2E9A-4883-A3F1-2DCA2E4E8767@secure.kjonigsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26045"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: 60376@debbugs.gnu.org, eliz@gnu.org To: Yuan Fu , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 22:28:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDXml-0006LS-Bk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 22:28:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDXmO-0006Bj-WD; Thu, 05 Jan 2023 16:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDXmN-0006Ax-Et for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 16:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDXmM-0001IF-Vt for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 16:28:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDXmM-0007uT-GC for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 16:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2023 21:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167295405730372 (code B ref 60376); Thu, 05 Jan 2023 21:28:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 5 Jan 2023 21:27:37 +0000 Original-Received: from localhost ([127.0.0.1]:53139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXlw-0007to-S3 for submit@debbugs.gnu.org; Thu, 05 Jan 2023 16:27:37 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXlv-0007tb-Fy for 60376@debbugs.gnu.org; Thu, 05 Jan 2023 16:27:36 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6C9475C00FC; Thu, 5 Jan 2023 16:27:30 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 05 Jan 2023 16:27:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1672954050; x=1673040450; bh=xSZYsX6p3K 7jjgnXZNMX1LEJiEda8Z98pIgBSjczLI4=; b=YThoNm0rl47PgpNHp8GTtNbVZx 25/XrN4uYK2YoqH0xe/tl3YeMzlljLyNxXxPJf96Kq0siU1V2ThUNcqofuCkPAU6 t1aVCjhMzBnD7wpTxnIwazpg1ZQsk5QVKbWCZNGr841mu1ezAfPaaNVUUQJp1iXj dEWUtXW/RpXN0QIcPQvGO2xyrBZqzIt55KJEBQFch9526OYHAvgr0KPjpKw8mRs3 jZUD5MxvvGSzW7OgHjwo8rhu3keXmXcwBTegscsrfhwA9LmZ7uyCfV8MhKSn505E y46EIutyfgFmhBi5M9HGGNP/J1dyO1Eqfa1at3iOd1t9+vG+G/Y0yvQ7ezUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672954050; x= 1673040450; bh=xSZYsX6p3K7jjgnXZNMX1LEJiEda8Z98pIgBSjczLI4=; b=s kuDRfg0gzjWpDoG/W3n1r68myo5ma9JGgdgoGHw4VZo8PP9eKTt97VcNrzzVjDfD f88QYZu+4fShln2AA26mI3wXxscgoevk/p2jfBryryVZvYScwHjMkjGWTwHZVucm 4SdiCAqoWt6AgK1AcbFrhzDzOGB99azZZ8ARFX8W0t1J2MOEqVhNE7d6IWbxL5lk hEm4fvLRr42DBnlIBETezZ1Itd/rjSUXcIC5UXtsb3UQiFidze5+b4QfaOYJuwfP +QRLWs1Va27tAktZmLg28p2XXfV6niBdB0sNc/0ai0XixVNfvxCg5gIM2R/2nbAQ 0Wa+o0w+92+cZhkrShF4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeekgdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffhvfevfhgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeeifedvjedvueeggfelgedvudek veeitdetkeekhfeuvdefhfffieeuleegteeffeenucffohhmrghinhepkhhjnhhighhsvg hnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Jan 2023 16:27:29 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: <92941757-2E9A-4883-A3F1-2DCA2E4E8767@secure.kjonigsen.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252644 Archived-At: On 03.01.2023 06:43, Jostein Kjønigsen wrote: > Yuan: did you forget applying this last patch? :) > > — > Jostein Kjønigsen > https://jostein.kjønigsen.net > >> On 2 Jan 2023, at 10:59, Jostein Kjønigsen wrote: >> Great! Thanks! >> >> Please note: The previous patch removed a very wide (generic_name (identifier)) selector, which incorrectly caused generic functions to be highlighted as a types. >> >> This has lead to having to add in more specific (xxx (generic_name (identifier)) selectors around the codebase to compensate, and the previous patch evidently didn't have "all" the ones we need. >> >> Attached is a very small patch which should make support for highlighting generic types more complete. I won't promise it has 100% coverage, but with this in place, I can't see any obvious places in code where I'm missing out. >> >> With this in place, the only thing I'd like to improve now (if any) is indentation for object-creation/initialization expressions. I've made a few attempts and can't get those to behave properly. >> >> Is this anything you could take a look at, Theo? :) >> >> -- >> Jostein >> Given the feature-freeze on emacs-29 now, could someone please get the above patch installed? That would at least make me feel more comfortable :) -- Jostein