From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#28244: 26.0.50; byte-compiled files have mode 0600 Date: Sat, 26 Aug 2017 23:10:55 -0700 Organization: UCLA Computer Science Department Message-ID: <8a1a9773-83a9-cb58-f808-08133fec6217@cs.ucla.edu> References: <87r2vyytng.fsf@turtle.gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------AEE02F65C5D78B9B38DDCF1C" X-Trace: blaine.gmane.org 1503814336 20671 195.159.176.226 (27 Aug 2017 06:12:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 Aug 2017 06:12:16 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Cc: 28244-done@debbugs.gnu.org To: Sven Joachim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 27 08:12:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlqnm-0004qN-1J for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 08:12:06 +0200 Original-Received: from localhost ([::1]:59728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlqns-0005uy-U2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 02:12:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlqnm-0005tm-Df for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 02:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlqnj-0000aa-7O for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 02:12:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlqnj-0000aQ-3R for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 02:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlqni-0002Sw-NK for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 02:12:02 -0400 In-Reply-To: <87r2vyytng.fsf@turtle.gmx.de> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2017 06:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 28244 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 28244@debbugs.gnu.org, eggert@cs.ucla.edu, svenjoac@gmx.de Original-Received: via spool by 28244-done@debbugs.gnu.org id=D28244.15038142669411 (code D ref 28244); Sun, 27 Aug 2017 06:12:02 +0000 Original-Received: (at 28244-done) by debbugs.gnu.org; 27 Aug 2017 06:11:06 +0000 Original-Received: from localhost ([127.0.0.1]:56983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlqmn-0002Rj-TK for submit@debbugs.gnu.org; Sun, 27 Aug 2017 02:11:06 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlqml-0002RC-HS for 28244-done@debbugs.gnu.org; Sun, 27 Aug 2017 02:11:04 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EB855160080; Sat, 26 Aug 2017 23:10:56 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ly0NG8sPkpzG; Sat, 26 Aug 2017 23:10:56 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1E4B8160923; Sat, 26 Aug 2017 23:10:56 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id n8iOpIbAeqHM; Sat, 26 Aug 2017 23:10:56 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E748C160080; Sat, 26 Aug 2017 23:10:55 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136246 Archived-At: This is a multi-part message in MIME format. --------------AEE02F65C5D78B9B38DDCF1C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that bug. It was indeed an unintended consequence of my earlier change. I installed the attached patch, which should fix it. --------------AEE02F65C5D78B9B38DDCF1C Content-Type: text/x-patch; name="0001-Fix-over-protection-of-byte-compiled-files.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-over-protection-of-byte-compiled-files.patch" >From 7207e4a3d533d959eebbb947235f741b1586722b Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 26 Aug 2017 23:07:01 -0700 Subject: [PATCH] Fix over-protection of byte-compiled files Problem reported by Sven Joachim (Bug#28244). Also, fix similar problem for autoload files. * lisp/emacs-lisp/autoload.el (autoload--save-buffer): Set temp file modes to the buffer-file-name file modes (or 666 if not available) as adjusted by umask. * lisp/emacs-lisp/bytecomp.el (byte-compile-file): Set temp file modes to 666 as adjusted by umask. --- lisp/emacs-lisp/autoload.el | 8 +++++++- lisp/emacs-lisp/bytecomp.el | 5 +++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el index 4a9bd6d..e811ee2 100644 --- a/lisp/emacs-lisp/autoload.el +++ b/lisp/emacs-lisp/autoload.el @@ -873,12 +873,18 @@ autoload-generate-file-autoloads ;; For parallel builds, to stop another process reading a half-written file. (defun autoload--save-buffer () "Save current buffer to its file, atomically." - ;; Copied from byte-compile-file. + ;; Similar to byte-compile-file. (let* ((version-control 'never) (tempfile (make-temp-file buffer-file-name)) + (default-modes (default-file-modes)) + (temp-modes (logand default-modes #o600)) + (desired-modes (logand default-modes + (or (file-modes buffer-file-name) #o666))) (kill-emacs-hook (cons (lambda () (ignore-errors (delete-file tempfile))) kill-emacs-hook))) + (unless (= temp-modes desired-modes) + (set-file-modes tempfile desired-modes)) (write-region (point-min) (point-max) tempfile nil 1) (backup-buffer) (rename-file tempfile buffer-file-name t)) diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index d769a15..48bbd61 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1896,10 +1896,15 @@ byte-compile-file ;; parallel bootstrap), it does not risk getting a ;; half-finished file. (Bug#4196) (tempfile (make-temp-file target-file)) + (default-modes (default-file-modes)) + (temp-modes (logand default-modes #o600)) + (desired-modes (logand default-modes #o666)) (kill-emacs-hook (cons (lambda () (ignore-errors (delete-file tempfile))) kill-emacs-hook))) + (unless (= temp-modes desired-modes) + (set-file-modes tempfile desired-modes)) (write-region (point-min) (point-max) tempfile nil 1) ;; This has the intentional side effect that any ;; hard-links to target-file continue to -- 2.7.4 --------------AEE02F65C5D78B9B38DDCF1C--