From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: Bug: Invalid face reference Date: Fri, 29 Feb 2008 21:10:43 +0100 Message-ID: <8F0F696D-0C50-4DE7-9E2B-C5F52A63175C@gmail.com> References: <47C5F369.10206@gmail.com> <87wsop6f4p.fsf@bzg.ath.cx> <47C617B0.90801@gmail.com> <47C6E374.2050401@gmail.com> <47C83EB8.50302@gmail.com> <47C851EC.7000500@gmail.com> Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JVBZF-0001Fr-2M for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:10:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JVBZC-0001Di-9b for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:10:52 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVBZC-0001DZ-1L for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:10:50 -0500 Received: from ug-out-1314.google.com ([66.249.92.173]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JVBZB-0002Ct-LE for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:10:49 -0500 Received: by ug-out-1314.google.com with SMTP id a2so483546ugf.48 for ; Fri, 29 Feb 2008 12:10:48 -0800 (PST) In-Reply-To: <47C851EC.7000500@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Wanrong Lin Cc: emacs-orgmode@gnu.org I am taking this patch thanks! This might indeed make the advice for htmlize unnecessary - could you please remove it your own setup and test this for a long while? And then report back? Thanks! - Carsten On Feb 29, 2008, at 7:41 PM, Wanrong Lin wrote: > Found the bug and fixed it as following (see the comment line marked > with ) > ------------- > (defun org-agenda-align-tags (&optional line) > "Align all tags in agenda items to `org-agenda-tags-column'." > (let ((inhibit-read-only t) l c) > (save-excursion > (goto-char (if line (point-at-bol) (point-min))) > (while (re-search-forward (org-re "\\([ \t]+\\)\\(:[[:alnum:]_@:] > +:\\)[ \t]*$") > (if line (point-at-eol) nil) t) > (add-text-properties > (match-beginning 2) (match-end 2) > ;; : bug fix against 5.22a > (list 'face (delq nil (list 'org-tag (get-text-property > (match-beginning 2) > 'face))))) > (setq l (- (match-end 2) (match-beginning 2)) > c (if (< org-agenda-tags-column 0) > (- (abs org-agenda-tags-column) l) > org-agenda-tags-column)) > (delete-region (match-beginning 1) (match-end 1)) > (goto-char (match-beginning 1)) > (insert (org-add-props > (make-string (max 1 (- c (current-column))) ?\ ) > (text-properties-at (point)))))))) > > > Wanrong Lin wrote: >> More update: >> >> In a tag search result buffer, I move the cursor to a tag, and eval >> (get-text-property (point) 'face), and I get: (org-tag nil). So >> this "nil" is causing the problem, but I don't know where it is >> sneaked in. >> >> Wanrong >> >>> Just some update: >>> >>> I called (org-restart-font-lock) function inside my tag search >>> result buffer, and I can see a new "Invalid face reference: nil [X >>> times]" message is generated in the "*Messages*" buffer, with "X" >>> keeps increasing. I have "jit-lock-mode" (Just in time font >>> locking) enabled in my emacs config, so I guess that ticking "X" >>> number is from the background font locking process. >>> >>> It seems something is wrong with font locking for tags. But this >>> only happens in tag search result buffer. It does not happen in >>> regular agenda buffer. >>> >>> I don't know how to proceed to pin-point this. Can any of you guys >>> also reproduce this? Any suggestions? Thank you. >>> >>> Wanrong >>> >>> >> >> > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode