From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emre Yolcu Newsgroups: gmane.emacs.bugs Subject: bug#71085: text-scale-adjust does not adjust margin width Date: Tue, 21 May 2024 16:10:14 -0400 Message-ID: <8E15D0B1-7CC7-4202-9D13-BC4AF8319BF1@emreyolcu.com> References: <86r0dv8kes.fsf@gnu.org> <86ed9v81xa.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Content-Type: text/plain; charset=us-ascii; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27143"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71085@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 21 22:11:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s9VpL-0006mu-BZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 May 2024 22:11:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9Vp8-0007p7-0r; Tue, 21 May 2024 16:11:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9Vp3-0007oa-0s for bug-gnu-emacs@gnu.org; Tue, 21 May 2024 16:10:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9Vp2-0006B6-PR for bug-gnu-emacs@gnu.org; Tue, 21 May 2024 16:10:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9Vp8-0005u3-4G for bug-gnu-emacs@gnu.org; Tue, 21 May 2024 16:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Emre Yolcu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 May 2024 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71085 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 71085-submit@debbugs.gnu.org id=B71085.171632223222683 (code B ref 71085); Tue, 21 May 2024 20:11:02 +0000 Original-Received: (at 71085) by debbugs.gnu.org; 21 May 2024 20:10:32 +0000 Original-Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9Voe-0005sx-7t for submit@debbugs.gnu.org; Tue, 21 May 2024 16:10:32 -0400 Original-Received: from wfhigh4-smtp.messagingengine.com ([64.147.123.155]:53983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9VoZ-0005sf-30 for 71085@debbugs.gnu.org; Tue, 21 May 2024 16:10:30 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.west.internal (Postfix) with ESMTP id D224D1800178; Tue, 21 May 2024 16:10:15 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 21 May 2024 16:10:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emreyolcu.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1716322215; x=1716408615; bh=/uFlkS0QS7lvZbUeoVDkwLBiflVjtqbu qbmk9KVvbhA=; b=KPI9wPCljErBt1+wOQ+mjexu+ngjUuV8dd/uZGVbnQVNPKQ8 ML9tibOAne07e06539u27LbHIOtQ163SyEUbzdaTWDfGO1/USR6bPMcx/Hl96yMu iWH6uEK9XT0fji9TUAnqYF2b2CRbF5hruvfi4Dl57jdS8eILPpzr7UENQ+xFmE1S lMZxdJJcez8q0oYYgU5BUxoLLUHoLhFrMFXPPf5+SwTbRfLix5o7oAq3WUiKok57 pYwUjZU4/INL9mBXhBRnMRN+U+JvFltStBFdts5pPrPMTvKxkbf6RbJHYYgXwdkL ArfQe4KOpSNfPN2b5eQ1/Fw2yogr3tWrLAnUJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716322215; x= 1716408615; bh=/uFlkS0QS7lvZbUeoVDkwLBiflVjtqbuqbmk9KVvbhA=; b=B Mf1ZDAl4RgSpnJ2mQqSoXtjf4SM0ZKmtMDBP2ZHQSGEVLsXgeMcSkGnYgY21j//I 9EVTqhd1xtbPpHyx+5Cb8IgK+VGvNNVQVFYOCuOtWVKF/K1PMcCEpN52v5tO/MRx sDXsnyslWE3cvZXPgzvyEvarhgOgoEEkuvVKQSc3Z4m1Hu5xaUAADXLITkXFF0mT xfkq9By9tFr/Sc0UgLn39gW4tNaicb3AnVpVs17/Y3KiYieX+5vx5N4dh9mNX+Ug EQPp3al8hOjrMF5GcyIIF+tbkEgPCIT30/Nsg8yidwV/fplZSGVYaUILLfEC2kBQ n2iva+W9kvHEmENDFfB0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeivddgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjffevgffkfhfvofesthejmhdthhdtvdenucfhrhhomhepgfhm rhgvucgjohhltghuuceomhgrihhlsegvmhhrvgihohhltghurdgtohhmqeenucggtffrrg htthgvrhhnpeelvddvfeegudejtedujeffgfeikeffveffieekteffudduieeffeegkeel heegkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrghilhesvghmrhgvhiholhgtuhdrtghomh X-ME-Proxy: Feedback-ID: i1b09467c:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 May 2024 16:10:15 -0400 (EDT) In-Reply-To: <86ed9v81xa.fsf@gnu.org> X-Mailer: Apple Mail (2.3608.120.23.2.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285556 Archived-At: > I don't see a need for it, sorry. Got it. Thanks for discussing it anyway. I don't want to keep the thread going for too long, but I want to reply to some of your comments and leave it at that. (Maybe the discussion will be useful in the future, on the off chance that the issue gets revisited.) >>> I don't understand the expectations: the window and frame geometry are >>> not changed by text-scale-adjust, so why did you expect the window >>> margins to change? The margins are part of the window geometry. >> I was not thinking of the margins as part of the window geometry but as >> a special part of the buffer that we set aside and do not interact with. > > Well, but the fact is the margins _are_ part of the window geometry. > And window geometry doesn't change when text size is scaled. So this > is a de-facto behavior Emacs had for several releases now, and we must > preserve it. FWIW, some wording in the Emacs manual suggests, at least for me, the interpretation that margins are to be viewed as part of the buffer. From Section 41.16.5: "A buffer can have blank areas called display margins on the left and on the right. Ordinary text never appears in these areas, ..." On the other hand, the function for setting margin widths is called "set-window-margins". >> A much nicer workaround would be possible if there >> existed a "margin" face: text-scale-mode could simply remap it as it >> does the default face. > > Actually, you want a face that will _not_ be remapped, since you want > to make sure the text in the margins will not get clipped. The > current behavior is that by default the text in the margin is already > remapped, which is why it can get clipped if it becomes too wide. By remap here I mean that it will remap the margin face *back* to the original height. The current behavior does not explicitly touch (remap) the text in the margin, so the height gets determined by the buffer-local height of the default face. If enabled, the option would make text-scale-mode remap the margin face back to the original height to prevent the text from getting clipped.