From: Emre Yolcu <mail@emreyolcu.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71085@debbugs.gnu.org
Subject: bug#71085: text-scale-adjust does not adjust margin width
Date: Tue, 21 May 2024 16:10:14 -0400 [thread overview]
Message-ID: <8E15D0B1-7CC7-4202-9D13-BC4AF8319BF1@emreyolcu.com> (raw)
In-Reply-To: <86ed9v81xa.fsf@gnu.org>
> I don't see a need for it, sorry.
Got it. Thanks for discussing it anyway. I don't want to keep the thread
going for too long, but I want to reply to some of your comments and leave
it at that. (Maybe the discussion will be useful in the future, on the off
chance that the issue gets revisited.)
>>> I don't understand the expectations: the window and frame geometry are
>>> not changed by text-scale-adjust, so why did you expect the window
>>> margins to change? The margins are part of the window geometry.
>> I was not thinking of the margins as part of the window geometry but as
>> a special part of the buffer that we set aside and do not interact with.
>
> Well, but the fact is the margins _are_ part of the window geometry.
> And window geometry doesn't change when text size is scaled. So this
> is a de-facto behavior Emacs had for several releases now, and we must
> preserve it.
FWIW, some wording in the Emacs manual suggests, at least for me, the
interpretation that margins are to be viewed as part of the buffer. From
Section 41.16.5: "A buffer can have blank areas called display margins on
the left and on the right. Ordinary text never appears in these areas,
..." On the other hand, the function for setting margin widths is called
"set-window-margins".
>> A much nicer workaround would be possible if there
>> existed a "margin" face: text-scale-mode could simply remap it as it
>> does the default face.
>
> Actually, you want a face that will _not_ be remapped, since you want
> to make sure the text in the margins will not get clipped. The
> current behavior is that by default the text in the margin is already
> remapped, which is why it can get clipped if it becomes too wide.
By remap here I mean that it will remap the margin face *back* to the
original height. The current behavior does not explicitly touch (remap)
the text in the margin, so the height gets determined by the buffer-local
height of the default face. If enabled, the option would make
text-scale-mode remap the margin face back to the original height to
prevent the text from getting clipped.
next prev parent reply other threads:[~2024-05-21 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 22:50 bug#71085: text-scale-adjust does not adjust margin width Emre Yolcu
2024-05-21 11:38 ` Eli Zaretskii
2024-05-21 16:14 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-21 16:14 ` Emre Yolcu
2024-05-21 18:17 ` Eli Zaretskii
2024-05-21 20:10 ` Emre Yolcu [this message]
2024-05-22 12:03 ` Eli Zaretskii
2024-05-22 17:05 ` Emre Yolcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8E15D0B1-7CC7-4202-9D13-BC4AF8319BF1@emreyolcu.com \
--to=mail@emreyolcu.com \
--cc=71085@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.