Bug: org-publish-current-project reverses the force flag.

Bug: org-publish-current-project reverses the force flag.

[t60500]

Hi.

I've found (maybe) a bug.

With org 5.22a (org-publish.el version 1.80 b),
org-publish-current-project reverses the force flag
when passing the flag to org-publish.

Thanks.

-- 
Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>

Re: Bug: org-publish-current-project reverses the force flag.

[Carsten Dominik]

[-- Attachment #1.1: Type: text/plain, Size: 679 bytes --]

Hi Kondo,

Why do you think so?
Force is used in the org-bublish function to temporarily turn off
org-publish-use-timestamp-flag.

- Carsten

On Feb 25, 2008, at 7:23 PM, t60500@mail.ecc.u-tokyo.ac.jp wrote:

>
> Hi.
>
> I've found (maybe) a bug.
>
> With org 5.22a (org-publish.el version 1.80 b),
> org-publish-current-project reverses the force flag
> when passing the flag to org-publish.
>
> Thanks.
>
> -- 
> Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode


[-- Attachment #1.2: Type: text/html, Size: 1230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: org-publish-current-project reverses the force flag.

[Kondo Kenji]

Hi Carsten,

Thank you for your reply.
I explain why.


I tried org-publish.el to export local org files to html,
and realized timestamps didn't work.

In fact, `M-x org-publish-current-project' published all the files,
including unchanged org files.

In contrast, `C-u M-x org-publish-current-project' published only
changed files.

`org-publish-use-timestamp-flag' was not set, whose default value is t.


In org-publish.el of verson 1.80b,
the definition of org-publish-current-project is like below:

: (defun org-publish-current-project (&optional force)
:   "Publish the project associated with the current file.
: With prefix argument, force publishing all files in project."
:  (interactive "P")
:  (save-window-excursion
:    (let* ((project-name (org-publish-get-project-from-filename (buffer-file-name))))
:      (if (not project-name)
:	  (error "File %s is not part of any known project." (buffer-file-name)))
:      (org-publish project-name (if force nil t)))))

I guess the last line is wrong.
It reverses the force flag, and `org-publish' reverses the flag again.

Is it correct?

-- 
Kondo Konji

At Tue, 26 Feb 2008 09:06:18 +0100,
Carsten Dominik wrote:
> 
> [1  <multipart/alternative (7bit)>]
> [1.1  <text/plain; US-ASCII (7bit)>]
> Hi Kondo,
> 
> Why do you think so?
> Force is used in the org-bublish function to temporarily turn off
> org-publish-use-timestamp-flag.
> 
> - Carsten
> 
> On Feb 25, 2008, at 7:23 PM, t60500@mail.ecc.u-tokyo.ac.jp wrote:
> 
> >
> > Hi.
> >
> > I've found (maybe) a bug.
> >
> > With org 5.22a (org-publish.el version 1.80 b),
> > org-publish-current-project reverses the force flag
> > when passing the flag to org-publish.
> >
> > Thanks.
> >
> > -- 
> > Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>
> >
> >
> > _______________________________________________
> > Emacs-orgmode mailing list
> > Remember: use `Reply All' to send replies to the list.
> > Emacs-orgmode@gnu.org
> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> 
> [1.2  <text/html; US-ASCII (quoted-printable)>]
> 
> [2  <text/plain; us-ascii (7bit)>]
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: org-publish-current-project reverses the force flag.

[Carsten Dominik]

Ah, this is about the default value.  Very wel, I'll look into it.

Thanks!

- Carsten

On Feb 26, 2008, at 1:20 PM, Kondo Kenji wrote:

>
> Hi Carsten,
>
> Thank you for your reply.
> I explain why.
>
>
> I tried org-publish.el to export local org files to html,
> and realized timestamps didn't work.
>
> In fact, `M-x org-publish-current-project' published all the files,
> including unchanged org files.
>
> In contrast, `C-u M-x org-publish-current-project' published only
> changed files.
>
> `org-publish-use-timestamp-flag' was not set, whose default value is  
> t.
>
>
> In org-publish.el of verson 1.80b,
> the definition of org-publish-current-project is like below:
>
> : (defun org-publish-current-project (&optional force)
> :   "Publish the project associated with the current file.
> : With prefix argument, force publishing all files in project."
> :  (interactive "P")
> :  (save-window-excursion
> :    (let* ((project-name (org-publish-get-project-from-filename  
> (buffer-file-name))))
> :      (if (not project-name)
> :	  (error "File %s is not part of any known project." (buffer-file- 
> name)))
> :      (org-publish project-name (if force nil t)))))
>
> I guess the last line is wrong.
> It reverses the force flag, and `org-publish' reverses the flag again.
>
> Is it correct?
>
> -- 
> Kondo Konji
>
> At Tue, 26 Feb 2008 09:06:18 +0100,
> Carsten Dominik wrote:
>>
>> [1  <multipart/alternative (7bit)>]
>> [1.1  <text/plain; US-ASCII (7bit)>]
>> Hi Kondo,
>>
>> Why do you think so?
>> Force is used in the org-bublish function to temporarily turn off
>> org-publish-use-timestamp-flag.
>>
>> - Carsten
>>
>> On Feb 25, 2008, at 7:23 PM, t60500@mail.ecc.u-tokyo.ac.jp wrote:
>>
>>>
>>> Hi.
>>>
>>> I've found (maybe) a bug.
>>>
>>> With org 5.22a (org-publish.el version 1.80 b),
>>> org-publish-current-project reverses the force flag
>>> when passing the flag to org-publish.
>>>
>>> Thanks.
>>>
>>> -- 
>>> Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>> [1.2  <text/html; US-ASCII (quoted-printable)>]
>>
>> [2  <text/plain; us-ascii (7bit)>]
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: org-publish-current-project reverses the force flag.

[Carsten Dominik]

Indeed, there was a bug, I have fixed it ow, available in the git  
repository, or later
in the next release (5.23).

Thanks for the report.

- Carsten

On Feb 25, 2008, at 7:23 PM, t60500@mail.ecc.u-tokyo.ac.jp wrote:

>
> Hi.
>
> I've found (maybe) a bug.
>
> With org 5.22a (org-publish.el version 1.80 b),
> org-publish-current-project reverses the force flag
> when passing the flag to org-publish.
>
> Thanks.
>
> -- 
> Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: org-publish-current-project reverses the force flag.

[Kondo Kenji]

Thank you but I'm afraid there still exists one problem to fix.

When `org-publish-use-timestamps-flag' is t,
`C-c C-e P' or `M-x org-publish-current-project'
publishes not only changed files but also unchanged files.

--
Kondo Kenji

At Tue, 26 Feb 2008 16:02:31 +0100,
Carsten Dominik wrote:
> 
> Indeed, there was a bug, I have fixed it ow, available in the git  
> repository, or later
> in the next release (5.23).
> 
> Thanks for the report.
> 
> - Carsten
> 
> On Feb 25, 2008, at 7:23 PM, t60500@mail.ecc.u-tokyo.ac.jp wrote:
> 
> >
> > Hi.
> >
> > I've found (maybe) a bug.
> >
> > With org 5.22a (org-publish.el version 1.80 b),
> > org-publish-current-project reverses the force flag
> > when passing the flag to org-publish.
> >
> > Thanks.
> >
> > -- 
> > Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>
> >
> >
> > _______________________________________________
> > Emacs-orgmode mailing list
> > Remember: use `Reply All' to send replies to the list.
> > Emacs-orgmode@gnu.org
> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> 
> 
> 
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: org-publish-current-project reverses the force flag.

[Carsten Dominik]

Thanks, I believe this is now fixes as well, please let me know if not.

- Carsten

On Feb 26, 2008, at 5:46 PM, Kondo Kenji wrote:

>
> Thank you but I'm afraid there still exists one problem to fix.
>
> When `org-publish-use-timestamps-flag' is t,
> `C-c C-e P' or `M-x org-publish-current-project'
> publishes not only changed files but also unchanged files.
>
> --
> Kondo Kenji
>
> At Tue, 26 Feb 2008 16:02:31 +0100,
> Carsten Dominik wrote:
>>
>> Indeed, there was a bug, I have fixed it ow, available in the git
>> repository, or later
>> in the next release (5.23).
>>
>> Thanks for the report.
>>
>> - Carsten
>>
>> On Feb 25, 2008, at 7:23 PM, t60500@mail.ecc.u-tokyo.ac.jp wrote:
>>
>>>
>>> Hi.
>>>
>>> I've found (maybe) a bug.
>>>
>>> With org 5.22a (org-publish.el version 1.80 b),
>>> org-publish-current-project reverses the force flag
>>> when passing the flag to org-publish.
>>>
>>> Thanks.
>>>
>>> -- 
>>> Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: org-publish-current-project reverses the force flag.

[Kondo Kenji]

Hmm. I tried the git version but timestampes didn't work with C-c C-e P
when `org-publish-use-timestamps-flag' is t.

Is it OK in your environment?

--
Kondo Kenji

At Wed, 27 Feb 2008 16:14:40 +0100,
Carsten Dominik wrote:
> 
> Thanks, I believe this is now fixes as well, please let me know if not.
> 
> - Carsten
> 
> On Feb 26, 2008, at 5:46 PM, Kondo Kenji wrote:
> 
> >
> > Thank you but I'm afraid there still exists one problem to fix.
> >
> > When `org-publish-use-timestamps-flag' is t,
> > `C-c C-e P' or `M-x org-publish-current-project'
> > publishes not only changed files but also unchanged files.
> >
> > --
> > Kondo Kenji
> >
> > At Tue, 26 Feb 2008 16:02:31 +0100,
> > Carsten Dominik wrote:
> >>
> >> Indeed, there was a bug, I have fixed it ow, available in the git
> >> repository, or later
> >> in the next release (5.23).
> >>
> >> Thanks for the report.
> >>
> >> - Carsten
> >>
> >> On Feb 25, 2008, at 7:23 PM, t60500@mail.ecc.u-tokyo.ac.jp wrote:
> >>
> >>>
> >>> Hi.
> >>>
> >>> I've found (maybe) a bug.
> >>>
> >>> With org 5.22a (org-publish.el version 1.80 b),
> >>> org-publish-current-project reverses the force flag
> >>> when passing the flag to org-publish.
> >>>
> >>> Thanks.
> >>>
> >>> -- 
> >>> Kondo Kenji <kondo@misojiro.t.u-tokyo.ac.jp>
> >>>
> >>>
> >>> _______________________________________________
> >>> Emacs-orgmode mailing list
> >>> Remember: use `Reply All' to send replies to the list.
> >>> Emacs-orgmode@gnu.org
> >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> >>
> >>
> >>
> >> _______________________________________________
> >> Emacs-orgmode mailing list
> >> Remember: use `Reply All' to send replies to the list.
> >> Emacs-orgmode@gnu.org
> >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> 

Re: Bug: org-publish-current-project reverses the force flag.

[Bastien]

Hi Kondo,

Kondo Kenji <t60500@mail.ecc.u-tokyo.ac.jp> writes:

> Hmm. I tried the git version but timestampes didn't work with C-c C-e P
> when `org-publish-use-timestamps-flag' is t.
>
> Is it OK in your environment?

I just tested it and it seems okay.  

Can you make sure there is no old `org-publish.el' haunting your
configuration and then check again?

Thanks,

-- 
Bastien

Re: Bug: org-publish-current-project reverses the force flag.

[Kondo Kenji]

Hi Bastien,


I tried the newer version and it works. Great!

Thanks.

--
Kondo Kenji

At Thu, 28 Feb 2008 01:14:34 +0000,
Bastien wrote:
> 
> Hi Kondo,
> 
> Kondo Kenji <t60500@mail.ecc.u-tokyo.ac.jp> writes:
> 
> > Hmm. I tried the git version but timestampes didn't work with C-c C-e P
> > when `org-publish-use-timestamps-flag' is t.
> >
> > Is it OK in your environment?
> 
> I just tested it and it seems okay.  
> 
> Can you make sure there is no old `org-publish.el' haunting your
> configuration and then check again?
> 
> Thanks,
> 
> -- 
> Bastien