From: Yuan Fu <casouri@gmail.com>
To: Knut Anders Hatlen <kahatlen@gmail.com>
Cc: 60397-done@debbugs.gnu.org
Subject: bug#60397: 29.0.60; c++-ts-mode could report better defun names
Date: Tue, 17 Jan 2023 01:39:40 -0800 [thread overview]
Message-ID: <8CF91E69-4784-4735-AECA-251901322018@gmail.com> (raw)
In-Reply-To: <87358yejw4.fsf@oracle.com>
Knut Anders Hatlen <kahatlen@gmail.com> writes:
> Yuan Fu <casouri@gmail.com> writes:
>
>> Knut Anders Hatlen <kahatlen@gmail.com> writes:
>>
>>> The defun names reported by c++-ts-mode could still need a couple of
>>> improvements:
>>>
>>> 1) In a buffer with c++-ts-mode and which-function-mode enabled, and
>>> this content:
>>>
>>> struct S {
>>> int f1(int x) {
>>> return x + 1;
>>> }
>>> int g1(int x);
>>> };
>>>
>>> int S::g1(int x) {
>>> return x + 1;
>>> }
>>>
>>> Inside the inline f1 function definition, which-function-mode shows
>>> "S.f1". But inside the out-of-line g1 function definition, it shows
>>> "n/a" instead of "S.g1". (Not limited to structs. Classes have the same
>>> problem.)
>>
>> Now the second function is displayed as S::g1.
>
> Looks good now. Classes seem to be handled fine too.
>
>>> 2) Namespaces are not handled. Given this content:
>>>
>>> namespace n {
>>> int f1(int x) {
>>> return x + 1;
>>> }
>>> }
>>>
>>> namespace {
>>> int f2(int x) {
>>> return x + 1;
>>> }
>>> }
>>>
>>> Inside the f1 and f2 function bodies, which-function-mode shows "f1" and
>>> "f2", respectively. It would be better if it showed "n.f1" for the
>>> former, and perhaps something like "(anonymous).f2" for the latter.
>>
>> Now the first function is shown as n.f1, the second is shown as f2.
>> Making it (anonymous).f2 isn’t necessarily better than f2 IMO, and
>> requires some non-trivial change to the current code, so I didn’t do it.
>
> Fair enough. Thanks!
Closing this since I think the problem’s fixed :-)
Yuan
prev parent reply other threads:[~2023-01-17 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 7:42 bug#60397: 29.0.60; c++-ts-mode could report better defun names Knut Anders Hatlen
2023-01-02 0:27 ` Yuan Fu
2023-01-08 0:06 ` Yuan Fu
2023-01-08 7:05 ` Knut Anders Hatlen
2023-01-17 9:39 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CF91E69-4784-4735-AECA-251901322018@gmail.com \
--to=casouri@gmail.com \
--cc=60397-done@debbugs.gnu.org \
--cc=kahatlen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.