From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 0724c6dbdae: Use string-search instead of string-match[-p] when possible Date: Wed, 29 Mar 2023 17:34:36 +0200 Message-ID: <8C045DB0-F4B5-4469-8BA6-F838F6DBE755@acm.org> References: <167982767456.13549.3313290435008922358@vcs2.savannah.gnu.org> <20230326104755.356B1C1391D@vcs2.savannah.gnu.org> <875yajmvjc.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34017"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 29 17:35:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phXph-0008a0-S8 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Mar 2023 17:35:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phXp5-0004RG-0F; Wed, 29 Mar 2023 11:34:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phXp2-0004KY-5u for emacs-devel@gnu.org; Wed, 29 Mar 2023 11:34:48 -0400 Original-Received: from mail1464c50.megamailservers.eu ([91.136.14.64] helo=mail268c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phXp0-0000fN-2b for emacs-devel@gnu.org; Wed, 29 Mar 2023 11:34:47 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1680104079; bh=pDuvk0Ts/x4Aj3L49kXH10trFjQ7lwWNLCzQGZo9isA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=irV9OlStQwAcQV4tU/lrQXphtr4Jgt0fIQnD6l2RYfJNhUC0QkLIXv56cHC8Eaz2T otFvFmUPR4HLf/XcvlMtyXINW61KEas3qEzYodUOJJzvRfCEX6oPmiIk+DIAnUGUa4 5wKjR8p487v640Of9KBIueZ7CxmE8MQfo8HiJ9QA= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 32TFYa0f094291; Wed, 29 Mar 2023 15:34:38 +0000 In-Reply-To: <875yajmvjc.fsf@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.14) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehiedgleduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepveekffdujefhkeehvdfgffeikefghfefvdekueffleegfeekueelhfejieefkefgnecukfhppedukeekrdduhedtrdduieehrddvfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudeihedrvdefhedphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepvddprhgtphhtthhopehrphhluhhimhesghhmrghilhdrtghomhdprhgtphhtthhopegvmhgrtghsqdguvghvvghlsehgnhhurdhorhhg X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.64; envelope-from=mattiase@acm.org; helo=mail268c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304822 Archived-At: 29 mars 2023 kl. 17.23 skrev Robert Pluim : > Hmm, we could do this using a compiler macro, no? Something like >=20 > (put 'string-match-p 'compiler-macro > #'byte-optimize-string-match-p) No, that would be incorrect: string-match-p obeys case-fold-search, = string-search doesn't. Replacing string-match[-p] with string-search in the source also makes = the code clearer.