From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Stylistic changes to tree-sitter code Date: Thu, 27 Oct 2022 21:14:48 -0700 Message-ID: <8BD3AD59-DE34-4434-9912-BA33515BFC6B@gmail.com> References: <87h6zp75nt.fsf.ref@yahoo.com> <87h6zp75nt.fsf@yahoo.com> <87h6zptloj.fsf@gmail.com> <87y1t06apv.fsf@yahoo.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31229"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , "Po Lu via Emacs development discussions." To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 06:21:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooGsL-0007zp-It for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 06:21:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooGon-0005PQ-SA; Fri, 28 Oct 2022 00:18:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooGln-0004Ou-CB for emacs-devel@gnu.org; Fri, 28 Oct 2022 00:14:59 -0400 Original-Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooGlg-0004ST-So for emacs-devel@gnu.org; Fri, 28 Oct 2022 00:14:59 -0400 Original-Received: by mail-pj1-x102c.google.com with SMTP id o7so471718pjj.1 for ; Thu, 27 Oct 2022 21:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2n1mtHbRq8eDcY7MxGN8ldvAdlNRIgMG3q4y7sJsDec=; b=XmbSA/MlrZq3rb0QqmbSnS2L8PWuJ14JA9XDULa0KiDjaa4F7ekCl+xI2CkoVWkt8R 1olU+NB96w3kcbL2GFGBW1RZkaQplmECM33eXbxLI1JqnDlS44ZRA7Tw9Z6EAKmxucw1 rSpmcxF8P90sEkeTnrII//jDgal3/dyaRNM9JAMDJFnxg9EginVlGp73Surj4nJL8sdG +XsKWsV7Xjz70zc77gVgT36m8d3gjmaKIj1SB46L71pM4IioM7HkW7qaYO+I+wc2QiM0 iIhSGgLkJQAuMn0xV+7HHrH0nOASrHszBvMrR+eNlrLW4thdKp7W/XzRAAg2PiqKUwYr sZpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2n1mtHbRq8eDcY7MxGN8ldvAdlNRIgMG3q4y7sJsDec=; b=0+E77yN36LH9kQeY2VsHHkTFwjBxbF4SrteNvYDDMoeaw7g/73C4rNEX5Fy96bAnuE Sq72doYzZVRdBjBEgOCW8tzxu6pAKh/d4G/uEKfMnm1vRwb+157sSyf4rRslSOp7n0E0 r7KvTzbIEz6e0hNZbxcK3gzDhyMZOHaNckEemOzonBpggvE5R5Gird6r2UOjq7g80WFr EW36YQmFLkLeCQsRfVh+YMWKqZeuMyZjEQ16pNBJO5DxP7yWAV1LrXuoPWCNTopE3uQK 9BOrIxERQtuvdInm9+rvKDgqAwzsptyUnjEzIK20ZQXnXw/HGqlWZOyYcI1SES9DRT5W QmOg== X-Gm-Message-State: ACrzQf3QnMQ0Dp7JI7zNCE2MJVYRDnKFPH5kSVB5S8dgOxeFNJH0hf0j IX6Ij8v34bpPIWmdtvMt34w= X-Google-Smtp-Source: AMsMyM6l8z00+1/StD4B5mbH7A7L9JSfxHYkRXiDNR85SG4TZ5e2QkCem/C+kkeH4nwa5i9uNrPdkg== X-Received: by 2002:a17:902:ef4c:b0:186:6399:6b48 with SMTP id e12-20020a170902ef4c00b0018663996b48mr43285521plx.128.1666930489965; Thu, 27 Oct 2022 21:14:49 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x15-20020a17090a46cf00b0020a0571b354sm1654109pjg.57.2022.10.27.21.14.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2022 21:14:49 -0700 (PDT) In-Reply-To: <87y1t06apv.fsf@yahoo.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=casouri@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298651 Archived-At: > On Oct 27, 2022, at 5:41 PM, Po Lu via Emacs development discussions. = wrote: >=20 > Robert Pluim writes: >=20 >>>>>>> On Thu, 27 Oct 2022 21:33:10 +0800, Po Lu via "Emacs development = discussions." said: >>=20 >>=20 >> Po Lu> Unfortunately, I don't have tree-sitter installed, so would = someone >> Po Lu> please do a smoke test on the changes before I install = them? >>=20 >> I have it installed, but I don=CA=BCt use it yet, so all I can offer = is a >> compile test: >>=20 >> CC treesit.o >> treesit.c: In function =E2=80=98treesit_find_override_name=E2=80=99: >> treesit.c:467:41: error: =E2=80=98list=E2=80=99 undeclared (first use = in this function); did you mean =E2=80=98listn=E2=80=99? >> 467 | *name =3D Fnth (make_fixnum (1), XCAR (list)); >> | ^~~~ >> | listn >> treesit.c:467:41: note: each undeclared identifier is reported only = once for each function it appears in >> treesit.c:476:57: error: expected =E2=80=98;=E2=80=99 before = =E2=80=98return=E2=80=99 >> 476 | CHECK_LIST_END (tem, Vtreesit_load_name_override_list) >> | ^ >> | ; >> 477 |=20 >> 478 | return false; >> | ~~~~~~ =20 >> treesit.c: In function =E2=80=98treesit_load_language=E2=80=99: >> treesit.c:555:15: error: redeclaration of =E2=80=98tail=E2=80=99 with = no linkage >> 555 | Lisp_Object tail; >> | ^~~~ >> treesit.c:539:15: note: previous declaration of =E2=80=98tail=E2=80=99 = was here >> 539 | Lisp_Object tail; >> | ^~~~ >> treesit.c: In function =E2=80=98treesit_find_override_name=E2=80=99: >> treesit.c:479:1: warning: control reaches end of non-void function = [-Wreturn-type] >> 479 | } >> | ^ >> make[2]: *** [Makefile:424: treesit.o] Error 1 >>=20 >> Robert >=20 > Thanks. What about this patch? Thanks for your work! I don=E2=80=99t have opinions on stylistic changes = :-) Yuan=