From: "Drew Adams" <drew.adams@oracle.com>
To: "'martin rudalics'" <rudalics@gmx.at>
Cc: 4293@emacsbugs.donarmstrong.com
Subject: bug#4293: 23.1; use pop-to-buffer, not switch...other-window, in bookmark.el
Date: Wed, 2 Sep 2009 09:16:26 -0700 [thread overview]
Message-ID: <8BA10FD9BFF44AD3BDCE2184D7577DF9@us.oracle.com> (raw)
In-Reply-To: <4A9E9387.5010106@gmx.at>
> >> I'm not sure what the problem is here.
> >> `switch-to-buffer-other-window'
> >> has a clear purpose - do _not reuse the selected window_
> >> (which is the bookmarks window, IIUC). OTOH
> >> `display-buffer-reuse-frames' non-nil
> >> should assure that another frame is reused.
> >
> > Users should not have to customize a global variable, to
> > prevent a new frame from being used in particular places like this.
>
> I thought you wanted to avoid popping up a new frame. At
> least in your first mail you said "pop-to-buffer DTRT:
> it reuses the existing frame".
I do. With pop-up-frames = t, and with a frame alteady showing buffer foo,
(switch-to-buffer-other-window 'foo) opens a *new*, additional frame to show
foo. That's the bug. pop-to-buffer instead simply navigates to the existing
frame, selecting buffer foo there.
> > As Stefan says repeatedly (paraphrasing),
> > switch-to-buffer-other-window is almost always the wrong
> > thing to do, and should be replaced in most places by
> > pop-to-buffer.
> >
> > Use of switch-to-buffer-other-window is a bug in general,
> > typically made by someone who doesn't use non-nil pop-up-frames.
> >
> > In this particular context, there is no reason to use
> > switch-to-buffer-other-frame.
>
> If you have `display-buffer-reuse-frames' set to nil, `pop-to-buffer'
> will not reuse another frame displaying that buffer either.
Right. This is for the case when it is set to non-nil. For the nil case, I
imagine that there is not much difference between pop-to-buffer and
switch-to-buffer-other-window (but I don't know, as I've always set it to t).
(In fact, I set both display-buffer-reuse-frames and the obsolete (?)
display-buffer-reuse-frame to t, just in case. ;-))
I expect that most people who use non-nil pop-up-frames set
display-buffer-reuse-frames to t (but I don't know that for a fact).
> Please tell which specific detail of `switch-to-buffer-other-window'
> you dislike in the present use case.
Opening a new frame for the buffer, when there is already an existing frame
showing it. In the present use case (and in most use cases), that is uncalled
for.
Context: non-nil pop-up-frames, non-nil display-buffer-reuse-frames.
pop-to-buffer DTRT; switch-to-buffer-other-window does not.
(No, we don't want to change the behavior of switch-to-buffer-other-window; that
command has its uses. It's just that most or many of the existing calls of
switch-to-buffer-other-window should really be calls of pop-to-buffer.)
> Note: It can't be the `other-window' argument,
> because in that case we'd have to change the names of the respective
> bookmark functions.
Sorry, I don't what you're saying, there.
It's pretty simple, really: When I want to go to a bookmark in another
window/frame (which is most of the time I want to go to a bookmark), I don't
want to create a new frame for that destination buffer - I just want to go to
the frame that's already showing it. Imagine hitting the key to go back to that
bookmark several times, off and on over a period of time. You would end up with
lots of frames showing that same buffer. Silly.
Thx.
next prev parent reply other threads:[~2009-09-02 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87skdymwe0.fsf@red-bean.com>
2009-08-30 14:52 ` bug#4293: 23.1; use pop-to-buffer, not switch...other-window, in bookmark.el Drew Adams
2009-09-02 9:58 ` martin rudalics
2009-09-02 14:39 ` Drew Adams
2009-09-02 15:47 ` martin rudalics
2009-09-02 16:16 ` Drew Adams [this message]
2009-09-02 16:45 ` martin rudalics
2009-09-02 17:56 ` Drew Adams
2009-09-02 21:22 ` Stefan Monnier
2009-09-02 21:29 ` Drew Adams
2009-10-05 2:10 ` bug#4293: marked as done (23.1; use pop-to-buffer, not switch...other-window, in bookmark.el) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8BA10FD9BFF44AD3BDCE2184D7577DF9@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=4293@emacsbugs.donarmstrong.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.