Buguette in `org-context'

Buguette in `org-context'

[Michael Sperber]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]


`org-context' fails if called at the beginning of a buffer.  I think the
reason is a call to `eobp' that wants to be a call to `bobp'.

This buguette actually has serious consequences at least on XEmacs:
`org-context' is called off the menubar construction, and if that fails,
XEmacs crashes.

(Try typing C-c C-s at the very beginning of an org-mode buffer.)

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla

[-- Attachment #2: Type: text/plain, Size: 883 bytes --]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 25be313..c3db38c 100755
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2009-10-01  Mike Sperber  <mike@xemacs.org>
+
+	* org.el (org-context): Replace an (eobp) by (bobp) that was
+	probably intended.
+
 2009-09-28  Carsten Dominik  <carsten.dominik@gmail.com>
 
 	* org.el (org-ctrl-c-ctrl-c): Pass prefix arg to
diff --git a/lisp/org.el b/lisp/org.el
index bde12b1..cc3a5e1 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16007,7 +16007,7 @@ and :keyword."
 	(push (org-point-in-group p 2 :todo-keyword) clist)
 	(push (org-point-in-group p 4 :tags) clist))
       (goto-char p)
-      (skip-chars-backward "^[\n\r \t") (or (eobp) (backward-char 1))
+      (skip-chars-backward "^[\n\r \t") (or (bobp) (backward-char 1))
       (if (looking-at "\\[#[A-Z0-9]\\]")
 	  (push (org-point-in-group p 0 :priority) clist)))
 

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Buguette in `org-context'

[Carsten Dominik]

Applied, thanks.

- Carsten

On Oct 1, 2009, at 6:33 PM, Michael Sperber wrote:

>
> `org-context' fails if called at the beginning of a buffer.  I think  
> the
> reason is a call to `eobp' that wants to be a call to `bobp'.
>
> This buguette actually has serious consequences at least on XEmacs:
> `org-context' is called off the menubar construction, and if that  
> fails,
> XEmacs crashes.
>
> (Try typing C-c C-s at the very beginning of an org-mode buffer.)
>
> -- 
> Cheers =8-} Mike
> Friede, Völkerverständigung und überhaupt blabla
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index 25be313..c3db38c 100755
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -1,3 +1,8 @@
> +2009-10-01  Mike Sperber  <mike@xemacs.org>
> +
> +	* org.el (org-context): Replace an (eobp) by (bobp) that was
> +	probably intended.
> +
> 2009-09-28  Carsten Dominik  <carsten.dominik@gmail.com>
>
> 	* org.el (org-ctrl-c-ctrl-c): Pass prefix arg to
> diff --git a/lisp/org.el b/lisp/org.el
> index bde12b1..cc3a5e1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -16007,7 +16007,7 @@ and :keyword."
> 	(push (org-point-in-group p 2 :todo-keyword) clist)
> 	(push (org-point-in-group p 4 :tags) clist))
>       (goto-char p)
> -      (skip-chars-backward "^[\n\r \t") (or (eobp) (backward-char 1))
> +      (skip-chars-backward "^[\n\r \t") (or (bobp) (backward-char 1))
>       (if (looking-at "\\[#[A-Z0-9]\\]")
> 	  (push (org-point-in-group p 0 :priority) clist)))
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode