all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Devon Sean McCullough <Emacs-Hacker2018@jovi.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 36727@debbugs.gnu.org
Subject: bug#36727: 27.0.50; indent bug
Date: Thu, 10 Oct 2019 11:40:06 +0800	[thread overview]
Message-ID: <8AC2B0A5-22FF-412D-8C57-6C4D46A70D6C@jovi.net> (raw)
In-Reply-To: <87y2xtsc0t.fsf@gnus.org>

> On Oct 10, 2019, at 8:02 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> 
> Devon Sean McCullough <Emacs-Hacker2018@jovi.net> writes:
> 
>> (assert (progn
>> 	  Indentation) nil
>> 	  "<-- should line up with progn.")
>> 
>> In emacs-lisp-mode, both indent-pp-sexp and indent-for-tab-command
>> indent this incorrectly as above (string lines up with capital letter I)
>> instead of correctly as below (string lines up with progn’s open paren)
>> 
>> (assert (progn
>> 	  Indentation) nil
>> 	"<-- should line up with progn.")
> 
> emacs-lisp-mode also flags that `nil' with a warning face -- because
> this isn't a style that's recommended.
> 
> So I don't know whether fixing up indentation in code that's already
> badly formatted is something we want to do.  Any opinions?

Such indentation failures will conceal errors which proper indentation would highlight.
Any indenter capable of such mistakes is almost certainly buggy in many other ways.

		Peace
			—Devon

P.S. Is it worth time and attention to fix any time soon?
It’s been decades since I got paid to maintain Emacs
so I have no way to judge that.  Machine learning
may offer better ways to weigh code beauty.




  reply	other threads:[~2019-10-10  3:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19  5:02 bug#36727: 27.0.50; indent bug Devon Sean McCullough
2019-10-10  0:02 ` Lars Ingebrigtsen
2019-10-10  3:40   ` Devon Sean McCullough [this message]
2019-10-11  7:39     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8AC2B0A5-22FF-412D-8C57-6C4D46A70D6C@jovi.net \
    --to=emacs-hacker2018@jovi.net \
    --cc=36727@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.