From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Rami_Ylim=c3=a4ki?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Support 24-bit terminal colors. Date: Sun, 4 Sep 2016 19:44:56 +0300 Message-ID: <89e74ba9-9a89-c93f-4ab4-815fdf1f9179@iki.fi> References: <1472587906-29711-1-git-send-email-rjy@iki.fi> <83wpixkoi8.fsf@gnu.org> <8824d67d-dc71-0d2a-3a1f-a20a018e360c@porkrind.org> <83poojd9zc.fsf@gnu.org> Reply-To: =?UTF-8?Q?Rami_Ylim=c3=a4ki?= NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1473007562 5829 195.159.176.226 (4 Sep 2016 16:46:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Sep 2016 16:46:02 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Cc: emacs-devel@gnu.org, david@porkrind.org To: Eli Zaretskii , Yuri Khan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 04 18:45:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgaYN-0000id-9e for ged-emacs-devel@m.gmane.org; Sun, 04 Sep 2016 18:45:55 +0200 Original-Received: from localhost ([::1]:50557 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgaYK-0006PC-U3 for ged-emacs-devel@m.gmane.org; Sun, 04 Sep 2016 12:45:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgaXk-0006Oz-JU for emacs-devel@gnu.org; Sun, 04 Sep 2016 12:45:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgaXg-0003hP-9K for emacs-devel@gnu.org; Sun, 04 Sep 2016 12:45:15 -0400 Original-Received: from mail.kapsi.fi ([217.30.184.167]:34985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgaXg-0003cH-2T; Sun, 04 Sep 2016 12:45:12 -0400 Original-Received: from 91-158-222-159.elisa-laajakaista.fi ([91.158.222.159] helo=nopsakone.home) by mail.kapsi.fi with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1bgaXQ-0007ch-V9; Sun, 04 Sep 2016 19:44:56 +0300 In-Reply-To: <83poojd9zc.fsf@gnu.org> X-SA-Exim-Connect-IP: 91.158.222.159 X-SA-Exim-Mail-From: rjy@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.30.184.167 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207179 Archived-At: On 04.09.2016 17:18, Eli Zaretskii wrote: >> From: Yuri Khan >> Date: Sun, 4 Sep 2016 14:11:22 +0600 >> Cc: Eli Zaretskii , Rami Ylimäki , >> Emacs developers >> >> The spec says parameters for the SGR 38 and 48 codes are delimited by >> colons, but many terminals accept semicolons. > Do all of them also accept colons? If they do, I think we should use > colons. (The patch used semicolons.) > According to https://gist.github.com/XVilka/8346728, semicolon separator is supported by (almost?) all 24-bit terminals, whereas some 24-bit terminals don't support colon. I'd use semicolon separator to support as many terminals as possible.