Re: master 9076a63 1/3: Port to Solaris 10

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

On 1/4/21 8:08 AM, Andrea Corallo wrote:
>    CCLD     temacs
> /usr/bin/ld: xterm.o: undefined reference to symbol 'XRenderQueryExtension'
> //usr/lib/x86_64-linux-gnu/libXrender.so.1: error adding symbols: DSO missing from command line
> collect2: error: ld returned 1 exit status
> Makefile:655: recipe for target 'temacs' failed
> ========
> 
> We don't add -lXrender.  I do have "X11/extensions/Xrender.h" but not
> "X11/Intrinsic.h".

Isn't it odd to have the development environment for X11 extensions 
installed, but not that for base X11?

Still, Emacs should work if Xrender is absent while Cairo is present. I 
installed the attached patch to try to do that; please let us know if it 
works for you.

[-- Attachment #2: 0001-Do-not-assume-Xrender-merely-because-Cairo.patch --]
[-- Type: text/x-patch, Size: 1211 bytes --]

From ec35298e7f12d5aa86b79bcf5a6517ecc7414d74 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 4 Jan 2021 10:33:43 -0800
Subject: [PATCH] Do not assume Xrender merely because Cairo

Problem reported by Andrea Corallo in:
https://lists.gnu.org/r/emacs-devel/2021-01/msg00225.html
* src/xterm.c (x_term_init) [USE_CAIRO && !HAVE_XRENDER]:
Do not call XRenderQueryExtension.
---
 src/xterm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/xterm.c b/src/xterm.c
index 0a86738cc2..b8374fed8b 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -13035,13 +13035,13 @@ #define NUM_ARGV 10
        or larger than other for other applications, even if it is the same
        font name (monospace-10 for example).  */
 
+# ifdef HAVE_XRENDER
     int event_base, error_base;
-    char *v;
-    double d;
-
     XRenderQueryExtension (dpyinfo->display, &event_base, &error_base);
+# endif
 
-    v = XGetDefault (dpyinfo->display, "Xft", "dpi");
+    char *v = XGetDefault (dpyinfo->display, "Xft", "dpi");
+    double d;
     if (v != NULL && sscanf (v, "%lf", &d) == 1)
       dpyinfo->resy = dpyinfo->resx = d;
   }
-- 
2.27.0