From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72019: [PATCH] Add project argument to project-kill-buffers Date: Thu, 11 Jul 2024 22:47:57 +0300 Message-ID: <8935da89-8354-491b-9ee4-c76a26cea932@gutov.dev> References: <86ed81o5oc.fsf@gnu.org> <8634ohnwpz.fsf@gnu.org> <86zfqpm9ur.fsf@gnu.org> <86v81dm8te.fsf@gnu.org> <86sewhm5ri.fsf@gnu.org> <5c12905c-370e-419b-8ff1-657341da68cf@gutov.dev> <86jzhsmswn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16973"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: sbaugh@janestreet.com, 72019@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 11 21:49:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRzn4-0004DK-TP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jul 2024 21:49:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRzmq-0008Lo-Ki; Thu, 11 Jul 2024 15:49:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRzmo-0008LP-OI for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 15:49:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRzmo-0007uw-Dr for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 15:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRzmo-0001KN-5j for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 15:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 19:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72019-submit@debbugs.gnu.org id=B72019.17207272865024 (code B ref 72019); Thu, 11 Jul 2024 19:49:02 +0000 Original-Received: (at 72019) by debbugs.gnu.org; 11 Jul 2024 19:48:06 +0000 Original-Received: from localhost ([127.0.0.1]:52611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRzlu-0001Iy-AT for submit@debbugs.gnu.org; Thu, 11 Jul 2024 15:48:06 -0400 Original-Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:60727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRzls-0001IS-Sk for 72019@debbugs.gnu.org; Thu, 11 Jul 2024 15:48:05 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id E47881381181; Thu, 11 Jul 2024 15:47:59 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 11 Jul 2024 15:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1720727279; x=1720813679; bh=DkLCKkT96aemKgm3cu4yFix3JgnT9skSrYjop8ARuzc=; b= r9cftYlaJzkTnydvQ9tRH8opHCRPZ/yh2kYUfgEyCuOYR+ejmC6mUS6aP/QyasIZ 34UQxTKFmt9gQQSUfQMfO3xNZfm8rV9zQbL27q1HmZAS2cZou7xZ7Sh9T6X+t7vP x8zSsB7bqcnQSwL1QScwa4Ndnq4ZC5MyIlVI3USYMQXzJ3dHUXIsefWwHiCOrZFK JdRSoJ/t0htUwAcbGsbJDsc4k+gC0YljJtR/PoebEFbWS5oiQgf6JIXSeqEw+tpw hgpBZv2QkCq4fgOg96Ywx01sE9ZC3kMRq+7V3yMQibljLD6j/8hYPokxmM4Xl2wz tLZ6QW2nj2ohwBPpBiTTHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720727279; x= 1720813679; bh=DkLCKkT96aemKgm3cu4yFix3JgnT9skSrYjop8ARuzc=; b=D QEPIzZTC0c48VKYBap5xDfHHvtsERFhIuOIpwtrghnhcJPkHk/Um6x/jZQjWNm7I fmtKNycHKGi07AEO8iA8vrCewmIFtGXAZexpMXTQf0K92pr7jh38R9ZVp/uPaGnR TVbWvYeHD6eSP1n4Cl55EXLimQE9tJmYrwWTKA9HpEkrEQusV9VKvL3Vv+q6xfWD /skPJMGZY4Q8LWbWTJ0F9vW5HJh64sGbTN3DIN0aO1vxWxaZTwYPg9mv8EUWuPrF 47zd2YyJe1k57tmN0R9WGiJ9rGNkUP/jmsTJNQ8ODCQydsDR7ttemFqX/3jSl6jZ Ff+ruQn06FxiCx9uwVNRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrfeeggddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Jul 2024 15:47:58 -0400 (EDT) Content-Language: en-US In-Reply-To: <86jzhsmswn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288747 Archived-At: On 11/07/2024 07:52, Eli Zaretskii wrote: >> For project-kill-buffers in particular it seems like a real advantage - >> getting to clean up buffers belonging to an already deleted project. And >> if one step 2 or 3 fails with an error, oh well, it doesn't seem like we >> could have done better. > > My question for this scenario would be: does project.el support it in > general? I'd expect quite a few of the functions to rely on the fact > that the project directory is there, in which case this is the tip of > a very large iceberg. I'm not sure. Hence I'm not announcing a big switchover for every command, or anything like that. But the command "kill all buffers" seems like a very good fit for a project that's not there anymore. > But you know the code and the design much better than I do, so if it > makes sense to you, fine. This particular decision is ad-hoc, but it does seem like it has no or very little drawbacks. Let me know if it's okay for emacs-30, or we should postpone it to master.