From: Paul Eggert <eggert@cs.ucla.edu>
To: Pip Cet <pipcet@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master b467bb5 4/4: Minimize ‘equal’ calls in (delete x vector)
Date: Sat, 15 Aug 2020 17:49:22 -0700 [thread overview]
Message-ID: <8904271d-e963-b2c0-1198-3e06cb9a06c1@cs.ucla.edu> (raw)
In-Reply-To: <CAOqdjBfw4OE+3za4s0jhxkVoRz9P5DNMoPzvTdGqNONmBksTkg@mail.gmail.com>
On 8/15/20 1:21 PM, Pip Cet wrote:
> Looks correct, but establishes a rather questionable precedent of
> putting Lisp_Objects in SAFE_ALLOCA'd space. That's okay in this
> specific case, for a number of reasons, but it's bound to be copied by
> someone in circumstances where it's not :-)
It's not unprecedented, as there's one other instance of this, in
font_sort_entities. Admittedly it's unusual; feel free to add a comment.
>> It does bug me a bit that GCC generates bad code for 'NILP (Fequal (...))' here.
>> I've been meaning to add a bool function equal (...) that would simplify the C
>> source a bit and presumably let GCC do better, but that can wait.
>
> What's GCC doing, for you?
It's doing some weird thing involving cmp + adc. On second thought it's probably
fine, as it is branch-free. Still, I always get confused when I write "!NILP
(Fequal (a, b)' and too often I get it wrong. I'd rather write 'equal (a, b)'.
prev parent reply other threads:[~2020-08-16 0:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200815181956.27401.76683@vcs0.savannah.gnu.org>
[not found] ` <20200815181959.E7DC3209AC@vcs0.savannah.gnu.org>
2020-08-15 19:00 ` master b467bb5 4/4: Minimize ‘equal’ calls in (delete x vector) Pip Cet
2020-08-15 19:22 ` Pip Cet
2020-08-15 19:42 ` Paul Eggert
2020-08-15 20:21 ` Pip Cet
2020-08-16 0:49 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8904271d-e963-b2c0-1198-3e06cb9a06c1@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.