From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Tue, 26 Mar 2024 08:33:22 -0700 Message-ID: <88fb732b480d7a33ed1464d40127c3fc@finder.org> References: <6c2e5fe5d3439f0a3696f86bd99bbb7b@finder.org> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31651"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68765@debbugs.gnu.org To: Philip Kaludercic , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 26 16:34:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rp8om-00080e-Rb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Mar 2024 16:34:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rp8oi-00018U-0p; Tue, 26 Mar 2024 11:34:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rp8oV-00012I-Ic for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 11:34:17 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rp8oN-0006KA-1C for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 11:34:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rp8oM-00026O-As for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 11:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Mar 2024 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68765 X-GNU-PR-Package: emacs Original-Received: via spool by 68765-submit@debbugs.gnu.org id=B68765.17114672068014 (code B ref 68765); Tue, 26 Mar 2024 15:34:02 +0000 Original-Received: (at 68765) by debbugs.gnu.org; 26 Mar 2024 15:33:26 +0000 Original-Received: from localhost ([127.0.0.1]:34476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp8nl-00025C-Pp for submit@debbugs.gnu.org; Tue, 26 Mar 2024 11:33:26 -0400 Original-Received: from greenhill.hpalace.com ([192.155.80.58]:53426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp8nj-000253-Fa for 68765@debbugs.gnu.org; Tue, 26 Mar 2024 11:33:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1711467202; bh=4MOY4Odpfb9u4e4FaVSU557ZMK3kvgHotoZKqOmOIn0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dK8Bh9WaDt9ZAKTdG2spFX91z9Dvse82FGTxp42RR89x4mWTuxdhyYvR1v68fKt8C 8tMBxqGf2j+qhW7CcEV/JGfY5ykOU1hLTGxARUsjB8w0i1zdJgtMxTL2Z8utnCpaP/ 4atkbRuhuhTPXd+kzZ48BBm6RXrw5EGYAI0l9kplsVypGynrgXPHTjJFeTX7vIVW49 CUSHeF5Ftgmh663JQ4MP4peIh2pvrPeUKbOYCdsmkIWthjjQt88cxGuaFaEQBOq00z dpGlfJagHqXSMnatWyH3xR3r5LYSjGgF9/WKhAfwjrOQbECuCrF0rPmVu2ZHkuw0Cc rsbOHTm5w+3RQ== Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id D9A2760A; Tue, 26 Mar 2024 15:33:22 +0000 (UTC) In-Reply-To: <6c2e5fe5d3439f0a3696f86bd99bbb7b@finder.org> X-Sender: jared@finder.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282091 Archived-At: It's been four weeks and I've seen no reply to these updated patches. Are you able to review? On 2024-02-26 19:02, Jared Finder wrote: > On 2024-02-11 12:51, Philip Kaludercic wrote: >> Here are a few comments from a quick skim: > > Comments addressed. New patches for 0002 and 0003 added. I also > addressed Eli's comments from > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68765#10 as well. > > The following comment was not addressed: > >>> +(defun window-tool-bar-show-memory-use () >>> + "Pop up a window showing the memory use metrics." >>> + (interactive) >>> + (require 'time-stamp) >>> + (save-selected-window >>> + (pop-to-buffer "*WTB Memory Report*") >> >> I think you should rewrite this as >> >> (with-current-buffer (get-buffer "...") >> ;; ... >> (pop-to-buffer (current-buffer)) > > I couldn't make this change and keep the current behavior that is > important to me: > > 1. The window with focus should not change. > 2. The buffer should get scrolled to the bottom to displayed the newly > inserted text. > > -- MJF