From: Davin Pearson <davin.pearson@gmail.com>
To: help-gnu-emacs@gnu.org
Subject: Re: Crappyness of Emacs Version 24.5.1 defadvice
Date: Wed, 29 Jun 2016 00:01:13 -0700 (PDT) [thread overview]
Message-ID: <88afb09b-caa5-47ec-ba99-8278072271a2@googlegroups.com> (raw)
In-Reply-To: <mailman.260.1467165391.26859.help-gnu-emacs@gnu.org>
On Wednesday, June 29, 2016 at 1:56:33 PM UTC+12, Michael Heerdegen wrote:
> Davin Pearson writes:
>
> > I tried the following code but it doesn't work.
> >
> > (advice-add 'describe-mode
> > :around
> > #'(lambda () (delete-other-windows) ad-do-it)
> > )
>
> There is no `ad-do-it' pseudo variable/whatever in nadvice anymore. The
> functions that are used as a piece of advice are simply called - and
> how tells the doc of `add-function', or the manual.
>
> > Worse still, it brings up the following message when I try C-h f
> > describe-mode RET
> >
> > :around advice: No documentation
> >
> > Where do I add the documentation to the advice mechanism?
>
> Document the function that "is" the advice.
>
>
> Michael.
Thanks for your helpful advice. I use defadvice a lot and I am still unsure why Stephen Monier removed that feature.
next prev parent reply other threads:[~2016-06-29 7:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 5:46 Crappyness of Emacs Version 24.5.1 defadvice Davin Pearson
2016-06-28 5:58 ` Davin Pearson
2016-06-28 11:11 ` Dmitry Gutov
2016-06-28 12:59 ` Michael Heerdegen
2016-06-28 14:21 ` Drew Adams
[not found] ` <mailman.239.1467123719.26859.help-gnu-emacs@gnu.org>
2016-06-29 1:48 ` Davin Pearson
2016-06-29 1:55 ` Michael Heerdegen
[not found] ` <mailman.260.1467165391.26859.help-gnu-emacs@gnu.org>
2016-06-29 7:01 ` Davin Pearson [this message]
2016-06-29 9:02 ` Alexis
2016-06-29 7:05 ` Davin Pearson
2016-06-30 12:46 ` Michael Heerdegen
[not found] ` <mailman.320.1467290787.26859.help-gnu-emacs@gnu.org>
2016-06-30 13:09 ` Joost Kremers
2016-06-30 21:16 ` Michael Heerdegen
2016-06-29 13:54 ` Rémi Vanicat
2016-06-30 12:43 ` Michael Heerdegen
2016-07-01 11:39 ` Fwd: " Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88afb09b-caa5-47ec-ba99-8278072271a2@googlegroups.com \
--to=davin.pearson@gmail.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.