From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Date: Tue, 28 May 2019 07:40:39 +0300 Message-ID: <88F01F35-BE24-4F6E-B832-64AFE28CD06B@gnu.org> References: <20190525191039.14136.23307@vcs0.savannah.gnu.org> <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="105130"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android To: emacs-devel@gnu.org,Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 28 06:41:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVTv1-000REW-QZ for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 06:40:59 +0200 Original-Received: from localhost ([127.0.0.1]:57078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVTv0-0007aF-Ff for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 00:40:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVTup-0007YJ-Mz for emacs-devel@gnu.org; Tue, 28 May 2019 00:40:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVTuo-0001rS-OB; Tue, 28 May 2019 00:40:46 -0400 Original-Received: from [176.12.139.251] (port=53324 helo=[10.163.36.4]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hVTuk-0000YA-Qv; Tue, 28 May 2019 00:40:44 -0400 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237074 Archived-At: On May 28, 2019 6:08:36 AM GMT+03:00, Stefan Monnier wrote: > and according to my quick investigation, all callers pass a string > that's coming straight from encode-coding-string or > encode-coding-char, > so the argument should *always* be unibyte, AFAICT=2E >=20 > Hence according to my reading of the code, this call to > string-as-unibyte will always just return its argument unchanged=2E That's not entirely true, because encode-coding-char can return a multibyt= e string=2E Depending on what you wanted to suggest based on your conclusi= on, that factoid may or may not be important=2E