From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Thu, 25 Apr 2019 20:07:38 +0200 Message-ID: <885067B4-4575-4138-A4B4-961C28BBAFF1@acm.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101474"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 25 20:10:52 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJipb-000Q8U-Fk for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 20:10:47 +0200 Original-Received: from localhost ([127.0.0.1]:33457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJipa-0001qb-Fp for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 14:10:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJimx-0000LR-Gw for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 14:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJimw-0008WJ-IM for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 14:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45744) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJimw-0008Vl-El for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 14:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJimw-0001lW-50 for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 14:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15562156686767 (code B ref 35418); Thu, 25 Apr 2019 18:08:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 25 Apr 2019 18:07:48 +0000 Original-Received: from localhost ([127.0.0.1]:59288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJimh-0001l4-RE for submit@debbugs.gnu.org; Thu, 25 Apr 2019 14:07:48 -0400 Original-Received: from mail151c50.megamailservers.eu ([91.136.10.161]:55556 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJime-0001ks-1V for 35418@debbugs.gnu.org; Thu, 25 Apr 2019 14:07:46 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556215661; bh=iQGlw9XkVwDUFQ3/OAwYuAqS4TmPq7Ki7rpddlFmbVk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=lYTIWXs5TyqZ6xJjEPgKqcimBKkvPa1us6ZwSKrPi9srm8wfJmTGxsxiJRJEVG/ly Rl5i2GU/j5oSIaTmGoLcrp62xEOPSq08T5fCZQzkdzEKKoklq5cpV8iWqF6yk5WuT6 x9nVKUeQOLaKO2evzmvwnYBUYMqcOps73ag1D1y0= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3PI7d8r020112; Thu, 25 Apr 2019 18:07:41 +0000 In-Reply-To: <83o94uz9h2.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0213.5CC1F76D.003C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NJb7BXyg c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=9uTWOIZngPFdP2rHn14A:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158260 Archived-At: 25 apr. 2019 kl. 12.04 skrev Eli Zaretskii : >=20 >> "^" (regexp-opt '("/afs/" "/media/" "/mnt" "/net/" "/tmp_mnt/")) >>=20 >> If that regexp is acceptable as rough heuristics on Unix, surely = something like the regexp proposed, matching \\SOMETHING\, shouldn't be = out of the question on Windows? Full precision cannot be attained, as = you point out, but perhaps we can make life easier for the user. >=20 > on Windows, SOMETHING is just the name of the machine which exports > the drive, it can be anything. Right, it's just a path to a file or directory on a mounted remote file = system. >> Are you arguing that the default value of = auto-revert-notify-exclude-dir-regexp should not be extended in the = proposed way, or that the variable is fundamentally incompatible with = the patch? >=20 > I'm questioning the usefulness of extending the default value, yes. > But I don't have strong views on that. Nor do I. It would avoid breaking auto-revert on some = non-auto-revert-capable remote file systems on Windows, at the cost of = increasing the auto-revert delay on some auto-revert-capable remote file = systems. The patch does not hinge on a change to the default value of that = variable. I forgot to mention that this patch should and will be accompanied by = appropriate NEWS and documentation updates, to be written.