From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Andrea Corallo <acorallo@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
Helmut Eller <eller.helmut@gmail.com>,
emacs-devel@gnu.org
Subject: Re: maphash
Date: Wed, 2 Oct 2024 10:43:52 +0200 [thread overview]
Message-ID: <88481AA6-D70B-4851-9CD8-337A9740F189@gmail.com> (raw)
In-Reply-To: <yp1ttdvwu02.fsf@fencepost.gnu.org>
1 okt. 2024 kl. 20.36 skrev Andrea Corallo <acorallo@gnu.org>:
>> Would you also take a look at the four DOHASH_SAFE uses in
>> comp.c, and see if there is any possibility of mutation of the tables
>> iterated over? Then they could be changed to DOHASH.
>
> Thanks I think the use of DOHASH_SAFE is correct there.
Mind explaining why? Note that DOHASH does attempt to catch some table mutations when checking is enabled.
DOHASH_SAFE is intended for Fmapcar, where there may be mutations and we mustn't crash because of them but we don't care about semantics in that case.
next prev parent reply other threads:[~2024-10-02 8:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 15:52 maphash Helmut Eller
2024-09-11 14:23 ` maphash Mattias Engdegård
2024-09-11 22:45 ` maphash Andrea Corallo
2024-09-28 8:42 ` maphash Eli Zaretskii
2024-09-30 14:29 ` maphash Andrea Corallo
2024-10-01 16:31 ` maphash Andrea Corallo
2024-10-01 16:59 ` maphash Mattias Engdegård
2024-10-01 18:36 ` maphash Andrea Corallo
2024-10-02 8:43 ` Mattias Engdegård [this message]
2024-10-03 11:18 ` maphash Andrea Corallo
2024-10-04 8:30 ` maphash Mattias Engdegård
[not found] <p04310100bac9ebec6275@[198.17.100.22]>
2003-04-24 1:51 ` maphash Richard Stallman
2003-04-24 7:46 ` maphash Stephen J. Turnbull
2003-04-24 21:58 ` maphash Greg Hill
2003-04-26 2:32 ` maphash Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88481AA6-D70B-4851-9CD8-337A9740F189@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=acorallo@gnu.org \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.