From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Gerd_M=c3=b6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Implementing image support for kitty terminal Date: Fri, 9 Sep 2022 16:27:30 +0200 Message-ID: <88387d9e-3717-fd62-9912-bfd571250033@gmail.com> References: <835yhwd3z4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Cc: tomas@tuxteam.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 09 16:29:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWf0N-000295-2C for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Sep 2022 16:29:15 +0200 Original-Received: from localhost ([::1]:35946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWf0L-0001VS-QD for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Sep 2022 10:29:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWeym-0008WU-9r for emacs-devel@gnu.org; Fri, 09 Sep 2022 10:27:36 -0400 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:42997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWeyk-0003mz-M3; Fri, 09 Sep 2022 10:27:36 -0400 Original-Received: by mail-ed1-x52e.google.com with SMTP id q21so2768459edc.9; Fri, 09 Sep 2022 07:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=AHTHaiMkkFkb3pJY6S7HDB6WoF0zMZT2pCGkbX8bOag=; b=c06EN+CYeRBjsF8wETSaU0fgTBfzCupU2d8s+ZLO6hMgfy4GCS/bXiN0AHyHEIUyBO 28WP0Sz2jkgzR0FoTj7+7bdluqvXU5MJr/EU+c2E/L5yYxWnpg9tXtFLGqGSTiSPqUz/ KI7x8CAeTVFuEaMo15VcMPBv7oJTDGu7E+PRaWVwKESUJgdQoBiEt4tScgI7jym1FxNd fLyc8M+wvMX1gsOd3bRhpW5cOOQg4UjwU4dXR5Y4qP510jPV6uIDJLw6NgmNF4TJiDly oyTk34iO1tVTn21wIyVfrV3DM6kEa6DI3qIMr2DXWGZceMi61Pu8Z9ZrcrV6lg7N6xhW px1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=AHTHaiMkkFkb3pJY6S7HDB6WoF0zMZT2pCGkbX8bOag=; b=RCziDRoFC2+m+o8k0aNGn9jjr06cGcLig8BQcR13HTCpwqSbQLqI4eo+b5kBA6gH4I L/CE3/2qO+Yzzlt8SR5T8+KxJu4sjOAT7GrCU5WON6A6MUFM+pND7CKYc1nuglWKzct3 q+8UdBXLs38HZVF6xQk5vUCgcZajVIqa6ffFqi6DbsUjdETFr9Ba1ErvkfLbOpoKhAwj H2gZ6ZOeb4ILo27gMoYbBGQbY+oe6Mw5L0+2qrStCghbbKHMcawjIruj7NI7OkHbioUP 5QDLDReauNSwphtHzwBuSyWgiFSoYE/BEFcmLcA2UZZoiBHiiHGB1BDuDuJABxIsh532 M0jw== X-Gm-Message-State: ACgBeo2iEf10fNc2h1YmLx17rSRb4alRFA4OiJPbN2lkBVCYlHBqMjgN NmUpJ/xRr6JJ1AEWZDKzfmqPMwaHL/NSSA== X-Google-Smtp-Source: AA6agR6Hv+ejtz302MSlQZKTi9CemioHIWLrQ51rCf/8HMIQi561mxW/FnSUyCi1modOfQmhWJhMuw== X-Received: by 2002:a05:6402:35d5:b0:43d:a02f:cbfb with SMTP id z21-20020a05640235d500b0043da02fcbfbmr11277977edc.275.1662733652513; Fri, 09 Sep 2022 07:27:32 -0700 (PDT) Original-Received: from [192.168.178.21] (pd9e36855.dip0.t-ipconnect.de. [217.227.104.85]) by smtp.gmail.com with ESMTPSA id pk21-20020a170906d7b500b0073923a68974sm312155ejb.206.2022.09.09.07.27.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 07:27:31 -0700 (PDT) Content-Language: en-US In-Reply-To: <835yhwd3z4.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-2.079, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295071 Archived-At: On 22-09-09 16:20 , Eli Zaretskii wrote: >> Date: Fri, 9 Sep 2022 16:10:07 +0200 >> Cc: emacs-devel@gnu.org >> From: Gerd Möllmann >> >> It wouldn't be hard to buffer the writes until the update is done, I >> think. > > I think we already do, see this part of update_frame_1: > > /* Now update the rest of the lines. */ > for (i = 0; i < desired_matrix->nrows - 1 && (force_p || !input_pending); i++) > { > if (MATRIX_ROW_ENABLED_P (desired_matrix, i)) > { > if (FRAME_TERMCAP_P (f)) > { > /* Flush out every so many lines. > Also flush out if likely to have more than 1k buffered > otherwise. I'm told that some telnet connections get > really screwed by more than 1k output at once. */ > FILE *display_output = FRAME_TTY (f)->output; > if (display_output) > { > ptrdiff_t outq = __fpending (display_output); > if (outq > 900 > || (outq > 20 && ((i - 1) % preempt_count == 0))) > fflush (display_output); > } > } Oh, right. The comment there is also interesting. Looks like some connections don't like larger buffers, some benefit from it, some don't care. Whatever we do, it's always wrong :-).