From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23179: 25.0.92; Restore `M-,' to continue etags search Date: Mon, 8 Apr 2019 02:07:51 +0300 Message-ID: <881b00bd-43bf-8755-5354-4eebd0c5f1e0@yandex.ru> References: <48066d7c-e4d3-acf5-fdcf-1aa9a108cb90@yandex.ru> <1554100819364-0.post@n8.nabble.com> <1554216459522-0.post@n8.nabble.com> <83mul8fn8d.fsf@gnu.org> <7d450c54-d4f5-b871-91e5-b00019ff323a@yandex.ru> <87pnpy6cau.fsf@mail.linkov.net> <32a0a910-772e-add8-0042-8a7faaea0eb7@yandex.ru> <87o95hzhm0.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188162"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0a1 Cc: 23179@debbugs.gnu.org, pklammer To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 08 01:09:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDGuW-000mny-6T for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 01:09:12 +0200 Original-Received: from localhost ([127.0.0.1]:44714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDGuU-0004PH-Le for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 19:09:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDGuN-0004PA-RB for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 19:09:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDGuM-0005Ef-ST for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 19:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDGuM-0005ER-Hx for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 19:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDGuM-0002cZ-8b for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 19:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2019 23:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23179 X-GNU-PR-Package: emacs Original-Received: via spool by 23179-submit@debbugs.gnu.org id=B23179.155467848410002 (code B ref 23179); Sun, 07 Apr 2019 23:09:02 +0000 Original-Received: (at 23179) by debbugs.gnu.org; 7 Apr 2019 23:08:04 +0000 Original-Received: from localhost ([127.0.0.1]:48839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDGtP-0002bG-QU for submit@debbugs.gnu.org; Sun, 07 Apr 2019 19:08:04 -0400 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:46837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDGtN-0002ak-Du for 23179@debbugs.gnu.org; Sun, 07 Apr 2019 19:08:01 -0400 Original-Received: by mail-lf1-f46.google.com with SMTP id r25so8015508lfn.13 for <23179@debbugs.gnu.org>; Sun, 07 Apr 2019 16:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=osgRVdWxjbcBo4SwCtw4kvql1MjGBzEzx82/FSdOrcs=; b=rT+/aNyr6TIfh4e0XacWS0CSJR0dctGhS3hwBv1UBnVBVFD1k5BaR58ELMAkWgn68F l/gcgS6XI0sry9vO/BTOSIb0Wa7pN43019SwNA4zs3W9YfbZnMwI2FUNA0v5AjxatTIR I8CdywPBrWb5s/nXaLy9gv4WPnUb73tEAC6YZC0OXkyFQdB2HX26Je3EUTZPtYuZmCrQ L4I3mthB29p32aG8aJbxhlknqUPB7Zg0kx6IpdGDiXse/IGmsBPzT1YL/WJciFaKBHLt V+xO95TYz739tO2ceWvbMF+7SG/Sj3F/vMQrUE8VyXoKLZKz5BvAVOkMJtiSo2sC58uH rS/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=osgRVdWxjbcBo4SwCtw4kvql1MjGBzEzx82/FSdOrcs=; b=ElPZq9b83hNwyQQioV09lnmF915LpOYRQb+TWygD9f62evqhFsVGGJ2OR3CFWfLVEy PnKMBaa8Mf6zbdrhbo1iRslSRnmUjiy+h5iliV+LBJGPW04YEdy50GRTyt15Xj1vK9Hg 3kvDhOqEeVkyl/LNTGhWxqmM6pXbuJALPT3qBClr71VekzAiWLdi/EhzzceFyqs3hXfe atC039xaQCgOSjg+FmZdC7yDVtvyoCP8BcdUeU0PqLVjeAlxGm6Q9aTM0Uv+zVvhxRiW h4d02phvjuG/BBbkjN3A3UUwix2UjkEvVG0UMNSRvb9xHaXdonVfTMgMzuSIeNdYF37K quPg== X-Gm-Message-State: APjAAAUAfgxT43YjQHnuesmwceOG2Hm4W0UzumxlNNTPtcLIhVjxqOfe EVtV1ymgrbR4pQOaTXR+WlC2KPGX X-Google-Smtp-Source: APXvYqztaZZ1lct12C8QjizN0CTbxr4o50FWEPOkb6cWEgvXbw75nOUCRv/2bad9VBlYlYhda96F2g== X-Received: by 2002:ac2:5a0e:: with SMTP id q14mr13059231lfn.47.1554678475283; Sun, 07 Apr 2019 16:07:55 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id h5sm5679975lfc.24.2019.04.07.16.07.53 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 07 Apr 2019 16:07:54 -0700 (PDT) In-Reply-To: <87o95hzhm0.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157331 Archived-At: On 07.04.2019 23:27, Juri Linkov wrote: >>> M-x project-search >>> >>> 1. can't use M-n to get the default value such as a word under point >>> like project-find-regexp does >> >> fileloop-initialize-search could set up next-error-function, I suppose. > > This is fine, but the point was about the minibuffer prompt. Ah yes. Sorry (M-n calls next-error in my Emacs). But the answer would be the same: it's not hard to implement for whoever is interested. The easiest fix would be to simply use project--read-regexp in the interactive spec, but it shows a different prompt, which might or might not be a problem (the prompts follow their commands' names). >>> M-x fileloop-continue >>> >>> 2. its name prefix is inconsistent with the prefix of its >>> counterpart command project-search >> >> It doesn't have to. fileloop-continue is intended to be used with different >> commands (e.g. some with dired- prefix as well). > > Maybe an alias with another prefix is in order? I don't think so. Or else the next step would be to set up multiple different key bindings, one for each alias. Which is obviously silly. >>> 3. no keybinding >> >> There's no keybinding for project-search either. The user is welcome to >> choose some. > > Maybe 'M-g M-n'? That's 'next-error', isn't it? Again, the user is welcome to choose whatever key binding that suits them. project-find-regexp, which is a lot handier IMO, has no default key binding either. I'm using 'C-x g'. >>> M-x project-find-regexp >>> >>> 4. shouldn't it support an optional more compact grep-like output >>> layout as well (where file names are on the same line with matches)? >> >> You can implement that via a custom xref-show-xrefs-function. Not trivial, >> but not a huge amount of work either. > > Good to know that xref is so much customizable. That's the original idea: to be customizable. Not sure if xref-show-xrefs-function in its current form facilitates it best, of course. We might add some other hooks in the future as well.