Dedicated *Help* frame and recent window.c changes

Dedicated *Help* frame and recent window.c changes

[Reiner Steib]

Hi,

Stephan's recent changes[1] to window.c break following the function
definition link in the *Help* buffer for me.  My special display
configuration includes (add-to-list 'special-display-buffer-names
'("*Help*" ((height . 30)))).  When I click on e.g. on `gnus.el' in
the *Help* buffer[2], I get "Window is dedicated to `*Help*'".  Before
this change, the source file got displayed in another frame or a new
frame (if `pop-up-windows' is t).

Bye, Reiner.

[1]
,----[ src/ChangeLog ]
| 2005-11-01  Stefan Monnier  <monnier@iro.umontreal.ca>
| 
| 	* window.c (window_loop): For LRU and LARGEST, let the `mini' argument
| 	determine whether to consider dedicated windows as well.
| 	(Fget_lru_window, Fget_largest_window): Add `dedicated' argument.
| 	(Fdisplay_buffer): Do consider dedicated windows in those cases where
| 	we will split the window rather than reuse it.
| 	Don't try to use windows on other displays.
`----

[2]
,----[ <f1> f gnus RET ]
| gnus is an interactive compiled Lisp function in `gnus.el'.
| It is bound to <menu-bar> <tools> <gnus>.
| (gnus &optional arg dont-connect slave)
| 
| Read network news.  [...]
`----
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Dedicated *Help* frame and recent window.c changes

[Stefan Monnier]

> Stephan's recent changes[1] to window.c break following the function
> definition link in the *Help* buffer for me.  My special display
> configuration includes (add-to-list 'special-display-buffer-names
> '("*Help*" ((height . 30)))).  When I click on e.g. on `gnus.el' in
> the *Help* buffer[2], I get "Window is dedicated to `*Help*'".  Before
> this change, the source file got displayed in another frame or a new
> frame (if `pop-up-windows' is t).

Hmm... I'll try to reproduce it.


        Stefan

Re: Dedicated *Help* frame and recent window.c changes

[Reiner Steib]

On Wed, Nov 02 2005, Stefan Monnier wrote:

>> Stephan's recent changes[1] to window.c break following the function
>> definition link in the *Help* buffer for me.  My special display
>> configuration includes (add-to-list 'special-display-buffer-names
>> '("*Help*" ((height . 30)))).  When I click on e.g. on `gnus.el' in
>> the *Help* buffer[2], I get "Window is dedicated to `*Help*'". [...]
>
> Hmm... I'll try to reproduce it.

I can reproduce it with...

emacs -Q --eval "(add-to-list 'special-display-buffer-names
  '(\"*Help*\" ((height . 30))))" --eval "(describe-function 'gnus)"

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Dedicated *Help* frame and recent window.c changes

[Stefan Monnier]

>>> Stefan's recent changes[1] to window.c break following the function
>>> definition link in the *Help* buffer for me.  My special display
>>> configuration includes (add-to-list 'special-display-buffer-names
>>> '("*Help*" ((height . 30)))).  When I click on e.g. on `gnus.el' in
>>> the *Help* buffer[2], I get "Window is dedicated to `*Help*'". [...]
>> 
>> Hmm... I'll try to reproduce it.

> I can reproduce it with...

> emacs -Q --eval "(add-to-list 'special-display-buffer-names
>   '(\"*Help*\" ((height . 30))))" --eval "(describe-function 'gnus)"

I believe it should now be fixed,


        Stefan

Re: Dedicated *Help* frame and recent window.c changes

[Reiner Steib]

On Thu, Nov 03 2005, Stefan Monnier wrote:

>> emacs -Q --eval "(add-to-list 'special-display-buffer-names
>>   '(\"*Help*\" ((height . 30))))" --eval "(describe-function 'gnus)"
>
> I believe it should now be fixed,

Yes it is fixed.  Thanks.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/