all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: display-buffer
Date: Thu, 03 Nov 2005 12:18:37 -0500	[thread overview]
Message-ID: <87zmolwt06.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <DNEMKBNJBGPAOPIJOOICMEEPCOAA.drew.adams@oracle.com> (Drew Adams's message of "Thu, 3 Nov 2005 08:09:13 -0800")

> As far as a workaround is concerned, I haven't found a good solution.  I do
> hacks like save the existing frame, display the buffer, then call
> select-frame-set-input-focus on the original frame.

What about the patch I'd suggested (see below)?
Does it do any good?


        Stefan


--- window.c	03 nov 2005 12:10:51 -0500	1.525
+++ window.c	03 nov 2005 12:10:23 -0500	
@@ -3473,7 +3473,13 @@
      we need to create a new frame.  */
   if (pop_up_frames || last_nonminibuf_frame == 0)
     {
+      Lisp_Object w = Fselected_window ();
+      struct gcpro gcpro1;
+      GCPRO1 (w);
       window = Fframe_selected_window (call0 (Vpop_up_frame_function));
+      if (Fwindow_live_p (w))
+	Fselect_window (w, Qt);
+      UNGCPRO;
       Fset_window_buffer (window, buffer, Qnil);
       return display_buffer_1 (window);
     }

  reply	other threads:[~2005-11-03 17:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-03  0:25 display-buffer Nick Roberts
2005-11-03 16:09 ` display-buffer Drew Adams
2005-11-03 17:18   ` Stefan Monnier [this message]
2005-11-03 19:32     ` display-buffer Drew Adams
2005-11-03 21:43     ` display-buffer Nick Roberts
2005-11-04  4:23       ` display-buffer Stefan Monnier
2005-11-05  5:05         ` display-buffer Nick Roberts
2005-11-05  5:19           ` display-buffer Luc Teirlinck
2005-11-05  7:38             ` display-buffer Nick Roberts
2005-11-03 21:40 ` display-buffer Richard M. Stallman
2005-11-03 21:49   ` display-buffer Drew Adams
2005-11-04  4:21     ` display-buffer Stefan Monnier
2005-11-04 10:45       ` display-buffer Eli Zaretskii
2005-11-05  1:36       ` display-buffer Richard M. Stallman
2005-11-05  1:37     ` display-buffer Richard M. Stallman
  -- strict thread matches above, loose matches on Subject: below --
2014-01-13 19:36 display-buffer Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zmolwt06.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.