From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: tramp-devel@gnu.org, Magnus Henoch <mange@freemail.hu>,
emacs-devel@gnu.org
Subject: Re: tramp (2.0.51); Saving SVN-managed files over Tramp fails
Date: Sun, 13 Nov 2005 18:19:00 -0500 [thread overview]
Message-ID: <87zmo8m94q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87oe4o6v4m.fsf@gmx.de> (Michael Albinus's message of "Sun, 13 Nov 2005 23:27:53 +0100")
>>>> I've reproduced the problem with more verbosity. I was confused about
>>>> svn in my last report - it's absent on the _remote_ host (not
>>>> available in the default path).
>>
>> If svn is absent on the machine where it's run, vc-svn-command is expected
>> (by vc-svn.el) to signal a `file-error'. Maybe the Tramp handling of
>> process-file signals a plain `error' in such a situation instead. In that
>> case, fixing Tramp to signal the proper error should fix your
>> problem.
> Finally, Tramp's implementation of shell-command is called. This runs
> the command without any check, and returns the return status from the
> remote host. One could try to improve it, with the disadvantage of
> more overhead.
Then does the patch below fix the problem acceptably (and does the comment
correctly describe the problem)?
Stefan
--- vc-svn.el 20 aoû 2005 19:26:18 -0400 1.21
+++ vc-svn.el 13 nov 2005 18:17:59 -0500
@@ -116,8 +116,11 @@
(cd (file-name-directory file))
(condition-case nil
(vc-svn-command t 0 file "status" "-v")
- ;; We can't find an `svn' executable. We could also deregister SVN.
- (file-error nil))
+ ;; Some problem happened. E.g. We can't find an `svn' executable.
+ ;; We used to only catch `file-error' but when the process is run on
+ ;; a remote host via Tramp, the error is only reported via the
+ ;; exit status which is turned into an `error' by vc-do-command.
+ (error nil))
(vc-svn-parse-status t)
(eq 'SVN (vc-file-getprop file 'vc-backend)))))
next prev parent reply other threads:[~2005-11-13 23:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <877jbclb1d.fsf@zemdatav.stor.no-ip.org>
2005-11-13 17:37 ` tramp (2.0.51); Saving SVN-managed files over Tramp fails Michael Albinus
2005-11-13 21:22 ` Stefan Monnier
2005-11-13 22:27 ` Michael Albinus
2005-11-13 23:19 ` Stefan Monnier [this message]
2005-11-13 23:41 ` Michael Albinus
2005-11-14 4:32 ` Stefan Monnier
2005-11-13 23:53 ` Magnus Henoch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmo8m94q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mange@freemail.hu \
--cc=tramp-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.