From: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Bug in incremental undrawing of mouseover highlighting
Date: Mon, 20 Nov 2006 14:22:47 -0500 [thread overview]
Message-ID: <87zmaludmg.fsf@cyd.mit.edu> (raw)
In-Reply-To: <17760.56196.739515.442009@rgrjr.dyndns.org> (Bob Rogers's message of "Sun\, 19 Nov 2006 17\:32\:36 -0500")
Bob Rogers <rogers-emacs@rgrjr.dyndns.org> writes:
> It seems that mouseover background highlighting is not undrawn if
> replaced by the same unhighlighted text. This happens in the CVS
> version as of late on 11-Nov.
The problem occurs because note_mouse_highlight checks only the window
and glyph positions to see if it needs to maintain the mouse
highlight. The relevant code is in xdisp.c:22819:
same_region = (EQ (window, dpyinfo->mouse_face_window)
&& vpos >= dpyinfo->mouse_face_beg_row
&& vpos <= dpyinfo->mouse_face_end_row
&& (vpos > dpyinfo->mouse_face_beg_row
|| hpos >= dpyinfo->mouse_face_beg_col)
&& (vpos < dpyinfo->mouse_face_end_row
|| hpos < dpyinfo->mouse_face_end_col
|| dpyinfo->mouse_face_past_end));
As far as I can tell, the simplest fix is to tell set_window_buffer to
reset the mouse face if the mouse face used to be associated with that
window. The patch below implements this.
*** emacs/src/window.c.~1.564.~ 2006-10-30 09:06:42.000000000 -0500
--- emacs/src/window.c 2006-11-20 14:13:08.000000000 -0500
***************
*** 3265,3270 ****
--- 3265,3275 ----
struct window *w = XWINDOW (window);
struct buffer *b = XBUFFER (buffer);
int count = SPECPDL_INDEX ();
+ #ifdef HAVE_WINDOW_SYSTEM
+ struct frame *f = XFRAME (w->frame);
+ Display_Info *dpyinfo = (f && FRAME_X_OUTPUT (f)) ?
+ FRAME_X_DISPLAY_INFO (f) : NULL;
+ #endif
w->buffer = buffer;
***************
*** 3345,3350 ****
--- 3350,3360 ----
call1 (Vrun_hooks, Qwindow_configuration_change_hook);
}
+ #ifdef HAVE_WINDOW_SYSTEM
+ if (dpyinfo && EQ (window, dpyinfo->mouse_face_window))
+ clear_mouse_face (dpyinfo);
+ #endif
+
unbind_to (count, Qnil);
}
next prev parent reply other threads:[~2006-11-20 19:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-19 22:32 Bug in incremental undrawing of mouseover highlighting Bob Rogers
2006-11-19 22:50 ` David Kastrup
2006-11-19 23:45 ` Bob Rogers
2006-12-13 14:45 ` Stephen Berman
2006-12-13 16:04 ` Chong Yidong
2006-12-14 9:22 ` Stephen Berman
2006-12-16 12:31 ` Stephen Berman
2006-11-20 4:20 ` Eli Zaretskii
2006-11-20 19:22 ` Chong Yidong [this message]
2006-11-20 20:24 ` misleading install instruction in emacs/mac/INSTALL Gilbert Harman
2006-11-21 7:47 ` Richard Stallman
2006-11-22 8:23 ` YAMAMOTO Mitsuharu
2006-11-22 17:07 ` Gilbert Harman
2006-11-20 20:36 ` Bug in incremental undrawing of mouseover highlighting Eli Zaretskii
2006-11-22 4:06 ` Bob Rogers
2006-11-22 18:35 ` Eli Zaretskii
2006-11-22 15:07 ` Chong Yidong
2006-11-22 22:20 ` Eli Zaretskii
2006-11-22 23:57 ` Nick Roberts
2006-11-23 4:12 ` Eli Zaretskii
2006-11-23 4:50 ` Nick Roberts
2006-11-24 18:18 ` Eli Zaretskii
2006-11-25 1:53 ` YAMAMOTO Mitsuharu
2006-11-25 4:18 ` Chong Yidong
2006-11-25 7:28 ` YAMAMOTO Mitsuharu
2006-11-25 10:53 ` Eli Zaretskii
2006-11-25 16:18 ` Chong Yidong
2006-11-25 21:10 ` Eli Zaretskii
2006-11-26 19:05 ` Kim F. Storm
2006-12-26 2:26 ` Richard Stallman
2006-12-27 3:58 ` Bob Rogers
2006-12-27 21:16 ` Richard Stallman
2007-01-02 15:46 ` Kim F. Storm
2007-01-05 0:38 ` Michael Mauger
2007-01-19 15:33 ` Chong Yidong
2007-01-20 21:40 ` Stephen Berman
2007-01-21 14:36 ` Stephen Berman
2007-11-07 22:18 ` Stephen Berman
2007-01-23 16:28 ` John Paul Wallington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmaludmg.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.