From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: Contiguous redisplay of the menu and beeps Date: Sun, 27 May 2007 22:32:28 -0400 Message-ID: <87zm3pd6f7.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1180319590 8330 80.91.229.12 (28 May 2007 02:33:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 28 May 2007 02:33:10 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 28 04:33:09 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HsV2h-0000Zc-II for ged-emacs-devel@m.gmane.org; Mon, 28 May 2007 04:33:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HsV2g-00073S-Tw for ged-emacs-devel@m.gmane.org; Sun, 27 May 2007 22:33:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HsV2d-00072h-Ii for emacs-devel@gnu.org; Sun, 27 May 2007 22:33:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HsV2b-00070h-4y for emacs-devel@gnu.org; Sun, 27 May 2007 22:33:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HsV2a-00070e-Va for emacs-devel@gnu.org; Sun, 27 May 2007 22:33:01 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HsV2a-0003yg-Kk for emacs-devel@gnu.org; Sun, 27 May 2007 22:33:00 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HsV2R-0001SY-Oe for emacs-devel@gnu.org; Mon, 28 May 2007 04:32:51 +0200 Original-Received: from wsip-24-249-26-23.ri.ri.cox.net ([24.249.26.23]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 May 2007 04:32:51 +0200 Original-Received: from cyd by wsip-24-249-26-23.ri.ri.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 May 2007 04:32:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: wsip-24-249-26-23.ri.ri.cox.net User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) Cancel-Lock: sha1:uUs474qP+Y5/JLt2TbKMCJ7ejtQ= X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71864 gmane.emacs.pretest.bugs:19018 Archived-At: YAMAMOTO Mitsuharu writes: > I meant the only direct call to `current_column' from > redisplay_internal: > > /* If %c is in the mode line, update it if needed. */ > if (!NILP (w->column_number_displayed) > /* This alternative quickly identifies a common case > where no change is needed. */ > && !(PT == XFASTINT (w->last_point) > && XFASTINT (w->last_modified) >= MODIFF > && XFASTINT (w->last_overlay_modified) >= OVERLAY_MODIFF) > && (XFASTINT (w->column_number_displayed) > != (int) current_column ())) /* iftc */ > w->update_mode_line = Qt; > > and as I said, binding Qinhibit_point_motion_hooks just around this > part as the following patch also works for me on Mac OS X. > > Could someone check if this works on Windows for the original problem? It fixes the bug as seen on GNU/Linux (i.e., with `debug-on-error' on, I no longer see a `forward-list' error with original bug recipe; I never observed the "other operations are blocked" part of the bug report on this platform.) Let's get this into the branch.